Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp583035iog; Mon, 13 Jun 2022 08:34:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTqTa8At6y5vtMr0jjEWklWX6rFBv9ISCd+KK4ZTzAeLcahDE4RXx6K3zlRoqGTWigu5x+ X-Received: by 2002:a63:3d0b:0:b0:37f:ef34:1431 with SMTP id k11-20020a633d0b000000b0037fef341431mr138182pga.547.1655134458428; Mon, 13 Jun 2022 08:34:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655134458; cv=none; d=google.com; s=arc-20160816; b=q51rYdnldf7+RDuw5Eo9NwoPqzJRgxdAk+XXbJsEn5eopzGKfHvCY/sY11rcpLpuFo hLWeyEtfUWoIgqcR3u+MirFdBr73IuRRE+Vzbj+GmaRjYQaHp9LwqzpMZGm4DeLw1jUo IV9bndap403W+X/uzaGyGYDU5gsJ5REP2RAtSKmk7BLKTXKb4GDT74JszdFXNtzOL731 LVlX0Wi6mvQjBdqD0Cj8suKh7pdZClFBsHucKJ1E6JYUokf04G9UW8yrtSxBXGNcbkF4 yM56yZXw+Wgl1ldnLlPTn4luz4dYKVRwkP3qsTAyuqAlLSlClBOQMP+J1wAu2ykwJ3MU DEpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Y0baFA/PSazmifULDtZW3wiyvNYQNZBnVdZZgBhd0YE=; b=sD/8mhxUhS5tGiMeL7MBUg7SyhdCvAbOQhfFDIazoIHMU2eeCy02+c5uEGGHfN61C1 RCh+60G6oEkOTMDcb62suGsH7+lxyM8iBYzfMFvHnErV5D6//aKDUDA6WR43q/IMeyQo nHvqKuJFmV1OWU9KPkWb3d8ILdMFCMwq8ieaiJ9Qv6UuQVehuyywKlLwx1PDOWOoNp2N U8gYk6VfOrKR/hJI8nKeYHAUynk42zfLpu18MOzKTXGUB2mkfekWvqtKQDeQjeiqdJNc Pc1+JrEl4RXqrmlP1wX1ue3e+gf5TIJ+3K3P0h3Jw+IgP2ZQB7hkPrUT1WVhJ7ihSxN4 UkZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GZMYKlp0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a14-20020a170902b58e00b00153b2d165d8si8770029pls.480.2022.06.13.08.34.04; Mon, 13 Jun 2022 08:34:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GZMYKlp0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357939AbiFMMGG (ORCPT + 99 others); Mon, 13 Jun 2022 08:06:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49554 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358647AbiFMMEa (ORCPT ); Mon, 13 Jun 2022 08:04:30 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 304464A93B; Mon, 13 Jun 2022 03:57:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AD394B80EA3; Mon, 13 Jun 2022 10:57:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C3DBC34114; Mon, 13 Jun 2022 10:57:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655117854; bh=REuaWyW5uskEwir9+iUVh14ktdiKIXAINWSm23//9Ks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GZMYKlp0+HGklhXDVteZ0Perx50JrgCE8eYyIA/hDaHmROGbq89t3Qwf0cy8bqG5L 2bA8fQCTioiWOn6yHZxe/rEecodzyauVaZyEwcddZ5QBTTzYQqDyVYRSDcKcmFxma7 yo7hS+Ah0+t7VbhdGXd2Csxb22k67STXIubg/4yk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Emmanuel Grumbach , Gregory Greenman , Johannes Berg Subject: [PATCH 4.19 144/287] iwlwifi: mvm: fix assert 1F04 upon reconfig Date: Mon, 13 Jun 2022 12:09:28 +0200 Message-Id: <20220613094928.242431406@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220613094923.832156175@linuxfoundation.org> References: <20220613094923.832156175@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Emmanuel Grumbach commit 9d096e3d3061dbf4ee10e2b59fc2c06e05bdb997 upstream. When we reconfig we must not send the MAC_POWER command that relates to a MAC that was not yet added to the firmware. Ignore those in the iterator. Cc: stable@vger.kernel.org Signed-off-by: Emmanuel Grumbach Signed-off-by: Gregory Greenman Link: https://lore.kernel.org/r/20220517120044.ed2ffc8ce732.If786e19512d0da4334a6382ea6148703422c7d7b@changeid Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/intel/iwlwifi/mvm/power.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/wireless/intel/iwlwifi/mvm/power.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/power.c @@ -611,6 +611,9 @@ static void iwl_mvm_power_get_vifs_itera struct iwl_power_vifs *power_iterator = _data; bool active = mvmvif->phy_ctxt && mvmvif->phy_ctxt->id < NUM_PHY_CTX; + if (!mvmvif->uploaded) + return; + switch (ieee80211_vif_type_p2p(vif)) { case NL80211_IFTYPE_P2P_DEVICE: break;