Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp583359iog; Mon, 13 Jun 2022 08:34:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwd7XRNwV+XL6WoOngxaI7P/C9aZfrDoIv1ItCD7cen+t3PabqoVTFL7vQArrsYGqoQfDv2 X-Received: by 2002:a05:6a00:1da6:b0:51b:fad1:c610 with SMTP id z38-20020a056a001da600b0051bfad1c610mr146609pfw.25.1655134476269; Mon, 13 Jun 2022 08:34:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655134476; cv=none; d=google.com; s=arc-20160816; b=cGmFx+vqT3py6WMREg00/EGYNknRUfQs+SbXtTfTwx2lwjaG0qI4ktq4j2j/CFWZYw uHib5YjA/enDkbrpP6I8sNSGlvTAUAil50/5/RHxAdPbjjWTYpXo4iNEmM6aGaUFgdGY liIReh+UE4wfOcon05Xwy+XNsVzhN2+Gxhqf5eX/3JkUg2NsYyHDzhGBti5DLfPmsLxM 1pLnRE/3zdIeU8c1FYNHFoxPVqndQlvQjgl4L5VVXhgvYH22KyhLturevwK+zmNj0T40 LY4Z9/6l/53NHRO1ScNK9rC1pKceLIKd02pVCbBXaBv2SuSfrMkjrSx51fecLF9hFhJT PFPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6Nt1d5Ca7nDC3iowHNFE9uY49yNip6GQqGVAQQpFmds=; b=J8GrVNO1LlI0foxM8ZXrhyCkTtYLnAxIEXNn4/Z3VPXgN+Tdzz/8o/A+Y8CyQhMuPQ teqHSZd02NX0ceITamL3WuZTJCzsOBzlMczOtnsKI1Ya0PF2Ax5vXwuqIKes6J7YLlKV BUuUUbUXmweC1Y6FNwwwHKKgNtVn0bUowl3t9V6Aa4OIdL3eXRs+Ebooohw7jWEBiP3a lGjei9pTlZafuHkuITIGbPcVgHt5AAxICTUaMMObgvld0P4/emQm1Mx8gbRxSlIGd1yD 7BozNveRVoQHqjT7zAR2Ln0y3sGXrqp9r7xHVnKiq3NklMy/hyX9RvZ2gBQ61WhW0S/W szUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wVexd7ii; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16-20020a17090311d000b001618e01b50fsi7513620plh.380.2022.06.13.08.34.22; Mon, 13 Jun 2022 08:34:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=wVexd7ii; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357663AbiFMNDg (ORCPT + 99 others); Mon, 13 Jun 2022 09:03:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358351AbiFMMzL (ORCPT ); Mon, 13 Jun 2022 08:55:11 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D83826F4; Mon, 13 Jun 2022 04:15:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BEA3D60B6B; Mon, 13 Jun 2022 11:15:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CCF50C34114; Mon, 13 Jun 2022 11:15:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655118907; bh=HV73AQN1kNcjmqMkArhjy0PLs8x/DcI7HaSRZwf/Jeg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wVexd7ii8FaqOnDmG4nYHOZaivLc1C0IhFaOF5UBjb3NWHNOWbAAoZIET1OdI2K23 /lHhpQbH/qAYuikpX+5ses3LErOdgfNAxgZ1zdu5BsNgpu4lXBbCKd0kg+Nsvh/15L vRnAvQedXS2mCmK+lKbR21A1W4WxtXLtZQ8nfbPM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Krzysztof Kozlowski , Neil Armstrong , Daniel Lezcano , Sasha Levin Subject: [PATCH 5.15 070/247] clocksource/drivers/oxnas-rps: Fix irq_of_parse_and_map() return value Date: Mon, 13 Jun 2022 12:09:32 +0200 Message-Id: <20220613094925.082500845@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220613094922.843438024@linuxfoundation.org> References: <20220613094922.843438024@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Krzysztof Kozlowski [ Upstream commit 9c04a8ff03def4df3f81219ffbe1ec9b44ff5348 ] The irq_of_parse_and_map() returns 0 on failure, not a negative ERRNO. Fixes: 89355274e1f7 ("clocksource/drivers/oxnas-rps: Add Oxford Semiconductor RPS Dual Timer") Signed-off-by: Krzysztof Kozlowski Reviewed-by: Neil Armstrong Link: https://lore.kernel.org/r/20220422104101.55754-1-krzysztof.kozlowski@linaro.org Signed-off-by: Daniel Lezcano Signed-off-by: Sasha Levin --- drivers/clocksource/timer-oxnas-rps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/timer-oxnas-rps.c b/drivers/clocksource/timer-oxnas-rps.c index 56c0cc32d0ac..d514b44e67dd 100644 --- a/drivers/clocksource/timer-oxnas-rps.c +++ b/drivers/clocksource/timer-oxnas-rps.c @@ -236,7 +236,7 @@ static int __init oxnas_rps_timer_init(struct device_node *np) } rps->irq = irq_of_parse_and_map(np, 0); - if (rps->irq < 0) { + if (!rps->irq) { ret = -EINVAL; goto err_iomap; } -- 2.35.1