Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp584386iog; Mon, 13 Jun 2022 08:35:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzXGcXJx+BIAyhK6acLH72Rcil8ZJboM4sjgxdfSXaLn7TDn2Sjf/6Z9+fslaRwJz+q70o8 X-Received: by 2002:a05:6a00:1805:b0:51c:1a6:2253 with SMTP id y5-20020a056a00180500b0051c01a62253mr168459pfa.70.1655134549797; Mon, 13 Jun 2022 08:35:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655134549; cv=none; d=google.com; s=arc-20160816; b=L94bZpeeDgCo16zzepUscgY1J+APQnLRRsgurHD9zvXfc9yV6V+b0EwN23qxZV9/k0 krsh2l7xctQoebhgzWyiw4Q+fpP0cvQ5OumJFGcrOPwv3u1GFhYoGbmO5whAAwdET7LR FskvunYJkNufbO+kg1CJKR2fFTuvnhqE/1kpbpZissHptS9Hs2U16WdL23bQ06n8hcql wR3fHmgpOQgpmtzi3lcHZBa2WPlsqgq3HAsXOptN4c6Psn/IwfHjlfezzkDNp9upUarF NC6fNX1vjrtsRNYHXrbXed7XIF8S879SD8IYPpgNNFN37UbcqUhYe/qLRXjixirNScuP 6TdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IP3cQeHcUIgXT0fmD/tpi90UdRw6EYmde4aT4D/sa1k=; b=BfFCfO4OL9ri8ySwwdNH2C0YvcwteL4U8ORf7J6y4JZZ9ObnKRopA/0EIfv4HpVB67 0/YUzQHYCAlkrrWXg2QSaIFfUHFwx0eNhYK5g5lvFoGuILjFsPNBV4/pEgaAcpV+t5v8 /7TWpK1TYs2agOiJ5Unv3+1XB8isLCYmdTom/JQjfx5JbmL58UyTJsh472r9wVz5AYxd FYo7OlVl9/rH0y7jzQFGNhYgdGXL7Ygg9h6+mnLw9IDYk4hGyKgWth8O6JsAGSr2+alk 9O+oi4Lql0fgZlRRFv8cY3x/0IM/DxnBFjbbeLaBpJ+/2nddqbQU2++IumGyogDXV4ql fPuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WhA+RiQH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b19-20020a637153000000b003fc5fe35f9asi9625612pgn.415.2022.06.13.08.35.37; Mon, 13 Jun 2022 08:35:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WhA+RiQH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1359350AbiFMNYx (ORCPT + 99 others); Mon, 13 Jun 2022 09:24:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377456AbiFMNUf (ORCPT ); Mon, 13 Jun 2022 09:20:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E63B6B01C; Mon, 13 Jun 2022 04:23:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F379861121; Mon, 13 Jun 2022 11:23:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E3D9C34114; Mon, 13 Jun 2022 11:23:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655119413; bh=HE9pJc3MBTefg0BQ/7370zg4d3v6Fos68pQ6N+Ze2nE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WhA+RiQHRAcNu5tz/3o6GUFsThVsonTykseDqRciwJhV7u6yGv1lWhNp6OIEVpasm BSfOj8QKTWIOZ/wCooDspBtoGIxwYmWabq5bA2qmVGx79LRmNIe9ExeolHviuTJzJR Dbu1EN7o/msByfGSSxj3H5a3OxqKNVmmGpr5l4/4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicolas Dichtel , Olivier Matz , Konrad Jankowski , Tony Nguyen Subject: [PATCH 5.15 230/247] ixgbe: fix bcast packets Rx on VF after promisc removal Date: Mon, 13 Jun 2022 12:12:12 +0200 Message-Id: <20220613094929.920752468@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220613094922.843438024@linuxfoundation.org> References: <20220613094922.843438024@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olivier Matz commit 803e9895ea2b0fe80bc85980ae2d7a7e44037914 upstream. After a VF requested to remove the promiscuous flag on an interface, the broadcast packets are not received anymore. This breaks some protocols like ARP. In ixgbe_update_vf_xcast_mode(), we should keep the IXGBE_VMOLR_BAM bit (Broadcast Accept) on promiscuous removal. This flag is already set by default in ixgbe_set_vmolr() on VF reset. Fixes: 8443c1a4b192 ("ixgbe, ixgbevf: Add new mbox API xcast mode") Cc: stable@vger.kernel.org Cc: Nicolas Dichtel Signed-off-by: Olivier Matz Tested-by: Konrad Jankowski Signed-off-by: Tony Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c @@ -1157,9 +1157,9 @@ static int ixgbe_update_vf_xcast_mode(st switch (xcast_mode) { case IXGBEVF_XCAST_MODE_NONE: - disable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE | + disable = IXGBE_VMOLR_ROMPE | IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE; - enable = 0; + enable = IXGBE_VMOLR_BAM; break; case IXGBEVF_XCAST_MODE_MULTI: disable = IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;