Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp587777iog; Mon, 13 Jun 2022 08:40:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9NYjqOmtSgHOnrlniqBBL4Fn1Gw3wmspsbIKVxf7OcH2pS0bappXPH3bA1hQLQ0cD6Vip X-Received: by 2002:a17:90b:4ccf:b0:1ea:264c:7c0c with SMTP id nd15-20020a17090b4ccf00b001ea264c7c0cmr16544975pjb.176.1655134802959; Mon, 13 Jun 2022 08:40:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655134802; cv=none; d=google.com; s=arc-20160816; b=sORNl4aTATeienFnwWXueSgfKtxIoR48cugCbGq/MR8QTPQt9KZal6TVs0zAO9YFID Gi6Q2VloeNxJx5ZqGWGTRTbPo9+QfoxOE9jjhfzN+FsXqTilZzW5wcWEJRJH5MNXR5jd pUg2EsVnC2bVvUWOVEXSuffd7POQbbdzSA72k4FbMnA1DukklMAyuqQXk/VBEdCs/uL9 oBubhikGKVci0Rso6RAX4/9v9j82yaUo5Zr7AxPk2gbzeD82ZR3SJnB3JsO5LYFJ0UN9 CPNgrrx/QZ6sNs/lfU8Gjys0BcW6SZaNka+FPOwJNaVvRiQyaMUYO4MVK4fVKZ14ZR34 AfZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=zAz5OVwMlsFhYT7KeeJB4vJfaC4h4HtrBACingourjY=; b=PvybLBrFe1ADvJyde6mnQQ6aHuTMpYF43T7lIjlCWxr6TaKez23P6tqdx62EkPsalD oE+NUvS0QG6603KZ0Yz/seTl/Zr6rdo0O7mADwQHlq4Ta4TkMgmVIC0da4+YKMJeEbAg j+5qKa8JP/5QhDPzBj4nYem6k3lJokUNFKLvN71jySDqBTz8b/QIUfWco0TDlCrYJYMS 4tpIjnKtiCahA0RopurI3ZNGXd8kIf/J55CSSfqiWm/yeyWACh4UZAuAxJOnoH3BeqXG UUr8zvGbuT98Je4JrGvp1mRyjcRmA2GLrbQGA77muoel/9QhCjk6AIkclAgi7KovnrnU 7SAA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W9JGmzPV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a12-20020a170902b58c00b001619467d844si10299244pls.296.2022.06.13.08.39.49; Mon, 13 Jun 2022 08:40:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W9JGmzPV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355326AbiFMLiZ (ORCPT + 99 others); Mon, 13 Jun 2022 07:38:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354307AbiFML3T (ORCPT ); Mon, 13 Jun 2022 07:29:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62D4A3EF13; Mon, 13 Jun 2022 03:43:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F3403B80D3B; Mon, 13 Jun 2022 10:43:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 285EFC3411C; Mon, 13 Jun 2022 10:43:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655116992; bh=NSpYyGGJXBbVhvCEmdzTJ3lzz03ll/lczQXkZqe5C3Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W9JGmzPV2YOn05OdJTpOfKmcFKigZ3heiljsPGe/9YRsUmHQV9WR0wvO5S2kpiVU8 004JdaYOmP73AjBhNFVR9B4a4IXyM47Fo8+9vHaINlrVZcp55fKRtrJaHMujrJfxSD SU1LnZR7yzaYdo+Wiax7FiMLyvzIgWCHkmAFQjNw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mark Brown Subject: [PATCH 5.4 259/411] ASoC: rt5514: Fix event generation for "DSP Voice Wake Up" control Date: Mon, 13 Jun 2022 12:08:52 +0200 Message-Id: <20220613094936.531337696@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220613094928.482772422@linuxfoundation.org> References: <20220613094928.482772422@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mark Brown commit 4213ff556740bb45e2d9ff0f50d056c4e7dd0921 upstream. The driver has a custom put function for "DSP Voice Wake Up" which does not generate event notifications on change, instead returning 0. Since we already exit early in the case that there is no change this can be fixed by unconditionally returning 1 at the end of the function. Signed-off-by: Mark Brown Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20220428162444.3883147-1-broonie@kernel.org Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/codecs/rt5514.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/codecs/rt5514.c +++ b/sound/soc/codecs/rt5514.c @@ -419,7 +419,7 @@ static int rt5514_dsp_voice_wake_up_put( } } - return 0; + return 1; } static const struct snd_kcontrol_new rt5514_snd_controls[] = {