Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp588183iog; Mon, 13 Jun 2022 08:40:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyipDuv1njR7S/0njCui3c8e4jt/q31lzPml/0jZlV/ABAni34Sh6w255+3dodFW0Biww2E X-Received: by 2002:a17:90b:18b:b0:1ea:79c7:d6fe with SMTP id t11-20020a17090b018b00b001ea79c7d6femr16333955pjs.214.1655134833801; Mon, 13 Jun 2022 08:40:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655134833; cv=none; d=google.com; s=arc-20160816; b=VDy9L4niI46wHf/Ig1c5NO82qkyX2HSWiHyjuPUIUi+TIZvrAebZFZ3yJslc0R7qUX gV+6QfzsT9FM/hghEr/ss3q9h0jjNTmqf8ebajUGMfRLai57IxVdILawAn/s+slw1q5V TtaN+XOWxl/PIxly3LmwqbN3J7HCF+F8wl1/2TJWQ0XFPMMcimZQfionBguAowPDTob/ xfTamwSFXxYxuxOLjB2sE9MyFHRPDlttpIS1do2b2wsuKUKCdnajdlaPB7GHWZLV5bk8 ChSZEuKVs0CL0FzzNMb0PwfsSIgzpJ4cdH9eT3LXhHF3TNbcrLoQz9ecSZLjt3+eoYtt RqNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4S9vhg+Bz4W1GHlcT4MVaDWy7Xko3A9GH1aYE2M4mmw=; b=UMMnL6pPNlqq3P8vawYhVMaL52DNYMq2/JEU/moxQVJR74O/TXOwbnN1SNZzljiQxh TTPUtIVrni0avwET10tz5oN6Ud7irzJn2EXYaU8e/ByY2X5FQssMLJHPaZgWKDXjHeNl Nw//l9xiTVMbFPNYCN/XWNOa18yIJzwKlvy2x/IgFozTY3K4FNsHSeiWWZ93gMFmI5o9 XGp6CCpJ5WJECPGXTNE1D2DT5YvxasVTHclUE2MtelZeZquUqZNXr/skWQNoMK3BRuCu VmzFwdRmR1XUVYK7AMH/U6XcttzSSIghaUZc6fGawqj3oqdSszFHW/MI726roQ7By+DU h0tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OLHK5hxp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w14-20020a170902e88e00b00167863f828dsi12220197plg.119.2022.06.13.08.40.18; Mon, 13 Jun 2022 08:40:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=OLHK5hxp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357691AbiFMNGc (ORCPT + 99 others); Mon, 13 Jun 2022 09:06:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354587AbiFMMzm (ORCPT ); Mon, 13 Jun 2022 08:55:42 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC1FC1117B; Mon, 13 Jun 2022 04:16:34 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A51B0B80EAA; Mon, 13 Jun 2022 11:16:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E99CC3411E; Mon, 13 Jun 2022 11:16:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655118992; bh=cbX6OY6RNJbguBJonjIdBD44LgzCrkQUfXN+abLuJMI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OLHK5hxpAFhjxnPXgYS+EffwwMBrOU2Q+AzPou0psvyWbQ/z2R1pc2kbbfZTsShkT 0y+XTwpdA3m+Ivvbm5fAcOzBHxgO9usM2g6ojj0WLwzNbNZmxr5s6t2ZMJ1DpOvZYM D+xAHsjDI+FUBzmco4Hk+MZqJxkfnr4IM95Jl9GY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Paolo Abeni , Sasha Levin Subject: [PATCH 5.15 101/247] octeontx2-af: fix error code in is_valid_offset() Date: Mon, 13 Jun 2022 12:10:03 +0200 Message-Id: <20220613094926.019685814@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220613094922.843438024@linuxfoundation.org> References: <20220613094922.843438024@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit f3d671c711097a133bc36bd2bde52f1fcca783a6 ] The is_valid_offset() function returns success/true if the call to validate_and_get_cpt_blkaddr() fails. Fixes: ecad2ce8c48f ("octeontx2-af: cn10k: Add mailbox to configure reassembly timeout") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/YpXDrTPb8qV01JSP@kili Signed-off-by: Paolo Abeni Signed-off-by: Sasha Levin --- drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c index 1f90a7403392..4895faa667b5 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cpt.c @@ -206,7 +206,7 @@ static bool is_valid_offset(struct rvu *rvu, struct cpt_rd_wr_reg_msg *req) blkaddr = validate_and_get_cpt_blkaddr(req->blkaddr); if (blkaddr < 0) - return blkaddr; + return false; /* Registers that can be accessed from PF/VF */ if ((offset & 0xFF000) == CPT_AF_LFX_CTL(0) || -- 2.35.1