Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp590604iog; Mon, 13 Jun 2022 08:43:30 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sZ399nXF53q6LP63oab87QNkDBDEFp6Uxb0RGtbXU/G2lwBq3n1vbFd13mk4K90DkfACl/ X-Received: by 2002:a17:907:3e0d:b0:711:dbff:b830 with SMTP id hp13-20020a1709073e0d00b00711dbffb830mr390566ejc.601.1655135010029; Mon, 13 Jun 2022 08:43:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655135010; cv=none; d=google.com; s=arc-20160816; b=WyNX+ek3cYkcojsHGOLmPayML0V0HZgDPZoi6ymrJ7jhdM7YFdnWNUad61Mje/cSPq UA+5YwAD6iQ6ckDzd0L1/ZDUZIZGzcsjsS79gefCzNSGNr+5Ad8LOI+QOAahLTE1u5ph zmz8RLUa3CV151ZSQB23dUjPz3A9LfYQI33Z1g2ZPs9UJ51fhKmCvejA3+/i74GjZ+sv kyJ2t0pnyTIRzo8bY46rmK/x+uAxOiP612+x6ngypZCyeuB0pgW1DPPxqMKqWW5AtOEo dt5bYEWNPdktPPo01cQ+JOuEgjYHQevJ/UEbXSjJ45kChqvuei/a4/LjCEDSlAhgoU3X tCuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IP3cQeHcUIgXT0fmD/tpi90UdRw6EYmde4aT4D/sa1k=; b=wrJCw1wZV5Zb4Xq7CsH1R2e0e9XWYzH/4XpUB6DdaG/EsYTQCgSrYbgnkPKPm8anV8 ATFFoGiK0tm8f+2CjsYZyrlV30hRZ8ACQ1oUP3e1U/eY5SXr+PrbNt5z8l41d138pue1 Eoc/0FZX9wmVtnAuLjpESbXnvq85UtAQbP3eFPxx6OJ9uSqGuQ/D2B++uTvLI3wtA3ik +SvfCB1qs/qT0cPrpRZyc6oVXivJIL0ag720eOgRK+NuFotA+mNr1bAk58zOTF+nZSZh Tw6L69VTUspnFHVnW49ZDMaeO83dK7sGzA3FEHa+l1UiOagR1I4lF5B7oMmfnKQupvSR 9YPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sUPpVymL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p18-20020a056402045200b0042dd723a671si6923915edw.272.2022.06.13.08.43.04; Mon, 13 Jun 2022 08:43:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sUPpVymL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357780AbiFML5i (ORCPT + 99 others); Mon, 13 Jun 2022 07:57:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356606AbiFMLuq (ORCPT ); Mon, 13 Jun 2022 07:50:46 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85602248FF; Mon, 13 Jun 2022 03:54:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 22C1760EFE; Mon, 13 Jun 2022 10:54:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3284CC34114; Mon, 13 Jun 2022 10:54:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655117667; bh=HE9pJc3MBTefg0BQ/7370zg4d3v6Fos68pQ6N+Ze2nE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sUPpVymLc2gBtRR1tf6U4R3ZhX3pzps4tGaE6TiT/bkexZuDjp2rjxD658Te+q5v/ ZuHInQnggfwbqx61BCkfDynz/ImRyC/cdwwK7xNDPC5OO1a36gr1bBDHz9MmPPMkd7 OAopJ++n9gjpRZ2tJMvHMEUx9SnMsf1A+pNSwEoc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicolas Dichtel , Olivier Matz , Konrad Jankowski , Tony Nguyen Subject: [PATCH 5.4 406/411] ixgbe: fix bcast packets Rx on VF after promisc removal Date: Mon, 13 Jun 2022 12:11:19 +0200 Message-Id: <20220613094940.996158736@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220613094928.482772422@linuxfoundation.org> References: <20220613094928.482772422@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Olivier Matz commit 803e9895ea2b0fe80bc85980ae2d7a7e44037914 upstream. After a VF requested to remove the promiscuous flag on an interface, the broadcast packets are not received anymore. This breaks some protocols like ARP. In ixgbe_update_vf_xcast_mode(), we should keep the IXGBE_VMOLR_BAM bit (Broadcast Accept) on promiscuous removal. This flag is already set by default in ixgbe_set_vmolr() on VF reset. Fixes: 8443c1a4b192 ("ixgbe, ixgbevf: Add new mbox API xcast mode") Cc: stable@vger.kernel.org Cc: Nicolas Dichtel Signed-off-by: Olivier Matz Tested-by: Konrad Jankowski Signed-off-by: Tony Nguyen Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c @@ -1157,9 +1157,9 @@ static int ixgbe_update_vf_xcast_mode(st switch (xcast_mode) { case IXGBEVF_XCAST_MODE_NONE: - disable = IXGBE_VMOLR_BAM | IXGBE_VMOLR_ROMPE | + disable = IXGBE_VMOLR_ROMPE | IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE; - enable = 0; + enable = IXGBE_VMOLR_BAM; break; case IXGBEVF_XCAST_MODE_MULTI: disable = IXGBE_VMOLR_MPE | IXGBE_VMOLR_UPE | IXGBE_VMOLR_VPE;