Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp618159iog; Mon, 13 Jun 2022 09:15:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vBB3QxKuf4FYttDRzweU7ynWCIhmUlDxDw5zTZFhcWUIzVH6U/zcnefbz2EOmR6y/ykNSq X-Received: by 2002:a17:90a:468d:b0:1df:39da:322b with SMTP id z13-20020a17090a468d00b001df39da322bmr528990pjf.137.1655136907593; Mon, 13 Jun 2022 09:15:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655136907; cv=none; d=google.com; s=arc-20160816; b=gcV9Q+3msd1LKeYgbiza/t0IvXCUejjkf1g2GjlsjC0FehyzazanbGJnAsgUDoStn/ ah6WV0hEqfvvCoJwcH+uz5o8Rv9MU2Q+QG/UurC9BTujMXtCyiNSOmfcVn2sWUCOpbE4 WWerYS0etQ9PC3AX3TfaQBapet8IPoFxKAVp4+gX7GnCvirYUQn8hJwlTMwvK8k9zFuB Otfz9MuR3ngs6i4tsxaGi7gPuxeZl7klici3P57DVyIZ8UbJ5hIYZNZhazergBg+LTWW zOvJnkwna3RTyh4jA0Uppg6LMyc9pK9Gup4ZwUq1ud+I4LeczHkNO3IZqnkqmfeejp5H 0Xuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=AivvjuIIngjRS40OP+WvtMEV5kz9ju69kEQFvO5ZOBs=; b=k+E6VRfOU4Mj6iJwxZf+tUTdlpihvpHxsKqvPqrWr7nKU9fBbZvzrKxPTa/2Vyg1Wp B6vIMh15Ak10jLlc8YPK/ck/zJ1/Z/JcbuIPJzwNdoMGm3ifJJNR12HPJmWMf5zDxnHq R4lkuqwJ5ApCmFZLEutC4yTzmMQArWX9jmWCXSuBDOLP8eLWNMiD+EnNik6s8g5BiLaE Iy1wrV+t7F+D7iZF30RchZ1kNOjQ6RVifbg6Vho/Vt5gVF2wDQulRrcyeCgVbUNTDYyY GdhLw6WoGi+26zZYP6+01/A8p0Hi/wq7XhyZt8/PISV+dF3qsh3wFN2gneV/6GlX9TdZ Guxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZTTaPqSY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r83-20020a632b56000000b003fc4d7e5410si10152570pgr.850.2022.06.13.09.14.49; Mon, 13 Jun 2022 09:15:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZTTaPqSY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239858AbiFMNFj (ORCPT + 99 others); Mon, 13 Jun 2022 09:05:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358285AbiFMMzK (ORCPT ); Mon, 13 Jun 2022 08:55:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36A5C9589; Mon, 13 Jun 2022 04:14:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C7F2760B6B; Mon, 13 Jun 2022 11:14:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D3AA3C3411E; Mon, 13 Jun 2022 11:14:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655118896; bh=wBCeYx+pNV/e5mIu30VKRdK4jv593PGbP3FGh/J2fMQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZTTaPqSY9My2GXqy/8r5IVKGV6nCCyS6BWJfjQdAFYe8IKKtAMpL8FVwAiZVC8Mjy Vq7sPEf2S9IJ7aDc5tyAfWu7ZTi4+2UO1Jdymi1ajqS+1gUfA0U5Fvbo9/t4BLWCqW RM8cxPgOcKlCACRqkdF3uGAO8WDzo8jiMHp7I1w4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Guenter Roeck , Wim Van Sebroeck , Sasha Levin Subject: [PATCH 5.15 066/247] watchdog: rti-wdt: Fix pm_runtime_get_sync() error checking Date: Mon, 13 Jun 2022 12:09:28 +0200 Message-Id: <20220613094924.960433521@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220613094922.843438024@linuxfoundation.org> References: <20220613094922.843438024@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Miaoqian Lin [ Upstream commit b3ac0c58fa8934926360268f3d89ec7680644d7b ] If the device is already in a runtime PM enabled state pm_runtime_get_sync() will return 1, so a test for negative value should be used to check for errors. Fixes: 2d63908bdbfb ("watchdog: Add K3 RTI watchdog support") Signed-off-by: Miaoqian Lin Reviewed-by: Guenter Roeck Link: https://lore.kernel.org/r/20220412070824.23708-1-linmq006@gmail.com Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Signed-off-by: Sasha Levin --- drivers/watchdog/rti_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/rti_wdt.c b/drivers/watchdog/rti_wdt.c index ae7f9357bb87..46c2a4bd9ebe 100644 --- a/drivers/watchdog/rti_wdt.c +++ b/drivers/watchdog/rti_wdt.c @@ -227,7 +227,7 @@ static int rti_wdt_probe(struct platform_device *pdev) pm_runtime_enable(dev); ret = pm_runtime_get_sync(dev); - if (ret) { + if (ret < 0) { pm_runtime_put_noidle(dev); pm_runtime_disable(&pdev->dev); return dev_err_probe(dev, ret, "runtime pm failed\n"); -- 2.35.1