Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp618764iog; Mon, 13 Jun 2022 09:15:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzgDo/iFPKmBNYAdR40Pw7lR+17Cy4eZiQRGAyoOvScz3/TFIDHW+fZE/49lBELB4UEtkC6 X-Received: by 2002:a63:1a56:0:b0:405:28e3:e4fb with SMTP id a22-20020a631a56000000b0040528e3e4fbmr367106pgm.16.1655136939119; Mon, 13 Jun 2022 09:15:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655136939; cv=none; d=google.com; s=arc-20160816; b=UaEl+TfuQQS/AkIMfWr8vFs6DgGzktT26Eme2lUSBr7+7YwSKrFnfZCla2Q9rVCDG4 mPZyE9MrsomBYaRqpBzXS9l8L/EcLXUJnFNHDLHovZp5g2xZDz2Sjfcs79D//Lt/1dFi Xz8JYigquurbnhvTy1iPosn9MT3CuaEUWkdubKQJ5ndij3AW1BDw8gBsZ6NgPMWBoWRA 1d8YYtRRdFezJoZTi0TB0sjDAKi1bHbJjiEzgKdZfpGm+ZatpHQGsyWopYCVcSliZ9gP uw4hJUjhyYA9h9El0xiIxQOjslXOw/T+SQ1UhG9c4XeyCoz/gjWA0R5KONfZkOjHFzWV AcDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pl18ES5ITIE7+sVEA9GB5JrKagD4PDi+r/yT2r//a98=; b=gXHYJtfxkZzRd1si9nItoTm7NsgixZJMsvB34AsGPpxMgmYWPR9EHBMm43b0x6yqvt LB0IVkrQeEsFObn+g9pjBjAf4Xxhykku1RrwglVUW2Bpde+hz5mdYovLoaSaJJZQ3bxV mdW33jftxTvIB2W5uacbhkvbhiQq3gAHlkldKSKwZ5MPPJL06ME2rtC+PoeSXeLVW2Mt 81sUZuUBPelpNMBLUtvwyFhOAQJonbtXrNzIamPQ6VhNTIS/nO9iX5b9tqACkr/r1+h2 Zw4QkanUL0APyQg2ofzqn2h6DKAUh+d9zykfr1c7duwDF2HS+MRDhEWVof/OmvW0Tr9Z aLCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E0KPcldg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ct19-20020a056a000f9300b0051c09f5253bsi8654198pfb.204.2022.06.13.09.15.25; Mon, 13 Jun 2022 09:15:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=E0KPcldg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357688AbiFMM7U (ORCPT + 99 others); Mon, 13 Jun 2022 08:59:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354615AbiFMMxd (ORCPT ); Mon, 13 Jun 2022 08:53:33 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 823711EAEC; Mon, 13 Jun 2022 04:12:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id A3E2CCE1174; Mon, 13 Jun 2022 11:12:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B8A9C34114; Mon, 13 Jun 2022 11:12:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1655118754; bh=zha2dROxJNfVeY3ac8jBE+pOULrvQBeoRLrNGrfbVns=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E0KPcldgfJl8FOx9jSgNgNWH95UXmdxw3qY/8iPHuujaGMdPLVj5PQFSs0LZqJdzE a6VPwcjX5B7HDFcDNTCZSGc3uzZ6UxsmZF8qJQMP4D6hbksGIJqATk3/ywmAQ9rL6p b4lZjezLabp7SMcnmy0uHvQrrqV9uhzsBdxVFZFs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Sasha Levin Subject: [PATCH 5.15 016/247] staging: fieldbus: Fix the error handling path in anybuss_host_common_probe() Date: Mon, 13 Jun 2022 12:08:38 +0200 Message-Id: <20220613094923.420381405@linuxfoundation.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220613094922.843438024@linuxfoundation.org> References: <20220613094922.843438024@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 7079b3483a17be2cfba64cbd4feb1b7ae07f1ea7 ] If device_register() fails, device_unregister() should not be called because it will free some resources that are not allocated. put_device() should be used instead. Fixes: 308ee87a2f1e ("staging: fieldbus: anybus-s: support HMS Anybus-S bus") Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/5401a519608d6e1a4e7435c20f4f20b0c5c36c23.1650610082.git.christophe.jaillet@wanadoo.fr Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/fieldbus/anybuss/host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/fieldbus/anybuss/host.c b/drivers/staging/fieldbus/anybuss/host.c index 8a75f6642c78..0c41d1e0204f 100644 --- a/drivers/staging/fieldbus/anybuss/host.c +++ b/drivers/staging/fieldbus/anybuss/host.c @@ -1384,7 +1384,7 @@ anybuss_host_common_probe(struct device *dev, goto err_device; return cd; err_device: - device_unregister(&cd->client->dev); + put_device(&cd->client->dev); err_kthread: kthread_stop(cd->qthread); err_reset: -- 2.35.1