Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 13 Jun 2022 17:33:35 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Haren Myneni <haren@linux.ibm.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>
Subject: drivers/crypto/nx/nx-common-pseries.c:1146 nxcop_get_capabilities()
 error: uninitialized symbol 'hv_nxc'.
Message-ID: <202206121940.30TYe8Nk-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZTqTR6MSNtn27MlMJO3/wzIEQ/kUwtbGw1IvV2RS2+6F8TPXkIgXYJevGuFf?=
 =?us-ascii?Q?bc/2y14zT+ZpU22BBvx5TF6RwV0ZNrHWCHZg+oEGmsh79NW1yogQUjkCqvh0?=
 =?us-ascii?Q?tyPT4PfQ/DivDjgIRKboMyrW6Z+l7ysVUM9JQMBjZ/tajxxQJRql18A/5Mhy?=
 =?us-ascii?Q?bAYAkUM+KgwC7WIXpNamrZmOcbGGFq2J/RuOQFcnxpJyNV62qxUA3kr+wlsL?=
 =?us-ascii?Q?gLirkmwIsCcG0RwJUp71ZjGPNBbplLzfzxtO5C9myFcwhtaB/TmjhgRPtola?=
 =?us-ascii?Q?Xx2kR7TkWDbHYR4gQdIV8MgVEJ/1SNF3QNU/m1GIffOirXEeX+wWcrAM8a/N?=
 =?us-ascii?Q?WGjvwNFnUOOyNyXkIrbfN0X49jrCkVs+MPcgZkWHRFEWNstjddXQR8Eqbc2q?=
 =?us-ascii?Q?BUcJr8Sb3i6Y5Zj7irDAV+nTTUhG7T0zLdlS45Z+mbPLMvwxaM1nabXY4eWg?=
 =?us-ascii?Q?II1B6YdMTrAfoUB2k04clJkciUYILOG8UZAZwMojV9tZUekTTSJ4dv03Wj6o?=
 =?us-ascii?Q?88ukv9Cj5PRKzBybBQ3NDG7JdkHulSyI4CCcUPd6S+KWheUcX9BDdInmNkNI?=
 =?us-ascii?Q?JE6d/ah07+K/LYVRM21CUzGb3n81FdSNEiXUPvATw1XZGXKMgRIJ4lPpYI7N?=
 =?us-ascii?Q?Ih8egeDU4W3RZaB3WpLxlUgZaXg+WuMug1LMddLxCjbswTjH3hLphjeAKST0?=
 =?us-ascii?Q?0Ao7+P9slRxeMKYzScv1JdZHaX0IpadN+0epJdf6eGKM7hZdsOQtX6vrqTtc?=
 =?us-ascii?Q?VEhb2yq2gNJHCSNaTy77X7G0X8laRWpJciEmVPbfRxS1nHfE1C/fkRQAHcbA?=
 =?us-ascii?Q?kV9/qdCWPiGlpNpUKFJkMAl/j9iE8WTkbLAHVmhq4Rju6P/YMlmci7MoUdVi?=
 =?us-ascii?Q?dM/2M3xMQQ0dN1GU0/eiSErfK0uCO3buKJlLwc2xFqHCrNcCI77+pvLDzURD?=
 =?us-ascii?Q?BHViz55VsMqpf62rZF20yUEdDKzzn6hbEk/uhtmGiV2HKYIGcJT8e3C4Fl5p?=
 =?us-ascii?Q?gKYOWSbAOv6Of1/zBemySFcqcZc/7lrqaIUrrgS5qO+LtLLXJxs4VTsZcyAd?=
 =?us-ascii?Q?M9y1ho10+M4l30Oa5rvLeSHw4sd2rXo1kbjHNzjT+S/ID0qBrLMRz6dhpyl5?=
 =?us-ascii?Q?lgJONdcjndwGUHgMU3J6Lb7lMsTfs4VREe3rZ2iAYP6QOlJR6Ed5oGgNNGQa?=
 =?us-ascii?Q?0hLVkj0Sek65fbfP5eOGvYtwjmxGgb6CFStTGjLWaZNpJMcJmp4qYY5oUOC7?=
 =?us-ascii?Q?MhV86bGoGjR4tTz7Vfqak//HjTdMbnt14VtM9SLCmbzu9kdCWT5a950DNT7P?=
 =?us-ascii?Q?ycABf1DHtrB+02wHKrcvl9EiVyHB6VD5PuTt+D/fHpc8+wiZFmBwCyxPFcpa?=
 =?us-ascii?Q?tbbl1QodGvWU/dVF2OfD7UHg/NTW7WnL+OnXtiGY9oAyK4BiM9X3C46bQqbB?=
 =?us-ascii?Q?0MA1dGasnfDY59yUlLtJXOBvVTBPOm36ya7iJJAd7pn1w+56pUJ9ORPohXYo?=
 =?us-ascii?Q?+C0uE9bCJZgJVe8Efxy8EfBQHtGRbtiiPJMxBoUTnzsW1u7zjXC9eIOivjAT?=
 =?us-ascii?Q?Wru9XZGE6E9oR4PEvF3rj5HDbK8sW2lmV3pKY4BFl8hLN0215qy2qXq/dSCC?=
 =?us-ascii?Q?XCfavyL88VbzYfa/OUWJVR1ddtt62dNtaj//t++fcnW+PfseSBMWF9tCEBWg?=
 =?us-ascii?Q?pJu+R6X+8YvRZkpU72OMFV/9PDxo6l/lSGpUymjRvt46cDOuDGPgxmPDtV0D?=
 =?us-ascii?Q?BRqLdx/X3wBnmBwxetcJTX/+XpnDjTg=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b0bd0cff-5c99-4770-0a4a-08da4d49ba04
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 14:33:47.6530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xhrzRL7AiHAjo1cBVccQ+bRSJsQ3/THNjWNzn1TADViGbWMK9WqEUXcRMLPk7II2cK6pyKZq6XLNilRpg8p8+YCYqpwjItEkDBAZiKwkYYE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1371
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-13_06:2022-06-13,2022-06-13 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206130065
X-Proofpoint-ORIG-GUID: 4MSOEMB2Wy-YZTn3ZkMcG170U1NgdmnP
X-Proofpoint-GUID: 4MSOEMB2Wy-YZTn3ZkMcG170U1NgdmnP
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HEXHASH_WORD,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   0678afa6055d14799c1dc1eee47c8025eba56cab
commit: b4ba22114c78de48fda3818f569f75e97d58c719 crypto/nx: Get NX capabilities for GZIP coprocessor type
config: powerpc64-randconfig-m031-20220611 (https://download.01.org/0day-ci/archive/20220612/202206121940.30TYe8Nk-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/crypto/nx/nx-common-pseries.c:1146 nxcop_get_capabilities() error: uninitialized symbol 'hv_nxc'.

vim +/hv_nxc +1146 drivers/crypto/nx/nx-common-pseries.c

b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1098  static void __init nxcop_get_capabilities(void)
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1099  {
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1100  	struct hv_vas_all_caps *hv_caps;
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1101  	struct hv_nx_cop_caps *hv_nxc;
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1102  	int rc;
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1103  
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1104  	hv_caps = kmalloc(sizeof(*hv_caps), GFP_KERNEL);
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1105  	if (!hv_caps)
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1106  		return;
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1107  	/*
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1108  	 * Get NX overall capabilities with feature type=0
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1109  	 */
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1110  	rc = h_query_vas_capabilities(H_QUERY_NX_CAPABILITIES, 0,
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1111  					  (u64)virt_to_phys(hv_caps));
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1112  	if (rc)
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1113  		goto out;
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1114  
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1115  	caps_feat = be64_to_cpu(hv_caps->feat_type);
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1116  	/*
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1117  	 * NX-GZIP feature available
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1118  	 */
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1119  	if (caps_feat & VAS_NX_GZIP_FEAT_BIT) {
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1120  		hv_nxc = kmalloc(sizeof(*hv_nxc), GFP_KERNEL);
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1121  		if (!hv_nxc)
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1122  			goto out;
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1123  		/*
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1124  		 * Get capabilities for NX-GZIP feature
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1125  		 */
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1126  		rc = h_query_vas_capabilities(H_QUERY_NX_CAPABILITIES,
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1127  						  VAS_NX_GZIP_FEAT,
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1128  						  (u64)virt_to_phys(hv_nxc));
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1129  	} else {
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1130  		pr_err("NX-GZIP feature is not available\n");
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1131  		rc = -EINVAL;

hv_nxc is not initialized on this path.

b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1132  	}
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1133  
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1134  	if (!rc) {
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1135  		nx_cop_caps.descriptor = be64_to_cpu(hv_nxc->descriptor);
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1136  		nx_cop_caps.req_max_processed_len =
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1137  				be64_to_cpu(hv_nxc->req_max_processed_len);
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1138  		nx_cop_caps.min_compress_len =
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1139  				be64_to_cpu(hv_nxc->min_compress_len);
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1140  		nx_cop_caps.min_decompress_len =
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1141  				be64_to_cpu(hv_nxc->min_decompress_len);
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1142  	} else {
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1143  		caps_feat = 0;
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1144  	}
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1145  
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17 @1146  	kfree(hv_nxc);
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1147  out:
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1148  	kfree(hv_caps);
b4ba22114c78de4 drivers/crypto/nx/nx-common-pseries.c Haren Myneni  2021-06-17  1149  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp