Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 13 Jun 2022 16:33:21 +0200
From:   Miquel Raynal <miquel.raynal@bootlin.com>
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>
Cc:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Tom Rini <trini@konsulko.com>,
        Ahmad Fatoum <a.fatoum@pengutronix.de>,
        linux-arm-kernel@lists.infradead.org, u-boot@lists.denx.de,
        devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
Subject: Re: [PATCH V3 1/2] mtd: allow getting MTD device associated with a
 specific DT node
Message-ID: <20220613163321.6c3ccb5e@xps-13>
In-Reply-To: <ad084c13-55fc-8506-f768-49a0c6ae4f7f@gmail.com>
References: <20220611204651.19947-1-zajec5@gmail.com>
        <20220613160411.48b07515@xps-13>
        <ad084c13-55fc-8506-f768-49a0c6ae4f7f@gmail.com>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Rafa=C5=82,

zajec5@gmail.com wrote on Mon, 13 Jun 2022 16:15:34 +0200:

> On 13.06.2022 16:04, Miquel Raynal wrote:
> >> @@ -1154,6 +1154,34 @@ int __get_mtd_device(struct mtd_info *mtd)
> >>   }
> >>   EXPORT_SYMBOL_GPL(__get_mtd_device); =20
> >>   >> +/** =20
> >> + * of_get_mtd_device_by_node - obtain an MTD device associated with a=
 given node
> >> + *
> >> + * @np: device tree node
> >> + */
> >> +struct mtd_info *of_get_mtd_device_by_node(struct device_node *np) =20
> >=20
> > Shall we try to use a more of-agnostic syntax or is it too complex here=
? =20
>=20
> I need some extra hint, please. This is how many similar functions look
> like:

I know most implementation today use of_ functions directly but it
seems like there is a global move towards fwnodes now, and I was
wondering if using those instead (which might also apply to other types
of "nodes" than DT ones) could be possible.

But looking into existing implementations, I came across the pwm implem
which features:
- of_pwm_get()
- acpi_pwm_get()

And finally a fwnode_pwm_get() which does:

	if (is_of_node())
		of_pwm_get():
	else if (is_acpi_node())
		acpi_pwm_get();

So actually my suggestion is meaningless. I'm fine with the current
approach.

Acked-by: Miquel Raynal <miquel.raynal@bootlin.com>


>=20
> $ grep -E -r "(get|find).*_by_node" ./include/*
> ./include/drm/drm_mipi_dsi.h:struct mipi_dsi_host *of_find_mipi_dsi_host_=
by_node(struct device_node *node);
> ./include/drm/drm_mipi_dsi.h:struct mipi_dsi_device *of_find_mipi_dsi_dev=
ice_by_node(struct device_node *np);
> ./include/linux/usb/phy.h:extern struct usb_phy *devm_usb_get_phy_by_node=
(struct device *dev,
> ./include/linux/usb/phy.h:static inline struct usb_phy *devm_usb_get_phy_=
by_node(struct device *dev,
> ./include/linux/extcon.h:struct extcon_dev *extcon_find_edev_by_node(stru=
ct device_node *node);
> ./include/linux/extcon.h:static inline struct extcon_dev *extcon_find_ede=
v_by_node(struct device_node *node)
> ./include/linux/of_net.h:extern struct net_device *of_find_net_device_by_=
node(struct device_node *np);
> ./include/linux/of_net.h:static inline struct net_device *of_find_net_dev=
ice_by_node(struct device_node *np)
> ./include/linux/devfreq.h:struct devfreq *devfreq_get_devfreq_by_node(str=
uct device_node *node);
> ./include/linux/devfreq.h:static inline struct devfreq *devfreq_get_devfr=
eq_by_node(struct device_node *node)
> ./include/linux/of_platform.h:extern struct platform_device *of_find_devi=
ce_by_node(struct device_node *np);
> ./include/linux/of_platform.h:static inline struct platform_device *of_fi=
nd_device_by_node(struct device_node *np)
> ./include/linux/backlight.h:struct backlight_device *of_find_backlight_by=
_node(struct device_node *node);
> ./include/linux/backlight.h:of_find_backlight_by_node(struct device_node =
*node)
> ./include/linux/i2c.h:struct i2c_client *of_find_i2c_device_by_node(struc=
t device_node *node);
> ./include/linux/i2c.h:struct i2c_adapter *of_find_i2c_adapter_by_node(str=
uct device_node *node);
> ./include/linux/i2c.h:struct i2c_adapter *of_get_i2c_adapter_by_node(stru=
ct device_node *node);
> ./include/linux/i2c.h:static inline struct i2c_client *of_find_i2c_device=
_by_node(struct device_node *node)
> ./include/linux/i2c.h:static inline struct i2c_adapter *of_find_i2c_adapt=
er_by_node(struct device_node *node)
> ./include/linux/i2c.h:static inline struct i2c_adapter *of_get_i2c_adapte=
r_by_node(struct device_node *node)
>=20
>=20
> >> +{
> >> +	struct mtd_info *mtd =3D NULL;
> >> +	struct mtd_info *tmp;
> >> +	int err;
> >> +
> >> +	mutex_lock(&mtd_table_mutex);
> >> +
> >> +	err =3D -ENODEV;
> >> +	mtd_for_each_device(tmp) {
> >> +		if (mtd_get_of_node(tmp) =3D=3D np) {
> >> +			mtd =3D tmp;
> >> +			err =3D __get_mtd_device(mtd);
> >> +			break;
> >> +		}
> >> +	}
> >> +
> >> +	mutex_unlock(&mtd_table_mutex);
> >> +
> >> +	return err ? ERR_PTR(err) : mtd;
> >> +}
> >> +EXPORT_SYMBOL_GPL(of_get_mtd_device_by_node);
> >> +
> >>   /**
> >>    *	get_mtd_device_nm - obtain a validated handle for an MTD device by
> >>    *	device name =20
>=20


Thanks,
Miqu=C3=A8l