Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Heiko =?ISO-8859-1?Q?St=FCbner?= <heiko@sntech.de>
To:     palmer@dabbelt.com, palmer@rivosinc.com,
        linux-riscv@lists.infradead.org
Cc:     Conor.Dooley@microchip.com, linux-i2c@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        lee.jones@linaro.org, robh+dt@kernel.org,
        linux-mmc@vger.kernel.org, paul.walmsley@sifive.com,
        atulkhare@rivosinc.com, support.opensource@diasemi.com,
        andrew@lunn.ch, krzysztof.kozlowski@linaro.org,
        stwiss.opensource@diasemi.com, linux-riscv@lists.infradead.org,
        aou@eecs.berkeley.edu, ulf.hansson@linaro.org,
        krzysztof.kozlowski+dt@linaro.org, Conor.Dooley@microchip.com
Subject: Re: [PATCH v3 4/4] riscv: dts: sifive: "fix" pmic watchdog node name
Date:   Mon, 13 Jun 2022 16:05:12 +0200
Message-ID: <2247394.ElGaqSPkdT@diego>
In-Reply-To: <ee29eefa-9206-b84a-e27c-4e4388865db0@microchip.com>
References: <20220606201343.514391-1-mail@conchuod.ie> <20220606201343.514391-5-mail@conchuod.ie> <ee29eefa-9206-b84a-e27c-4e4388865db0@microchip.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

Am Montag, 13. Juni 2022, 15:33:49 CEST schrieb Conor.Dooley@microchip.com:
> 
> On 06/06/2022 21:13, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@microchip.com>
> > 
> > After converting the pmic watchdog binding to yaml, dtbs_check complains
> > that the node name doesn't match the binding. "Fix" it.
> 
> Hey Palmer,
> The three dt-binding changes were accepted - do I need to poke SiFive to
> ack the dts change or are you fine just taking it?

I don't think a node-name has relevance to vendor decisions ;-) .

Looking at bindings/watchdog/watchdog.yaml we clearly see that
the node name is always watchdog or watchdog@foo, so this change
is clearly correct.

Reviewed-by: Heiko Stuebner <heiko@sntech.de>


> Thanks,
> Conor.
> 
> > 
> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> > ---
> >   arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index c4ed9efdff03..1f386b07a832 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -90,7 +90,7 @@ rtc {
> >   			compatible = "dlg,da9063-rtc";
> >   		};
> >   
> > -		wdt {
> > +		watchdog {
> >   			compatible = "dlg,da9063-watchdog";
> >   		};
> >   
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
>