Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp692779iog; Mon, 13 Jun 2022 10:47:02 -0700 (PDT) X-Google-Smtp-Source: AGRyM1scHQ9yVnAiyyFmITsTHjhpjvDFHPZy0kaZuxqzR7KkjRmwMPc0qZULf6Gb6KlIbrgfADia X-Received: by 2002:a05:6402:3482:b0:42d:e063:7c1d with SMTP id v2-20020a056402348200b0042de0637c1dmr1069381edc.40.1655142421990; Mon, 13 Jun 2022 10:47:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655142421; cv=none; d=google.com; s=arc-20160816; b=qo+5R3qfWNaF+qcFzInIg9GA41ZZeJIpUNq+D7vLtdVn9tLrerbAVGyVWzI1NwAlNc 0MbzqToBdve6K6V3Y7m6Mst2K9U9mi/CTXYdCcEc+oxvmfl/PHXjIKvgjeY8/VrR0OO5 72zIG+kR6POD9XRddDLcO487X6AuK+8qg4JMaSTzdayMLTGto1zT3mp6K17zZxEAB9NS bboRD2XJ7j2Ujy5idTylauxVZuA+Si2GFL0Trz7RZIQ5Q2ix19en1MGjoduLmc9+0HMs 9MJ+uMYqXWjch+OErV/Mf7FXY/V+9bHzPSx8dslVSV5LW3Nj0Pzi+yJxHVR5hT2Apq6y Lqqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xozsuftUil+Yf7qgeyan1GVByIk69FPZz9iCThVKzz0=; b=MM+ew5MytbSgPxqdLG4nI1dqkGUDACuaCJvwHf3okQie8CvW2x8f+VUqjRL3bCfMSy 4qgGTTNsyT2fiK1byc7dXqCaIEKqzxpO0vdAyu10p8ccpkgkUmR4XqVRWsYtFYQSN+QR 1wsGhwkpERlnABolp3rdAB/c9yKVeJ1k7+gZxGhBTZSsfa4JOFOJxy5aXVGS8zJqmh6L 6mw7YUCdCfEtCelALahytDuT2GDSPmtJPzkmxDPbKQ3emg8khcIwQCps4C11mYLPQe7i CnfJ09GTfCY/tlrNk15QkdgPFiiQqK8onD6GJ9a8hUN1dnef83oIuMeqVAf5Br8Wqzac mP/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hFGeokSD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h17-20020a056402281100b0043087bb08a3si10212865ede.317.2022.06.13.10.46.37; Mon, 13 Jun 2022 10:47:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hFGeokSD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242480AbiFMRmG (ORCPT + 99 others); Mon, 13 Jun 2022 13:42:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243059AbiFMRiz (ORCPT ); Mon, 13 Jun 2022 13:38:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02B6814AF4C; Mon, 13 Jun 2022 06:06:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7CDB060C4A; Mon, 13 Jun 2022 13:06:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E803C3411B; Mon, 13 Jun 2022 13:06:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655125588; bh=wtPCz3OyedMcP/w7PQBeu2r2iV5lXm28OqwqVJ/Rk/o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hFGeokSDqmiWwRfrmobGSxacikejyYxTAfhHQo8kmW24MQ9fFA/W894Cx26yugOgO g02ZA5AZx6TMxyyqPSu4JDXijzAEnZ2Lv1vTZYqNu4YAlf4BVzrCxAhlSDxs9oKG/s DgcHVQ4WEjIpg/eClDj69JxNWIcEKUb35d01G0Eg6gmLLeK0iO315uKAfTzb+SKDL+ carh9pH+5wXp6azNMwzXVWVhnGWvtfzVj1YJG+/STkDuU2zBjLDDvyqeybssx8Hw4n wZ91Cbh6E+o65sO/vmIp60Chf/sGg6gSqA62ZrkrvxgeWmy5MogMqosV76TjI+I2mx vEnpNrw5btqLg== Date: Mon, 13 Jun 2022 14:06:22 +0100 From: Mark Brown To: Jerome NEANNE Cc: lgirdwood@gmail.com, robh+dt@kernel.org, nm@ti.com, kristo@kernel.org, will@kernel.org, lee.jones@linaro.org, khilman@baylibre.com, narmstrong@baylibre.com, msp@baylibre.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC PATCH 5/5] arm64: dts: ti: Add TI TPS65219 PMIC support for AM642 SK board. Message-ID: References: <20220613090604.9975-1-jneanne@baylibre.com> <20220613090604.9975-6-jneanne@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zZx7sPWxeWiq9OR6" Content-Disposition: inline In-Reply-To: <20220613090604.9975-6-jneanne@baylibre.com> X-Cookie: innovate, v.: X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zZx7sPWxeWiq9OR6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jun 13, 2022 at 11:06:04AM +0200, Jerome NEANNE wrote: > + buck2_reg: buck2 { > + regulator-name = "VCC1V8"; > + regulator-min-microvolt = <1700000>; > + regulator-max-microvolt = <1800000>; > + regulator-boot-on; > + regulator-always-on; > + }; The supply labelled 1V8 can vary between 1.7V and 1.8V? That at least deserves a comment. You should only set boot-on for supplies where it is not possible to read the current state. --zZx7sPWxeWiq9OR6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKnNk4ACgkQJNaLcl1U h9A8AAf+L8/jIRuPSPB7WEwuvEuJ13zFfAdSdkMFCAWLTK6QyiPEMnzqfLIRjv/1 hDvwENyNnso8OH0+ftQsyFZvzUtyzyjwptKfuc8zjf9q0fd6ljrljacZ9NB97m2M qztrTCanjB5npgomVdS3LW8kvgs1C5v3a7P15btIo+k8coGasstcwsJNi3pe5I1P gESkfUjNRiEQOMhOGvn6j6YB5xEAzkTx2/ZowtjlCECwm2bgM627HoGI1C/SKRN6 /rGqtD3KvtdhnCxV9PinczxJeVVc2P77IUQ+3q+8ikpb3pkz+k+PXAJ5pPT2WED7 9TMqmOv6LyxOdaizBKUQzWLRYm6hmg== =TolR -----END PGP SIGNATURE----- --zZx7sPWxeWiq9OR6--