Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 13 Jun 2022 17:30:24 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Nam Cao <namcaov@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev, phil@philpotter.co.uk
Subject: Re: [PATCH v2 1/2] staging: r8188eu: replace LE_BITS_TO_1BYTE with
 clearer codes
Message-ID: <20220613143024.GE2146@kadam>
References: <cover.1655019752.git.namcaov@gmail.com>
 <4cdacd703158029c0b0f706e3cf1eb8daf4121c0.1655019752.git.namcaov@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4cdacd703158029c0b0f706e3cf1eb8daf4121c0.1655019752.git.namcaov@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IDYxz5cfHMG04gR5i23OyNe4iPOqxr5JUAbk6l2U9WphMdiR3woJo+9gKUZn?=
 =?us-ascii?Q?GEohN8i0JaIHMhfYwnrF1QpT12RNnAsO9SxQqcwy7q1otaAhALQcXCgGiHsF?=
 =?us-ascii?Q?shrLtn3v3aY6Z9Vt18YfjegG5p4F4AKE76MyNpalG6hb7Aen1EPJHZ2eIy81?=
 =?us-ascii?Q?HM3TevySwCRPJAxYi5HmNqxHVDVNyaZiGYNhClBu+4J04yKSMEnYKMcgg6Rr?=
 =?us-ascii?Q?IUyuLOdCYnnJWih4eKKyPwHdm7FoIzX36+6gXbc6UYkXgz2KiLd9KpPgJVmQ?=
 =?us-ascii?Q?fGL48dqmQhjfoBjUmgKpEsPFtsxXWbmIMm6hqzSHgeJCN+pMt99VZjPimFv/?=
 =?us-ascii?Q?ZJ+chxdqKaEkZtuaeD0o8bwI2AABUMdPgFyYvODCQL+gpKH5yI+ileMLDGFS?=
 =?us-ascii?Q?dQ+xsq42exuS4gSfpJSZl+um05x47yQMVM1cy+2AXJbd1qe2aVtesDDnUz7s?=
 =?us-ascii?Q?l3U24eMgI4a9xs+VVyfRK78abpVFxIbr/z2JyilK8zmFQdrnV429JnTTrsar?=
 =?us-ascii?Q?ruc8WTEROc0DXjZjYg+IhhfiOhGdFRZXIjIVzxhE6vRMF+wLiewthEcfZ09t?=
 =?us-ascii?Q?RCTyoH8X6GzrciKbAF1OolqNsXDvC0gD13LdGfpuxItLeU791HT/3C7rXCLZ?=
 =?us-ascii?Q?ulJZKTjWnp9/95BeeIZCB4ba/Fd2tC1BxBRHE/VngE+B0u10LQ2XZryhnowh?=
 =?us-ascii?Q?fm1slS8sBwwWe7wqpAHMH44fXVWQIyOkFY7LXgi9cxmMeC0uTJom8JDdbx7B?=
 =?us-ascii?Q?122osTiDLZHFfBBVzPAHKyKT82y8JiIcENyl7/kKbOV5l8KWdP1YmDQZM8JF?=
 =?us-ascii?Q?Q0r0efQE52c+Uv13Q/1Y2Qd+5SJbSn79QGbwp7aCeC6D5C6mOzGFqq847BFN?=
 =?us-ascii?Q?VLXj6pTiB9Fu+Kh+PWqtVALCWHFAaLBEQSuAzx49M9ObWis6VMFqc5bfrpeJ?=
 =?us-ascii?Q?wEHtPMEX6FRr3WYzbmveNK494Fsom0el3r1+GaOuJR6mtrkG6S+8m/qcSlhv?=
 =?us-ascii?Q?sWxrBae4vVm62aFpVNey0IORCm7Ke+p8grdAgFm/5l+Fw26/un4bHHEbzdka?=
 =?us-ascii?Q?QJxoubYuVJoXDV3DbuJhw8Yr4eUA00j/RmWZJv/Vt/XLuPCxqICornL9uyvy?=
 =?us-ascii?Q?01Gl8BGhaY7dEloAapzgSOYIQE5g17Jy4akhSFaPiBP5CaikvFGVrMqTzv/U?=
 =?us-ascii?Q?jOweV06O802gLw/s72d922TVSyzyGszkSXtJZ+iNpnf9bY8iReaDjA+n8jvn?=
 =?us-ascii?Q?kYFK8RVRHRv+hOYz+IBPwFk8tyFzNbf4vBRWhMR1Y6gi3KgAsmGNxlQSyCX0?=
 =?us-ascii?Q?47DeZClNEmrgHSqc392wk5CSp4FpM5uQRUdQDL/H081Gup7RcrI3XgiwAfdA?=
 =?us-ascii?Q?wXArxh3PdhJVJyp8ghvCcI0Z4ysHjn1JdrXgehDPO3vT8be19nOy3SOm9+gw?=
 =?us-ascii?Q?mg4+3y9PG5Sy1K8xh0oKxWmYiyGVM3Q9iPPSFlDpno016KzJ0sjx67GbSIcE?=
 =?us-ascii?Q?OYG/hRNVNHYKzg8y1ucYePofbP+t+IFVVrJ8B5xtNhYo+SyMx+K0eNCQaQqQ?=
 =?us-ascii?Q?vNEsGSl0UZb/oek+XOxGbc4ARM8J6houOoN4IqtVOqQgmr2x6CaTTttmN62K?=
 =?us-ascii?Q?U5MNBVH5UZ5JiIB5jmQgk/qGwHjgKfeXd+POv1/21b62r1KkZQfW15mLSf7y?=
 =?us-ascii?Q?ZHLsqTc0IgiBqwPnI1oRfiSm4vNa7YRGfkpnZh91wWFVO2nhJkNH6uCK/SLE?=
 =?us-ascii?Q?wb/BhyhHsjQy2icPoWHywxlpDOUJP/Y=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 46ada9cd-6dc0-4030-7c48-08da4d49486e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 14:30:37.4029
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GpdP5g7+GFB3hib7hmHYDFW0pX7VUirawKhtJJl5IKG1wOOkTh2An9EXZbgCP37eoKQRQq5T6lxJxvU5WP+XomGcGvy7xPMhyjsaPS4wM4s=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5794
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-13_06:2022-06-13,2022-06-13 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 suspectscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206130065
X-Proofpoint-GUID: bSudBfHd1Hz2yZ7Jgdwwoaq6R7QJrcPd
X-Proofpoint-ORIG-GUID: bSudBfHd1Hz2yZ7Jgdwwoaq6R7QJrcPd
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Jun 12, 2022 at 10:11:43AM +0200, Nam Cao wrote:
> The statement LE_BITS_TO_1BYTE(__paddr + n, 0, 8) is not obvious on
> what it is doing, while in truth it is simply reading one byte.
> Replace these with clearer codes.
> 
> Signed-off-by: Nam Cao <namcaov@gmail.com>
> ---
>  drivers/staging/r8188eu/include/Hal8188ERateAdaptive.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/include/Hal8188ERateAdaptive.h b/drivers/staging/r8188eu/include/Hal8188ERateAdaptive.h
> index 20d73ca781e8..79e4210c6b65 100644
> --- a/drivers/staging/r8188eu/include/Hal8188ERateAdaptive.h
> +++ b/drivers/staging/r8188eu/include/Hal8188ERateAdaptive.h
> @@ -26,15 +26,15 @@
>  #define GET_TX_REPORT_TYPE1_RERTY_0(__paddr)			\
>  	le16_get_bits(*(__le16 *)__paddr, GENMASK(15, 0))
>  #define GET_TX_REPORT_TYPE1_RERTY_1(__paddr)			\
> -	LE_BITS_TO_1BYTE(__paddr + 2, 0, 8)
> +	((u8 *)__paddr)[2]

Instead of doing this, I would prefer to just get rid of
GET_TX_REPORT_TYPE1_RERTY_[1234].

regards,
dan carpenter