Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <390b38f7-462a-bfad-5e46-21b4e72f8a39@oracle.com>
Date:   Mon, 13 Jun 2022 10:11:17 -0500
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PATCH -next] scsi: target: iscsi: Fix NULL pointer dereference
 in iscsi_conn_auth_required()
Content-Language: en-US
To:     Yang Li <yang.lee@linux.alibaba.com>, martin.petersen@oracle.com,
        Dmitry Bogdanov <d.bogdanov@yadro.com>
Cc:     linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20220613014321.107045-1-yang.lee@linux.alibaba.com>
From:   michael.christie@oracle.com
In-Reply-To: <20220613014321.107045-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHAzQnFSYkVSaTZ6STJzR1A2T3c5d0hiMFBRYXZRS20rZzl1OVN5SGRCaWc4?=
 =?utf-8?B?Z1RiamVrZXVCTEhQbWVaemttL2VLMzZFZWk3V0xFekNmaXZ1M1ZFemVtR0hS?=
 =?utf-8?B?Nzh3MWJocE1WejM4aVZybEdYQXZTbDhxSGFucHJJQm0rclZuRlRwNmpCTFox?=
 =?utf-8?B?Q3hOb1pPOUZMd0oxS2hnSXdMSjArMDlsOW1QaHdxN0gzSmlzTWhiRHk0WFV5?=
 =?utf-8?B?dDVaRE15T2ZycEFNUVcvNmRETXdiVXhnRG5DSWNXdnlhVzRuMjFJVzVLcEN3?=
 =?utf-8?B?Sm5WenljdVFDOVhFUEgyS1RCZlNaalJrSnFtaklzSE1OT3p0aVk1Q1AvZktx?=
 =?utf-8?B?aWM1RythVW9yS1hYSkJhRDhOZTRmR3Y0K29oMmE2UHZnZFYrbnlwTjkzRUdv?=
 =?utf-8?B?S1g5dWNZcDFqK0VCbTZGRHlYRldHc1FLYnhBcnI0KythOFlURnVXazY2QzF6?=
 =?utf-8?B?VldjMDQxUElNSWQvTFhtdC9QZ1dwdis5TU56VG1Qd2hjSW5lZWxxZUY1Nzlh?=
 =?utf-8?B?UEdvU1lZdU53MDFId0pBL0U1K0Y1dEllWTRHb1oyc1YwMmR2a2tqYVZvVVhs?=
 =?utf-8?B?MEFFd2x6M0xSR1p0ZGZ4bjlmbjI2Zm1vT05WRldOdFdCekhjNEIxK0FEM3Q0?=
 =?utf-8?B?NU4zZGtxZGQ0b1YvTnFHa0c0eWhvYXROUGpEckZ0U1BOZkJ6bFJ2a0Y3SHZ0?=
 =?utf-8?B?NEJ1UmNSTEtyZGQvQi9RZDFuVmtrcFI2Qlp2NVRZbFpjbVovSXpNdmFjUXgw?=
 =?utf-8?B?Yk44bktJVmk1UldPaUVadXF5MUV3UVNNQ0dOMFJRdTNFbTQ1NkhuaHFOMVZw?=
 =?utf-8?B?RWtDakphWmVidzBJaFBjRXlBQXFFbjR1aC9GbHlZZ1kwSVhucjhIZWZsZjhs?=
 =?utf-8?B?b2FRNk5JcXRqWCtFbWhscDBxZTJVb0p1Vk1yR3l2TkxjRFRHSlpVaWowcHR0?=
 =?utf-8?B?WlhDTXcyS21pOFFidUdybGtpeVpTVm5aVXlUZ2RXaENveGpOMWVRVmNVMWN0?=
 =?utf-8?B?ODExMWZMeXRSYW1tOSswdHlMbXY5YndOU2ZDdzd6YnZnanJBWi9Gd2tJRm9o?=
 =?utf-8?B?d2JFSzVNUnJjc1JoWTFYRDJCMVBKRUJTaUx4WmRvMkRnUm5neDJ6YzBCaGZL?=
 =?utf-8?B?TzNRQmlHZ2dxT1pmZDNyd0ZlYUlrWUlzTytncmdXa1dRTzBrekpuWW9udFdU?=
 =?utf-8?B?QjVqSGgrY0xVaUZPanRjcmJ1Z0c2dy9mRjQyRXg2b0xwNmxveFRoQUxFYnBI?=
 =?utf-8?B?WlhKd2xuZU9sRXRlZ2NSSkZJVVU5aHVaNWxnT2p4MFJYZkFFNEhSR3B6RGVh?=
 =?utf-8?B?UmtFRUZLWnZLc2VEbzVKZmVNTkg5S1hwM09obEcraC9FRXhoeW90RmxQbDln?=
 =?utf-8?B?dEQzS3BCMXhjajRGcFc0aE1Zdktmck1acFgydUxDY3hLWTBRSVZnakFpNm5N?=
 =?utf-8?B?YzNPVlYzczJDZWNHRHdnNTF6Z2lQanYvanoxSUZTd0RBZCtNV2xXUGMzV3c5?=
 =?utf-8?B?Q3gyNGkwZFNCVG5YQ1NnWmRPRHZjWnprY3I4dkZwYUdBaDlKR0FndXNBZndw?=
 =?utf-8?B?WGIrcjF4Y3puL1hTODRCK1JLSnh0bExScUFITm11RytZODhXMDdnbDdSL3p2?=
 =?utf-8?B?bTA3WWhVTFR5UjdiZlZaaWNjVlMxVWZreXFqcVJXaTUvT1JDcDJFOUF1NVZz?=
 =?utf-8?B?STBKOGJZU216dDlVa2xabUxOcEs3ZURiNmRXdUVQTFRvemtmRTdLL1FZRmlP?=
 =?utf-8?B?aWsvR2hSWHBtN2NCODhIbXNlWEJJWHBDZ2hEVEJpUVlLZUxQVTJLWVFFUzVT?=
 =?utf-8?B?UjlRaHVhckt2dnBDbVhzK1p0VysrWkhaVUlQNTFFWnd6OUlBQ1hsMHNwYTdy?=
 =?utf-8?B?Tno3c3NUdkRPa2VsbmorUk51MjF4Z2ZlK25iV1pBWVpmaVpZb0JoVDM3KzZE?=
 =?utf-8?B?N08yVHY1Ui9NNFZlUnFZbUxnd0lDVzNyZ2dKR1BSalhxdC9SMW52VHFFTmJm?=
 =?utf-8?B?Wm0yelZnbXJVZGlXN0JkNWFjSFlMUFAzKzVLNWlmZlFIOEVEVXp2SGRvWDln?=
 =?utf-8?B?cDhHUGRyV2tDTVB3WFdkdEFxZStEUDY2ZWJvOWYzZjZscXlsV3JtcUxUVHhw?=
 =?utf-8?B?d2RGYkthZHhiWkVBcnNFY3pqQ0g1dDZHVXhQZXJFZXU4RWh0NUxsY3hhYjlD?=
 =?utf-8?B?SUVxdGlyeW1nZyt4cWVKN04yaEd5MFlmeUFJemI2UlNrU0VVMWxnK251eDJB?=
 =?utf-8?B?bEFkY2Zkc3Q3ZGJJcVRzV01PbVEvWCtzckJOWWUxM2Rqay9HMm1xZWtmWUsy?=
 =?utf-8?B?WU43VHV2eGtjRjF3YVhvNW92Y3dyeXBmemhPMU90STkxQmlsajh2NmJ2VGYz?=
 =?utf-8?Q?oEj6LUCG9ihmhib4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0855a896-fd3c-4f58-e09c-08da4d4ef8ac
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 15:11:20.2619
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PiWjusdd/i/tanyswqNMdwZUkEnSFKu30K9x7vAlo46f/ZXB7EbnaaSJbKoJHLL+BMwp7auvY3I0KfPPHIuO79pfMy50gNMzmjdU1Oda284=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1001MB2293
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-13_06:2022-06-13,2022-06-13 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 spamscore=0
 mlxlogscore=999 mlxscore=0 bulkscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206130068
X-Proofpoint-GUID: MTu0k6tcsZzTkOKKr-65RSWk7cIpWZpd
X-Proofpoint-ORIG-GUID: MTu0k6tcsZzTkOKKr-65RSWk7cIpWZpd
X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TRACKER_ID,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/12/22 8:43 PM, Yang Li wrote:
> Fix following coccicheck error:
> ./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR: se_nacl is
> NULL but dereferenced.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

This was just added in Martin's 5.20 tree in:

a75fcb0912a549c6c1da8395f33271ce06e84acd

scsi: target: iscsi: Extract auth functions

Do we need a Fixes or should the original patch be fixed?

Patch looks ok to me, so if we just add it:

Reviewed-by: Mike Christie <michael.christie@oracle.com>

> ---
>  drivers/target/iscsi/iscsi_target_nego.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
> index 9ce35a59962b..fb93a1173954 100644
> --- a/drivers/target/iscsi/iscsi_target_nego.c
> +++ b/drivers/target/iscsi/iscsi_target_nego.c
> @@ -827,8 +827,7 @@ static bool iscsi_conn_auth_required(struct iscsit_conn *conn)
>  	 */
>  	se_nacl = conn->sess->se_sess->se_node_acl;
>  	if (!se_nacl) {
> -		pr_debug("Unknown ACL %s is trying to connect\n",
> -			 se_nacl->initiatorname);
> +		pr_debug("Unknown ACL is trying to connect\n");
>  		return true;
>  	}
>