Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 13 Jun 2022 16:50:36 +0200
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Serge Semin <Sergey.Semin@baikalelectronics.ru>
Cc:     Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Jan Dabros <jsd@semihalf.com>,
        Phil Edworthy <phil.edworthy@renesas.com>,
        Gareth Williams <gareth.williams.jx@renesas.com>,
        Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
        Serge Semin <fancer.lancer@gmail.com>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: Use standard optional ref clock
 implementation
Message-ID: <YqdOvDmixVlDYzjO@shikoro>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Jan Dabros <jsd@semihalf.com>,
        Phil Edworthy <phil.edworthy@renesas.com>,
        Gareth Williams <gareth.williams.jx@renesas.com>,
        Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>,
        Serge Semin <fancer.lancer@gmail.com>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220610074233.9748-1-Sergey.Semin@baikalelectronics.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="LpjOMnM5Qxa/KRrW"
Content-Disposition: inline
In-Reply-To: <20220610074233.9748-1-Sergey.Semin@baikalelectronics.ru>
Precedence: bulk


--LpjOMnM5Qxa/KRrW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 10, 2022 at 10:42:33AM +0300, Serge Semin wrote:
> Even though the DW I2C controller reference clock source is requested by
> the method devm_clk_get() with non-optional clock requirement the way the
> clock handler is used afterwards has a pure optional clock semantic
> (though in some circumstances we can get a warning about the clock missing
> printed in the system console). There is no point in reimplementing that
> functionality seeing the kernel clock framework already supports the
> optional interface from scratch. Thus let's convert the platform driver to
> using it.
>=20
> Note by providing this commit we get to fix two problems. The first one
> was introduced in commit c62ebb3d5f0d ("i2c: designware: Add support for
> an interface clock"). It causes not having the interface clock (pclk)
> enabled/disabled in case if the reference clock isn't provided. The second
> problem was first introduced in commit b33af11de236 ("i2c: designware: Do
> not require clock when SSCN and FFCN are provided"). Since that
> modification the deferred probe procedure has been unsupported in case if
> the interface clock isn't ready.
>=20
> Fixes: c62ebb3d5f0d ("i2c: designware: Add support for an interface clock=
")
> Fixes: b33af11de236 ("i2c: designware: Do not require clock when SSCN and=
 FFCN are provided")
> Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>

Applied to for-current, thanks!


--LpjOMnM5Qxa/KRrW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmKnTrwACgkQFA3kzBSg
KbahQg//bJVwpD7dUJbwrkCJR/R4p9wzcrnlm3kpsprd/tRq8WSb87PkDFRIP9oN
13zkFyCOfsYb0OCY8+QwprKEV8BJN9irSQHOukm2bN5ShkZpY2CBxfiScDe757F8
Nla7I6ez3EBQeKYV1QF0GW1K1Es5+1nqcU+9DKRA/uYzVQmkJ9bMr4mGTotMJzIS
ey5b7JkDMzIxp/4BLXxdOz0To00WtTVqb/1vSiK7NwCw5ovTdbXlt4o8cL9+G2s7
NmwQaqvOSlyvEny7+nRDitZZKB+zXF8BPSPWCRUJBmToU1jfzWJzfUJMWnkkpXGX
BhDXmAsUrVT/JyfzqGAywxywpphrOqbU9IpXS+8I1LU6qCMN9rizfyjbyGcLnldN
x9HoVQe7vEOUTcEoEQiDbauO6uxnWrHRNFo8ud7KgDECRwJ0ta04vH2UOKCchw7c
yXxCSob3hP8ew+fg5hwlFUhHRQvuRTnm30WaxE/iIxzTyOSCKtLCnAOmOZg0f9zk
ZpA/pRDVaVXRTKuesjwU5SKDOm8JFP3wi8IHX/iMMxlJXek3w89NprAdj2SqWdA6
cI93dQ7Nn/39KyNU+GNp+n+wTzPIRB+cwKFbQ7r8tgMlxmRCZYOGRv4L0q+VDWWG
nzT6jbHlb622SOIfdm45ZWSVrDh5ZjRMqjeBzjGzFcIMSKEwe+w=
=unAQ
-----END PGP SIGNATURE-----

--LpjOMnM5Qxa/KRrW--