Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp755104iog; Mon, 13 Jun 2022 12:13:01 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vcgXwxnRigXRIwGV6N8ii6Q4MzM2u8vyFlMIYlCzF7Yq0Jyn/3IMsdTO4AyRonsqD2S/Po X-Received: by 2002:a17:90a:df14:b0:1e3:33ba:a94 with SMTP id gp20-20020a17090adf1400b001e333ba0a94mr211255pjb.83.1655147581201; Mon, 13 Jun 2022 12:13:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655147581; cv=none; d=google.com; s=arc-20160816; b=paoUZbDwtWdOQuXe/X9Dl5tQDwzc2qQTOilUqNcyiWPcZLMHU+KW8MWw2q7mj5Bias EmauMwc5bAvaPQN7YMX6RStAl8EQIQxHqDGBeg2AojdPO9qXlS0LzRzjqFLzjVs4bROn kAEegWXx02o1pHaW3bNZBMjYHlzii+xvibdgKrymoN++jgC0yw/064PNKL0e4WcVDcJH M7IC5WgiNROLM1iF7+dTjsnY+Z2bP/T8QFgHl2nhSkkEvlhx67H26ij+mFuSVD847Zts 8ZH4pAvZg3IeZji0hY6O6EWRVffLuTNioEF/dAXJn30NR61exJ4LBLM8B8RJ2Toy3QQW ZHtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:accept-language:in-reply-to:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=oUAre9YjXjGRNHQIOS8iUQV/hhzkZO9SXZnML1+fx8Y=; b=jwx6zxB5VzkNxj/v+asYGOlBqie/fjB8cE3vSBivgMUPT8k4t4XoSNT+9CQXC4GPt4 7iCs4XLztBid0Ndvbsvqptvj3gKR/wAFZE2jXC/CiymbnLtYTWVDHfkSMj6imQUT+DXU DoNEgj/yB1qsQoIfXUc2mWyGHzfXUQua3Ywiqe2TwjPYEE/JXhCGC7elyQm2aR6VRYcK 0uwDoW5Tsd8p9vcTbZ1jUGIjX3DaLFkYEuHZBFMukUGbTrNNGomLKpbhoe1ltSmR4Jjc gcGLrRijYeDm8k7V8obS2np4oFsS61Abuc8LZioionUlLSWJ7IG5zJd4OgxFOJZnzzky +mFQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r36-20020a634424000000b0040884ab88f2si2951968pga.635.2022.06.13.12.12.49; Mon, 13 Jun 2022 12:13:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245468AbiFMSj0 convert rfc822-to-8bit (ORCPT + 99 others); Mon, 13 Jun 2022 14:39:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345144AbiFMSir (ORCPT ); Mon, 13 Jun 2022 14:38:47 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 255E835DE8 for ; Mon, 13 Jun 2022 08:31:56 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-156-O7Q4oYRGM8G5ydqL0wX4hQ-1; Mon, 13 Jun 2022 16:31:54 +0100 X-MC-Unique: O7Q4oYRGM8G5ydqL0wX4hQ-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.36; Mon, 13 Jun 2022 16:31:52 +0100 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.036; Mon, 13 Jun 2022 16:31:52 +0100 From: David Laight To: 'Joe Damato' CC: Alexander Viro , "linux-kernel@vger.kernel.org" Subject: RE: [RFC,iov_iter v2 3/8] iov_iter: add copyin_iovec helper Thread-Topic: [RFC,iov_iter v2 3/8] iov_iter: add copyin_iovec helper Thread-Index: AQHYfjsvbNyOWJFJ/E+wgYg8ABCKpa1M98IwgABis4CAABxiIA== Date: Mon, 13 Jun 2022 15:31:51 +0000 Message-ID: <8f65149b1d9a4a7f97f18df05a41f728@AcuMS.aculab.com> References: <1655024280-23827-1-git-send-email-jdamato@fastly.com> <1655024280-23827-4-git-send-email-jdamato@fastly.com> <8f6771a01fe74cde86641e780d31a2ce@AcuMS.aculab.com> <20220613144244.GA77534@fastly.com> In-Reply-To: <20220613144244.GA77534@fastly.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Joe Damato > Sent: 13 June 2022 15:43 ... > > The additional costs of all the 'iovec' types is bad enough > > already. > > Do you have data you can share on this? I was thinking of the performance drop noticed when (IIRC) reads/writes of /dev/null were pushed through the iovec code. But there is a lot of overhead code for the usual case of a single user buffer being copied. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)