Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <88718d10-4435-f5a8-9123-afc73257e0ca@schaufler-ca.com>
Date:   Mon, 13 Jun 2022 07:53:36 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] smackfs: check for allocation failure of kmalloc()
Content-Language: en-US
To:     Li Qiong <liqiong@nfschina.com>, James Morris <jmorris@namei.org>,
        "Serge E . Hallyn" <serge@hallyn.com>
Cc:     linux-security-module@vger.kernel.org,
        linux-kernel@vger.kernel.org, yuzhe@nfschina.com,
        renyu@nfschina.com, Casey Schaufler <casey@schaufler-ca.com>
References: <20220613062202.29194-1-liqiong@nfschina.com>
From:   Casey Schaufler <casey@schaufler-ca.com>
In-Reply-To: <20220613062202.29194-1-liqiong@nfschina.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/12/2022 11:22 PM, Li Qiong wrote:
> As the possible failure of the kmalloc(), it should be better
> to check it and print a warning message.

The allocation is done with __GFP_NOFAIL, which assures
it will not fail.

>
> Signed-off-by: Li Qiong <liqiong@nfschina.com>
> ---
>   security/smack/smackfs.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
> index 4b58526450d4..0d11ba3cb4cd 100644
> --- a/security/smack/smackfs.c
> +++ b/security/smack/smackfs.c
> @@ -695,6 +695,11 @@ static void smk_cipso_doi(void)
>   		       __func__, __LINE__, rc);
>   
>   	doip = kmalloc(sizeof(struct cipso_v4_doi), GFP_KERNEL | __GFP_NOFAIL);
> +	if (unlikely(!doip)) {
> +		printk(KERN_WARNING "%s:%d failed to allocate a memory for doip\n",
> +		       __func__, __LINE__);
> +		return;
> +	}
>   	doip->map.std = NULL;
>   	doip->doi = smk_cipso_doi_value;
>   	doip->type = CIPSO_V4_MAP_PASS;