Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp794661iog; Mon, 13 Jun 2022 13:09:19 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vnOtfPzaYvz8ce5oYpRZU1LbFCiv7jFU6oTFgwmhQWabd1H/n6qJCUlPgovzZbHDgAgD4r X-Received: by 2002:a17:90b:388b:b0:1e8:7347:c3cd with SMTP id mu11-20020a17090b388b00b001e87347c3cdmr438380pjb.135.1655150959251; Mon, 13 Jun 2022 13:09:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655150959; cv=none; d=google.com; s=arc-20160816; b=mzPFMh9ARDqglAuEDwHEnIasN1e9DmUq1WT/VmuL5yykH78ItLjfrpLw5E/Q+uZ1mw YfeCfwX8bHh8GJ+uY+QeMC5zm06iT/F3Z2UCABGdIXENStMVNvC9B3/M+7A1DJku1tpH tbF/BQbl311/Hj9ZC2EWRNfLiaM+/qFtPS0Xuiipo7HXK2dwNvhBK+Q7TFqTvavjSsl3 uU3cA+5LLMOv/qtRfRu2yGFHodp7B4qZnhwNOmUozPZn3zTe7Pfa1uTyj5+FX01NZTC3 fugt3hlzvAykvDqNoyrarEElS/VIWj9LOzzIP2+zJD7a+zYxWH4xnm1BQ3O9wRASU3QW 95ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=A+X+RmXiTTqgUhAEei5X53cu+nGtBENiIdfSY//g3u4=; b=k7nUyrwROGWMDqoa67xaUIHM4Hxrx8zEw9QSVihor19WL59c6bB1ricYqLJaceDwd0 C0xf4a9Q4VaTBWc1HBSv9EgDDx+zKRZ1EZt+PMUZObSmefdArsDJXWDV48VlOAH67af2 Dg0QjEFuJJl5ay08B6UJo0Me6LoDwvyDqWJn/aXK92kqCWzx8QBaFdTcP7OxsIPBMYt1 3+xmm9JlGSz0wXrFvd+pKCHxIAzS8VqLlneR90zUR2vz1DsumMYqk99SwRk6eh6uoW6y oifm9/PY7OvZpb1RvT2FAaygMB02p35wvq+nwGjd3828fJ76Y7V7KR5vlE9acE6HUD4Q S8/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=rZCKCG4s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r10-20020a170902be0a00b0015848a89d82si10057044pls.107.2022.06.13.13.09.07; Mon, 13 Jun 2022 13:09:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=rZCKCG4s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240955AbiFMTg0 (ORCPT + 99 others); Mon, 13 Jun 2022 15:36:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245565AbiFMTgJ (ORCPT ); Mon, 13 Jun 2022 15:36:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F46F1117F for ; Mon, 13 Jun 2022 11:03:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E182361192 for ; Mon, 13 Jun 2022 18:03:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DAED1C341C4; Mon, 13 Jun 2022 18:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1655143380; bh=0nCqIev+TzjLtB3pTABL/JjV/UBryXSplYSxvst+YE8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rZCKCG4sw4Ei+r/spci/prFohB6UEYP7KI5MWc74R38RiyoM4H4yoBFILn+OqcdQX vcMCsDtXFFbWBMiWAAUy/Xr+wBXLR8hYKYoXMO/CBfATOBhhP7KNZtJP8FzKC6zChb PNQzdTT86h4/Yr767PMYDk0rHr+aAFeogOC/23Dc= Date: Mon, 13 Jun 2022 11:02:59 -0700 From: Andrew Morton To: Miaohe Lin Cc: , , , , , , , , , , Subject: Re: [PATCH 1/7] mm/khugepaged: remove unneeded shmem_huge_enabled() check Message-Id: <20220613110259.80507ec6a6472342a951dad4@linux-foundation.org> In-Reply-To: References: <20220611084731.55155-1-linmiaohe@huawei.com> <20220611084731.55155-2-linmiaohe@huawei.com> <20220611133336.b582edd4c2c2df15f5561d2b@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Jun 2022 09:48:27 +0800 Miaohe Lin wrote: > > I updated this to > > > > If we reach here, hugepage_vma_check() has already made sure that hugepage > > is enabled for shmem, via its call to hugepage_vma_check(). Remove this > > duplicated check. > > Do you mean "khugepaged_scan_mm_slot() has already made sure that hugepage is > enabled for shmem, via its call to hugepage_vma_check()"? yup, thanks.