Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 13 Jun 2022 14:43:45 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Muchun Song <songmuchun@bytedance.com>
Cc:     david@redhat.com, akpm@linux-foundation.org, corbet@lwn.net,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org
Subject: Re: [PATCH 5/6] mm: hugetlb_vmemmap: replace early_param() with
 core_param()
Message-ID: <YqevkanSFly3Y0Y+@monkey>
References: <20220613063512.17540-1-songmuchun@bytedance.com>
 <20220613063512.17540-6-songmuchun@bytedance.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220613063512.17540-6-songmuchun@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzFFekZOVS9XVGwrY3hSQjlKMS9mM256RkowZzE4b0pRTmJLOXRqYTJmdnlm?=
 =?utf-8?B?NnVGWHRuUXluMlRiczhiZjMybmd1b0RGYTFRUEVsWDhFcHpGL3VhRFdVckFa?=
 =?utf-8?B?VTQvbFdLZExxck9xM2phVE1ITXdXQnBmb01jUElLbmdVV2ZlL2dmSmRTWXBO?=
 =?utf-8?B?eXdjbkhSWlBMNEZ4V0RnTXR0a2FJQVJ1WVBtZWZxMVVIVUJrZlVQb3dEYy9O?=
 =?utf-8?B?VlU2a2J1N0Z4Q1hOZU9XWmlmM1hiak56SHFCTEdhRWxUZ2hVTGZYNFZsR3R5?=
 =?utf-8?B?VWxUVU50S1RkUDI2b0s1djA4bUI5NFVCc0VHVU9ONzdEMGtBbVNjUE5tYmNr?=
 =?utf-8?B?Z2JMeUlmZ2FVZW5DaVFOUU90dTR1eUtFaW1iWjlBbjA4NWsxSXMrSFBWcHhS?=
 =?utf-8?B?OEhsKytqTGR2cHZLdjFlSXRmNXBVbGxjYkt4ZlA5ZDB6SHhiWDJaTWpXL1NP?=
 =?utf-8?B?Nm1ha2VQL0hWV1AzMXFwbFFFWHdjL0gwVFQ5dWhMOEZISzVIcFMwN0o2WGxW?=
 =?utf-8?B?Sy93R2l0eTdmckhXRXM2R1dkVFIrRm4zS2N5Q2FwV1B2eW9CUzY3RFg2OFVE?=
 =?utf-8?B?M0d0QTdJZ0FHZm5ZRWp2UGt4elpzUi9rcjJnQlFTTEJycXhvMCtVVWN1a2c4?=
 =?utf-8?B?U01tQ0QwSGRUaVZtZERqTmFXUkhmL0RtbnM3WEFWRSs4NDFQNVVuMWQybGVu?=
 =?utf-8?B?S2hjbzVJUW5ZQS9IZGJFc3lhdFBJbXUxY0RnQm15RDhqNTBOQ2o2NG1Ea3dj?=
 =?utf-8?B?Q0VtbEpPUXVNWkVXWEE0Zk9ZR0YrVFA3QWdaK2hKLzh0SHpoU3JGdDZiTFRS?=
 =?utf-8?B?Qnc4dXdZbWJOSDlLL2pkdDhiRlh3ZFQ3TWVHTDNLTVNOWU5ITDVlSHlIRUtW?=
 =?utf-8?B?eENra1g1UXdLQU9qL3RRS0N2bVhmWlBqejVzMHJjNzgvdTlZMC81T05jUlQ2?=
 =?utf-8?B?OEZHVWFsQklXek4wU0lpMHljbi9mRXkrbklzRDFNZHlvNVhoUng5dGNqYjRU?=
 =?utf-8?B?TUlOWUZoMTZNdlJoME1tQTVsU3Q5N2lrMUlIMU9zSDNDWExwZjVMS29HYVFL?=
 =?utf-8?B?OTBHYWliWksxTG82NFRLdmtBU25PL093aEZiZllvZmVjM3dhQWcwVVNzd0JX?=
 =?utf-8?B?YURVZ1JXTVpETjRFKzJGZFRkT1I3UXltanRuMjFRbzROV3JOSnhSZk55OFFZ?=
 =?utf-8?B?QzVNWFNYS3pCZHl2WTVZTFpJVVd6bko2dHhZbXpidjNLRlVZY0lVeEl3T1lj?=
 =?utf-8?B?aUJzSklXRUlQNjk1bmpVczBXRnFWbmJabGF2TkxNa0t4eGp4aEhkcmg1ZXNI?=
 =?utf-8?B?SUxDSjdsTmhuMTBERzFHdEI3SDRjVml0c0xYSDRYT29ONTBGZDRBTThqOG9W?=
 =?utf-8?B?Q053RzI2dDJmY0xmQmM1bUFTcVM3L0JNSFVpTE9ER1k1OXpDcnpGeXFYZXpM?=
 =?utf-8?B?ZFNKcnE1VnZRc2RXWldjd2NsZnd5STM2bDROU3Eza0ZTOExOYjVCQ0t3YzAy?=
 =?utf-8?B?K1hVNi9lS3o4Ulc2NDQ3TVFQZUpYNTE3TDNrZHFiNkdhaTBNQXYvMEMxV0E1?=
 =?utf-8?B?ejFJTVEvanV3a1V3NmkxU0w3UXB0SXRabmJCVjRvTFlFeVczbkJtV2N5UlAy?=
 =?utf-8?B?bEUzMUI4a2YvTnNJcDg3cldOaHo4Ukg1MVlNQ3lsRlAvRnUxK1dUWGhMYXo1?=
 =?utf-8?B?RXlzRHc3ZFI4M1dLNkdrU242RTB5eDg1TVl2MnA3L3pKNUVYbHh6aFZqcmFv?=
 =?utf-8?B?MFJ5TzZaUzBaVGwyVUplVUhYb2t2SXVvbEl3TWxQZE9hMXRsV3NzL0FXaUV5?=
 =?utf-8?B?Nk1IaituWWg1Z1pac3pSWGRwcGU1bTJTQ0tqQ3VBUWdqUndRMU05UnpKS29v?=
 =?utf-8?B?TDA1N3BKbjEyQ3hVckFZZjkxMWQ4azMrRWJlV3VyWVNWaXNwenJSTlUwczRo?=
 =?utf-8?B?K1dLNFZSMlkveU83b0pvemh1R0RBdVR5NURORFREUjdxSGo0Wlc2OURBUzh4?=
 =?utf-8?B?cTJYWmRYMHNVNHBXN3VZQVFuZW9uOXFSbEtOTzB6MU42OFFJYzltYS81blBT?=
 =?utf-8?B?ZUUwdGNRc3lnLytIV2x3c2NKS1VOWGpFbWMyTUNpeWxwYVZuNGpJY0V4ekxH?=
 =?utf-8?B?eVZEeGJPeGlQdGRGMDhCNGkvVnBtSW1RRDY3Nm81RWdYN2dKVjFZcXNLYnk1?=
 =?utf-8?B?aXEvdWIrUDlDenhzMkZjd1pkdTl1MGlVWUUvNUUvQnlQR0xJQkJJTjdiYVM0?=
 =?utf-8?B?OGxQNC9DazF3VUE1endJMHVXVjJ0dFo5VVdUVFFkUHJ4SHRGMElDNHFSQTZZ?=
 =?utf-8?B?elBWMkhXbkJXV0k3eHFYbC82R2s1SFJWYit3MDRKQnlTSk9YUlVFNEU2ZmVR?=
 =?utf-8?Q?wzJo7sotx1m7CcLk=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 120c22b2-5228-415b-c8f6-08da4d85cc52
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 21:43:48.1875
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /hnE/lc5Pdci4H/E7UfPddZ9/+ncDTa48MqrXDin+4tCqsv3ZMCPtcisehBM+EdlA/g3WcJekY4zfuKt+2nTng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5929
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-13_09:2022-06-13,2022-06-13 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 malwarescore=0 bulkscore=0 spamscore=0 mlxscore=0 adultscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206130084
X-Proofpoint-ORIG-GUID: -YMs-xD2W3JKhLiaUdX4khzL0LoFa3jo
X-Proofpoint-GUID: -YMs-xD2W3JKhLiaUdX4khzL0LoFa3jo
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 13, 2022 at 02:35:11PM +0800”, Muchun Song wrote:
> After the following commit and previous commit applied.
> 
>   78f39084b41d ("mm: hugetlb_vmemmap: add hugetlb_optimize_vmemmap sysctl")
> 
> There is no order requirement between the parameter of "hugetlb_free_vmemmap"
> and "hugepages" since we have removed the check of whether HVO is enabled
> from hugetlb_vmemmap_init(). Therefore we can safely replace early_param()
> with core_param() to simplify the code.
> 
> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
>  mm/hugetlb_vmemmap.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz