Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d18e93a0-f2d7-81c6-56e8-9dfbc6f14383@gmail.com>
Date:   Mon, 13 Jun 2022 16:34:12 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] ARM: dts: bcm2711-rpi-4-b: Use aliases to set custom MMC
 device index
Content-Language: en-US
To:     Ariel D'Alessandro <ariel.dalessandro@collabora.com>,
        Peter Robinson <pbrobinson@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
        gkrzysztof.kozlowski+dt@linaro.org, gnsaenz@kernel.org,
        grobh+dt@kernel.org, nsaenz@kernel.org, stefan.wahren@i2se.com
References: <20220608123233.13439-1-ariel.dalessandro@collabora.com>
 <CALeDE9PR80qS63wwAKB-hENWbEj1xNHj+k81tyWkPPfZ0TS8Pw@mail.gmail.com>
 <f83690bb-5513-db87-2d97-7cbd981aa0f7@collabora.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <f83690bb-5513-db87-2d97-7cbd981aa0f7@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/13/22 05:46, Ariel D'Alessandro wrote:
> Hi Peter,
> 
> On 6/12/22 17:38, Peter Robinson wrote:
>> On Wed, Jun 8, 2022 at 1:35 PM Ariel D'Alessandro
>> <ariel.dalessandro@collabora.com> wrote:
>>>
>>> Add MMC aliases to ensure that the /dev/mmcblk ID for SD card won't
>>> change depending on the probe order of the MMC drivers.
>>
>> Is  the bcm2711-rpi.dtsi a better place for it given there's other
>> aliases there and it will be consistent across variations?
> 
> Yes, indeed, it makes sense moving it to bcm2711-rpi.dtsi
> 
> The other board what will be affected by this alias is the Raspberry Pi
> Compute Module 4 IO Board, on which emmc2 is the eMMC. However, the
> alias makes sense, to have that as the first mmc device.
> 
> Maybe we can add the alias as follows?
> 
>      mmc0 = &emmc2;  /* mmcblk0 for eMMC/SD */

You have made a typo on the bcm-kernel-feedback-list meaning that this 
won't reach the patchwork instance I use to manage and apply patches, 
can you please fix that up for your v2? Thanks!
-- 
Florian