Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 13 Jun 2022 16:41:35 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Sohil Mehta <sohil.mehta@intel.com>
CC:     <linux-api@vger.kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
        <x86@kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
        <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
        <linux-kselftest@vger.kernel.org>
Subject: Re: [RFC PATCH 1/6] testing/pkeys: Add command line options
Message-ID: <YqfLL2IyMWWWkvQd@iweiny-desk3>
References: <20220610233533.3649584-1-ira.weiny@intel.com>
 <20220610233533.3649584-2-ira.weiny@intel.com>
 <951dc92e-b4fe-71fb-4601-d9df1319a9ca@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <951dc92e-b4fe-71fb-4601-d9df1319a9ca@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wNzB1b82465olZpga5YftUpxF8cRreyTY6fTSwU3DKktdb7gpc1hzmiFLl0E?=
 =?us-ascii?Q?Voh52F+z2SWwm3Mf9Wyu3RGrtu+m2oRXtVWTWvUe7eAb0Wttol17lblIT8oY?=
 =?us-ascii?Q?ppO/8CQaOj3GULMkHsyctfoMEviXBBhnuhCDn+M7FM7djx+lhtZFVm4oFfpd?=
 =?us-ascii?Q?BeVkjiESA/kLUBT4+DHBy7vsLN4TfaL3du7dqA2kVq7dPTJFaPhgf4rmCu2e?=
 =?us-ascii?Q?NZgIoSWQUC+DJMt+JI8thI+szjaM2eaBSgY8SPhduxEXmkozvtgZVOM0EtR+?=
 =?us-ascii?Q?SRLm28c4fex+Snymt6gcx5XvlRb05p/HtfOnONqqVuumecmpO/po66isCpRJ?=
 =?us-ascii?Q?PE+WIscgyGHPGHWiySckqNwesJEqjKeimWp2yHIEmZKHpj6Cij6ucrq035JD?=
 =?us-ascii?Q?RPxRAlFofaUwYnLI6NV6EGcMeqGQaJpnC4Dvc2TUyupj0rrwco1Za8H62onX?=
 =?us-ascii?Q?3BKE0jsbtUr7KV19vB61+TWuBDvDTMRkiPrUTi5ZMYBKC7W6BCnTKnT1JSlG?=
 =?us-ascii?Q?jv942dBlsZE0uqC7xCI2l5Lo0iakoaflWs+MHV6VLNFv8Ykmj0z2XHshP778?=
 =?us-ascii?Q?TfPFWTnGAe3lWEogns10V+DTWvzIXGpU8qx4OKYNdgFmV9chmmEbK/+dBNtL?=
 =?us-ascii?Q?Tykg4gDdbe6Rh+LPUuR5Ufu9yr+pt5syGw0M7dNWDS8zkPllRw7ucoBJwRAT?=
 =?us-ascii?Q?8qBwQcQxqHV/8YwH/9KyREbWRyE4rwPa/pMVIYfFtUKd0BN+JUK6CsL96TlV?=
 =?us-ascii?Q?PRlTiYGmqx1/wA1zzPVT+sFIH6ru5mZQKBQHSeBHKD/7sRpoJJpiwdVTison?=
 =?us-ascii?Q?iK8PEAVMkqbqiMZ0p6yly70G8tZ5DvBrq8yIJPlNxnDGl8dAyzNhWbmf4u7d?=
 =?us-ascii?Q?jZsf873845gxJ8E3flJcTMe2wsrB1acfErJzp2WtN8YlEk/We7jNvD6CmJ7a?=
 =?us-ascii?Q?enn9X4mj1DMdzugG/hzw9Euwa/TPn0p137T+/e8tgf4MTU+flSnlsJWsNU1j?=
 =?us-ascii?Q?06V/htgcgrsfCZLGzjSy9dRuKdPgQvwQOBZ4YHO1q5l8k45cowTdUzekQWrB?=
 =?us-ascii?Q?t8h55qgvIbt4VjoogSl58HL9TiIc8crjN4wwQQO5gUFWOmyET9U5SIzXo9h7?=
 =?us-ascii?Q?14WJCum0dOI6BUoiZMjYmbDClBf/AvYmkbuiedNQRUQh7jbjNZAUvO7g11qc?=
 =?us-ascii?Q?k8/0sdgI3jKl168XxLOkum2q4gjdnesKMNb+CNtYzuUEnSuKkj/aQpZnRzGf?=
 =?us-ascii?Q?mOaepg7qWn++4eWAFpQY8ivqdWLHyk758i/g8FU4AJPL8bldctmFilNPokDM?=
 =?us-ascii?Q?n4yigBvtm4RJdzHuf9FO3LiLNgxbo4XBKNm+cQpJpmRFnvSQTBvZvbbvMCHc?=
 =?us-ascii?Q?MKbaPGzyvccfMpL5F3fc26zIT9aB25RLhnxm1bYDZ3J7dgjCLTkYne3GA8jc?=
 =?us-ascii?Q?p62rSAn7Ft2pRGtk6bITEzuQaLuNHmrl/nn81cWKMimvuWW4Oh4g9L3gWJtS?=
 =?us-ascii?Q?PJN/o223cytj+4r0tAfbij5lhbJtD/HSKRxId1o8nwuzyEE37TX1gjYNQE7l?=
 =?us-ascii?Q?dk/7QH4bSxaSzxboaMg04bLVEnOhl0azOrBm5sVcl1cWK+ukmOCJBgIplpHM?=
 =?us-ascii?Q?2+l3sEKnoY623q+eay8CS7ajdrtCLf/3ONg9CpwjQxJq4QsOMBt3eq1F1sB/?=
 =?us-ascii?Q?urVObm7hsbjgs0Fy2v4xxbLdbAv4a99rWwO+51j6oG2nZioUrVCsTvwPi1fu?=
 =?us-ascii?Q?Dv5Cb2NbLA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5c46df0c-c38f-4678-3004-08da4d964322
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jun 2022 23:41:39.4187
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: y3qwfGQ2zySBhbsY4XBIcweIurCNVdQ8nmgc+VxoQMuqRHlOE1dnb9atkzEn+odDOlbPGacfydLlgCvaxRlmEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4587
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 13, 2022 at 03:31:02PM -0700, Mehta, Sohil wrote:
> On 6/10/2022 4:35 PM, ira.weiny@intel.com wrote:
> 
> > Add command line options for debug level and number of iterations.
> > 
> > $ ./protection_keys_64 -h
> > Usage: ./protection_keys_64 [-h,-d,-i <iter>]
> >          --help,-h   This help
> > 	--debug,-d  Increase debug level for each -d
> 
> Is this mechanism (of counting d's) commonplace in other selftests as well?
> Looking at the test code for pkeys the debug levels run from 1-5. That feels
> like quite a few d's to input :)

I've seen (and used) it before yes.  See ibnetdiscover.

...
# Debugging flags
-d raise the IB debugging level. May be used several times (-ddd or -d -d -d).
...
-v increase the application verbosity level. May be used several times (-vv or -v -v -v)
...
	- https://linux.die.net/man/8/ibnetdiscover

But a much more mainstream example I can think of is verbosity level with
lspci.

16:29:12 > lspci -h
...
Display options:
-v              Be verbose (-vv or -vvv for higher verbosity)
...

> 
> Would it be easier to input the number in the command line directly?
> 
> Either way it would be useful to know the debug range in the help.
> Maybe something like:
> 	--debug,-d  Increase debug level for each -d (1-5)

I'm inclined not to do this because it would encode the max debug level.  On
the other hand I'm not sure why there are 5 levels now.  ;-)

Having the multiple options specified was an easy way to maintain the large
number of levels.

Ira

> 
> The patch seems fine to me otherwise.
> 
> > 	--iterations,-i <iter>  repeate test <iter> times
> > 		default: 22
> > 
> 
> Thanks,
> Sohil