Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220612035641.1161945-1-sunliming@kylinos.cn> <66c1cf3a-9f2a-e05a-3c76-62b1ee056385@intel.com>
In-Reply-To: <66c1cf3a-9f2a-e05a-3c76-62b1ee056385@intel.com>
From:   sunliming <kelulanainsley@gmail.com>
Date:   Tue, 14 Jun 2022 08:52:34 +0800
Message-ID: <CAJncD7Tn4i59SR=Ee-dEXkXq74g8LEzRQ7X=fE92kM26BFocig@mail.gmail.com>
Subject: Re: [PATCH] KVM: x86/mmu: Remove unused "type" of split_page_type()
To:     Xiaoyao Li <xiaoyao.li@intel.com>
Cc:     isaku.yamahata@intel.com, pbonzini@redhat.com, seanjc@google.com,
        mingo@kernel.org, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, x86@kernel.org,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

I got it, I am sorry aboot it , thanks.

Xiaoyao Li <xiaoyao.li@intel.com> =E4=BA=8E2022=E5=B9=B46=E6=9C=8813=E6=97=
=A5=E5=91=A8=E4=B8=80 10:48=E5=86=99=E9=81=93=EF=BC=9A

>
> On 6/12/2022 11:56 AM, sunliming wrote:
> > The variable 'type' in split_page_type() is set but not used, so remove
> > it.
> >
> > Fixes the following w1 warning:
> >
> > arch/x86/kvm/mmu/mmu.c:982:28: warning: variable 'type' set but not use=
d [-Wunused-but-set-variable]
>
> Please note, the code doesn't get into upstream yet.
>
> The fix shouldn't be sent to upstream maillist.
>
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: sunliming <sunliming@kylinos.cn>
> > ---
> >   arch/x86/kvm/mmu/mmu.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> > index 7b3df91a93cf..f4d577335f94 100644
> > --- a/arch/x86/kvm/mmu/mmu.c
> > +++ b/arch/x86/kvm/mmu/mmu.c
> > @@ -979,14 +979,12 @@ static void split_page_type(gfn_t gfn, struct kvm=
_memory_slot *slot,
> >                           enum pg_level level)
> >   {
> >       struct kvm_page_attr *page_attr =3D page_attr_slot(gfn, slot, lev=
el);
> > -     enum kvm_page_type type;
> >       gfn_t base_gfn;
> >
> >       if (WARN_ON_ONCE(!kvm_page_type_valid(page_attr) || level <=3D PG=
_LEVEL_4K))
> >               return;
> >
> >       base_gfn =3D gfn & ~(KVM_PAGES_PER_HPAGE(level) - 1);
> > -     type =3D page_attr->type;
> >
> >       /*
> >        * Set the type to KVM_PAGE_TYPE_MIXED in advance since when a la=
rge
>