Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220612071535.1179039-1-sunliming@kylinos.cn> <Yqb9VoYe+D69KYTY@noodles-fedora.dhcp.thefacebook.com>
In-Reply-To: <Yqb9VoYe+D69KYTY@noodles-fedora.dhcp.thefacebook.com>
From:   sunliming <kelulanainsley@gmail.com>
Date:   Tue, 14 Jun 2022 08:52:59 +0800
Message-ID: <CAJncD7ToFdEWW70Suf1=STwOK8vzTgkgF1tQMu3GL-n=ffoRPw@mail.gmail.com>
Subject: Re: [PATCH RESEND] of: Add missing function declarations
To:     Jonathan McDowell <noodles@fb.com>
Cc:     "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "bhe@redhat.com" <bhe@redhat.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "frowand.list@gmail.com" <frowand.list@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

OK=EF=BC=8Cthanks

Jonathan McDowell <noodles@fb.com> =E4=BA=8E2022=E5=B9=B46=E6=9C=8813=E6=97=
=A5=E5=91=A8=E4=B8=80 17:03=E5=86=99=E9=81=93=EF=BC=9A
>
> NAK. This is for a patch of mine that I don't believe has hit mainline
> yet - I've only seen it in daveh's test tree. The prototypes for these
> functions are now guarded by CONFIG_HAVE_IMA_KEXEC but all OF platforms
> build them even when the platform doesn't actually support IMA over
> kexec. I'll update my patch to avoid that.
>
> On Sun, Jun 12, 2022 at 03:15:35PM +0800, sunliming wrote:
> > Fixes the following w1 warning:
> >
> > drivers/of/kexec.c:126:5: warning: no previous prototype for 'ima_get_k=
exec_buffer' [-Wmissing-prototypes]
> > drivers/of/kexec.c:153:5: warning: no previous prototype for 'ima_free_=
kexec_buffer' [-Wmissing-prototypes
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: sunliming <sunliming@kylinos.cn>
> > ---
> >  include/linux/of.h | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/include/linux/of.h b/include/linux/of.h
> > index f0a5d6b10c5a..3a166a1c4ef6 100644
> > --- a/include/linux/of.h
> > +++ b/include/linux/of.h
> > @@ -844,6 +844,16 @@ static inline phys_addr_t of_dma_get_max_cpu_addre=
ss(struct device_node *np)
> >       return PHYS_ADDR_MAX;
> >  }
> >
> > +static inline int ima_get_kexec_buffer(void **addr, size_t *size)
> > +{
> > +        return -ENOSYS;
> > +}
> > +
> > +static inline int ima_free_kexec_buffer(void **addr, size_t *size)
> > +{
> > +        return -ENOSYS;
> > +}
> > +
> >  #define of_match_ptr(_ptr)   NULL
> >  #define of_match_node(_matches, _node)       NULL
> >  #endif /* CONFIG_OF */
> > --
> > 2.25.1
> >