Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp993100iog; Mon, 13 Jun 2022 18:18:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx7CeefEY83AMiKogq4huRupHlC4QlS7gQNaS8BT8ygIXPX7YiiWWqZN0bh+FUe/L+JcB+y X-Received: by 2002:a17:906:a10c:b0:711:ec20:69d1 with SMTP id t12-20020a170906a10c00b00711ec2069d1mr2135850ejy.718.1655169494590; Mon, 13 Jun 2022 18:18:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655169494; cv=none; d=google.com; s=arc-20160816; b=Vgf/QcusNL6GdrKeMHWln1vYY8xuViL9DaX46h6wbsRUUiJ6vNluQSojn0EmKSbpDy QERHbAGJiSr6EfBJwg2ihNXwWZFtF9hmqOuFzIN9+EDshq8i3UlddIMsklK/RcIsNMO1 mrpZb4DhNouswdCLr5BGfQ3O1GGZ8rqz7eObFU61A2bHsJLgCP7VPv0UBIOk+cqPA4m7 DqD2CmxBYzzaLlfpooVk2ymltIij3AJOAId6Cz+hmi/wqMZXN3SPR2xHn+w3OKQvGe+F 4Er8UY6xEklyTi0/oos0sT6iB2L5DSW7HwAPfov+7UaSklMZfaZ7k5zQfxl6j70xB0XV g5qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-filter; bh=jv9RhEpcUlvGbL9sQ7elV4SIcD7tvGoqa9vr/gW0wBY=; b=Cf8piXHNbUiTTW9DnDGKIlAt/znIoxuUsDCqAKJmDX6WmxGPiLvCbnec8+23w3iLit 7rVM1AhA2dkfi6pl7+wmTO1Jcp06damtEybFFZsEa/dI2/zdlSnZAM5ozJUBZ1sKHnxH 8ubTnqyze7M9JGdbEl0zP4PHqrZ1n5W6SNZ8/Zrr9X3L0y6x7MCoWlpSPugB0mFgLM9C K2RGQbAQnEk2csRaxbT9X37m8XGBD/nBanp8317f3rAw7wf53MlZFJBGgy9asZuUjUaW ibmGjboI0ze3qDPp+iBuF1IbGggC3BFh2AakvWB9pnEckhyguj8WdOUIkyHY8aSM+rwF i1pw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b="IuMF/Gj6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nb1-20020a1709071c8100b0070d4f9de56bsi10428448ejc.254.2022.06.13.18.17.48; Mon, 13 Jun 2022 18:18:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b="IuMF/Gj6"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232209AbiFNBPA (ORCPT + 99 others); Mon, 13 Jun 2022 21:15:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229853AbiFNBO7 (ORCPT ); Mon, 13 Jun 2022 21:14:59 -0400 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 690E820F73 for ; Mon, 13 Jun 2022 18:14:58 -0700 (PDT) Received: from sequoia (162-237-133-238.lightspeed.rcsntx.sbcglobal.net [162.237.133.238]) by linux.microsoft.com (Postfix) with ESMTPSA id B923520C29A6; Mon, 13 Jun 2022 18:14:57 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B923520C29A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1655169298; bh=jv9RhEpcUlvGbL9sQ7elV4SIcD7tvGoqa9vr/gW0wBY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IuMF/Gj6OCjwCm1oyiAXJeUN4MMtG+TIxmT7cyh6m1sPL8INXRIPEPydjL6j+B1pw 4QF2jdYTH2aulyWdGA+3BUKkgiHnZHmhs8/OvXzhWc51r/1iKxB3IowBg5zxs8uTy8 zt6HbBnQwYRrJvOaUnkM70BzBWr5DjxViV8L9IOo= Date: Mon, 13 Jun 2022 20:14:55 -0500 From: Tyler Hicks To: Dominique Martinet Cc: Christian Schoenebeck , v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/06] fid refcounting improvements and fixes Message-ID: <20220614011455.GJ7401@sequoia> References: <20220612085330.1451496-1-asmadeus@codewreck.org> <20220613202053.GI7401@sequoia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-19.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,USER_IN_DEF_DKIM_WL, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-06-14 06:00:21, Dominique Martinet wrote: > Tyler Hicks wrote on Mon, Jun 13, 2022 at 03:20:53PM -0500: > > On 2022-06-12 17:53:23, Dominique Martinet wrote: > > > @@ -222,7 +221,8 @@ static struct p9_fid *v9fs_fid_lookup_with_uid(struct dentry *dentry, > > > * We need to hold rename lock when doing a multipath > > > * walk to ensure none of the patch component change > > > */ > > > - fid = p9_client_walk(old_fid, l, &wnames[i], clone); > > > + fid = p9_client_walk(old_fid, l, &wnames[i], > > > + old_fid == root_fid /* clone */); > > > > This is no problem at all. The rebased patches look good to me. Squash > > your fix to my fix and it should be ready to go. > > Thanks for all your reviews :) > I've rebased my branch if you want to check: > https://github.com/martinetd/linux/commits/9p-next I've diffed the individual patches from before and after the rebase. It all looks great to me. > We've just started a cycle so I'll submit the first three patches (fixes > to stable) next week, and the rest for when 5.20 cycle starts. That sounds like the right plan to me. > Feel free to remind me if it looks like I forgot. Will do! Tyler > -- > Dominique >