Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e187af34-d0a8-55ed-cc21-d88845ec1eb5@nvidia.com>
Date:   Tue, 14 Jun 2022 09:19:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] RDMA/cm: fix cond_no_effect.cocci warnings
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, jgg@ziepe.ca
Cc:     leon@kernel.org, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20220610094530.28950-1-jiapeng.chong@linux.alibaba.com>
From:   Mark Zhang <markzhang@nvidia.com>
In-Reply-To: <20220610094530.28950-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDRPM3hCNFNxWnBTeVp1UW1LTWpLVERvVldoazFLZExIT3VnVDBmVmdVdDlt?=
 =?utf-8?B?N29YSUVueTNjTnR1dFByN0Z5K0tXSEptS1h6eUFTeWlnd2poWURMZmZtYnhi?=
 =?utf-8?B?dyt2SW9saHdFbENWVC90VThmV29IUk54c2k5MnVSR2F5VWR3RS96MWZrTzlQ?=
 =?utf-8?B?VUVNN3gvQ2ZMWmZjSkUrT1FsWnBQSnYvbDRWZStxREFUZFlFN1hjZFFHY29v?=
 =?utf-8?B?M0dtSHBubmtST1NVSnRuQXpPamhwVWxmRzNoWHNZNWRDVzVhdDhuMGVNMFlo?=
 =?utf-8?B?YjZFM3VZT0ZRdlhYcEkzaDhxeHRFMjdjSDgzKzN6akxGZ29XWk9YWkxsVWlZ?=
 =?utf-8?B?S2xwckdKWExVSmN2T1hkTXhRL21uT00zSEgzT1Z3aVE2QlB5cDF1aEpsS1Q2?=
 =?utf-8?B?UFpNbEpuakF4VTFwMjVQUDdRcHUyUi9QbGVXZmE0RFdMYyszYVlRTVlzUENv?=
 =?utf-8?B?K2lNUVc3emFzS2tYd3RGRDZtNXNHVmRQSWZsdjh1am9hb3RBY2toVWhNNU5Y?=
 =?utf-8?B?V0hHVUpraWdIQ3pCMk4weEVBZWkvUTFkOWpoY1Fqa05SSUpFSTNyR2JjMlRu?=
 =?utf-8?B?MEM5c0wrRmNnOW9QeDVqYU1leXpqSHZONmMvRm9kRFMvRXBpdTlZTWl3L3ph?=
 =?utf-8?B?cXdwdTNWelB3ZzdZbkFtV1cyQmF2ekVickhNalFFN1BGbWZRblMrRXVEeXoy?=
 =?utf-8?B?SE5MaWh2VG1JNFh2ZkltNEtGb3JEWUloYktUano4RUluYUs1ZFYwM29zK2dj?=
 =?utf-8?B?eXZ1anF0eEJXRGZUaG53Sno0T1M3ZFk3RkV1cC9sQ2Q3bG5qRTBOS2M2ODM3?=
 =?utf-8?B?T0NqYkltbzdtTllMcHFzZ3h0MU9OWUhDdXRqZklvSk1kRFkvS3pKTUE2blRM?=
 =?utf-8?B?NUJmbFh3ckJCZmh0empzRE9LbXVXMnV1dUJHWnpuTDAxYzI4MVBDNUpEMnpL?=
 =?utf-8?B?eGNJVm5PQVJCR0wzdzZ6R2VzNFNrWS9uMVBSc1RPZTBxK2hJbXhKWGRqSmo0?=
 =?utf-8?B?VTJOZ2JKbEppeHA5UEg5Z2dhcnZ6YWhNZG8zYmp5VFZkZkdaQnlvVndiR1dQ?=
 =?utf-8?B?OU5PT3VFUFFzV084NjYxMGVQOHhRNFU3L0NKRkdoR1l0WnkyS3RUOU44Nzda?=
 =?utf-8?B?Y3owc1dJV01aZVp3UjVtL05FSktzL3c0c0lKSXVINkRJWnFLa3Y3T3BNS0Qv?=
 =?utf-8?B?WUpxdWh3QmpESFpTTDlKVUxoS2cyQW5WbmlFMVJqN254UDEvOHBiM0VyVUs1?=
 =?utf-8?B?RmZkWHFKV1huWDhnOWFLdERrVlVmSGZyUlo0QWkzYzVaNmRzNjJySGV1RVZ1?=
 =?utf-8?B?c3JWa3VxSVBES2xJQnZXQkxjeUlhVzl0a051eFpXTDlCUXRhaUYrOGxrSS9I?=
 =?utf-8?B?VEpzcVNKYi9WbEc0VGVIcFcrMVlvV2FndURYRkNxTFppVHBxQ2RnNSszejls?=
 =?utf-8?B?ams2WXlmZExsdDBHSEtUSHJSK1JnWFRHaUtNbi9XR0U1ZlF0djlYVEdrMU5T?=
 =?utf-8?B?dTd6RWNFUDA0VEtZSkVBUWMzWlhEcDBwRU9KV29RWnlLNFVIR1YxOXpTU1hY?=
 =?utf-8?B?YjB3b09hOGl6YXBuMkNOdWk5VEZkRUlWTHJxU21iZ0h6VjcyN25MMVNrbGEr?=
 =?utf-8?B?dUl6VXNLQzU0bXdYa3doUWVmOUQ1eTJBQWlvK3RUV1VpclZuTmRQRGpDUDZB?=
 =?utf-8?B?YStNcmFhenBhR0xkM0dOd3BYZmJ0dDVtWllwYWNRWk5HS2hCcXpUWVV0Vm9W?=
 =?utf-8?B?clNNT011TWh0RTlIUVQwWUordFN1RmE3MlNGeW5lay9kdzhDSUo1T3ZwSW5p?=
 =?utf-8?B?c2ZSeVhyc3JTUXhiRjNiVlFvZy9ab1Jlb3oyeDhuSWV4V2pvT1hVSmJrcklu?=
 =?utf-8?B?WlgwUGMxV094MWdGSE9LaGZEdmxYSkVtN1FNdnZEV2NuNGZMS0grVVplYjV2?=
 =?utf-8?B?WjhSK0NiK2JmV1Q3L2pDZjNyazJOSFVFclphNU4yaXdZYXJFUndWdTZ1VElI?=
 =?utf-8?B?eVFKNGRVMWlaMUZzYUJvNzQwdlJ0OStGbnN4bnk1bk0xYnZNMitYWWdObG9W?=
 =?utf-8?B?ZEcwS0FXcXFnaXpOODBrK1JjNlVrOEpVNmpyUGpPQnFMZkl3YTM0eTIyaVVQ?=
 =?utf-8?B?c0V6ZkMydWxweS9wRmFma1dibHNHbGtlNDlOODE0WGZLOThLM2Q5aXB3NmEr?=
 =?utf-8?B?ZjQyZExrRldndVFvRjQ0YmNMSVB5QThTT245MWxDZW5aSEZNRlBRdlluWXV4?=
 =?utf-8?B?OEl5RXl2ZTMwNDFDMjVETlFFTzNaTy9EMHkvU0h5RjRYOWVRRmR2SytGdStU?=
 =?utf-8?B?S0lGaHlLQnRWN0FYczM5WmF0bU53TEJDaGkyZ3AzQjdheW1pcnAyUT09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c165f0e2-d531-4157-12e9-08da4da3eab2
X-MS-Exchange-CrossTenant-AuthSource: CY4PR12MB1366.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2022 01:19:24.2330
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aMJuFqWAXMHsr6rrLmlwnNZIbcUSOD92wbEM2W0QwEuOnbOwJuhhi5ukg69AChuyGvnK94WSM1Mr7oVvyXervA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB2456
X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/10/2022 5:45 PM, Jiapeng Chong wrote:
> This was found by coccicheck:
> 
> ./drivers/infiniband/core/cm.c:685:7-9: WARNING: possible condition with no effect (if == else).
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>   drivers/infiniband/core/cm.c | 9 ++-------
>   1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c
> index 1c107d6d03b9..bb6a2b6b9657 100644
> --- a/drivers/infiniband/core/cm.c
> +++ b/drivers/infiniband/core/cm.c
> @@ -676,14 +676,9 @@ static struct cm_id_private *cm_find_listen(struct ib_device *device,
>   			refcount_inc(&cm_id_priv->refcount);
>   			return cm_id_priv;
>   		}
> -		if (device < cm_id_priv->id.device)
> +		if (device < cm_id_priv->id.device ||
> +		    be64_lt(service_id, cm_id_priv->id.service_id))
>   			node = node->rb_left;
> -		else if (device > cm_id_priv->id.device)
> -			node = node->rb_right;
> -		else if (be64_lt(service_id, cm_id_priv->id.service_id))
> -			node = node->rb_left;
> -		else if (be64_gt(service_id, cm_id_priv->id.service_id))
> -			node = node->rb_right;
>   		else
>   			node = node->rb_right;
>   	}

Not sure if the fix is correct, e.g. with this condition:
   device > cm_id_priv->id.device &&
   be64_lt(service_id, cm_id_priv->id.service_id)

The original code gets rb_right but this fix gets rb_left. Maybe the 
warning is complain about this:
	...
	else if (be64_gt(service_id, cm_id_priv->id.service_id))
		node = node->rb_right;
	else
		node = node->rb_right;

Besides cm_insert_listen() has same logic.