Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Ong, Boon Leong" <boon.leong.ong@intel.com>
To:     Russell King <linux@armlinux.org.uk>
CC:     Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <Jose.Abreu@synopsys.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Vladimir Oltean <olteanv@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Riva, Emilio" <emilio.riva@ericsson.com>
Subject: RE: [PATCH net-next v2 4/6] net: phylink: unset ovr_an_inband if
 fixed-link is selected
Thread-Topic: [PATCH net-next v2 4/6] net: phylink: unset ovr_an_inband if
 fixed-link is selected
Thread-Index: AQHYfHsNhgn9gM3W/EyGBireR1rHYa1IPyYAgAXrJFA=
Date:   Tue, 14 Jun 2022 01:54:59 +0000
Message-ID: <DM4PR11MB6095669DB87FF30288EE2B9DCAAA9@DM4PR11MB6095.namprd11.prod.outlook.com>
References: <20220610032941.113690-1-boon.leong.ong@intel.com>
 <20220610032941.113690-5-boon.leong.ong@intel.com>
 <YqLzPrEfcwqeKNX0@shell.armlinux.org.uk>
In-Reply-To: <YqLzPrEfcwqeKNX0@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.500.17
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fV2VglATmwWj3AqgCS5LEkOINSejgq7zyWTgw2oX9G9NXSG5fUsAtqXj+oYk?=
 =?us-ascii?Q?WmARXwHNzN6Szpb0zQOA3b04kZtOFWexQNFi8NJpkEr2idxwj3XZo2pdyVxM?=
 =?us-ascii?Q?Hjpobs0Jk0MHOR9THC2zNUPH5iqGyUBLhhXuWP14ARgMh4xo6hu1f9LVGRdw?=
 =?us-ascii?Q?ykrzfKRYQ1epzbk4nmhPEAK9wdJ2i6gHOZkSSzY1IcZ2AIIonOZ0+TSJ2Hf8?=
 =?us-ascii?Q?sXlt9J8PVInCqWjiWxKlTX+jfMiotSXCRAoZxpKtUoVbjr7ikYrIu+xXcL90?=
 =?us-ascii?Q?sROjUxLa+WykEp/Yk/A7YWKdrXLTtmqpdrh0z69SQv/01o4RfJQd8M7piZDt?=
 =?us-ascii?Q?uZxnpSW+kIwxRH1v7ni6RMit6tqIzZqflaFhBD00GCgoWrtfTuyiPy2tUHur?=
 =?us-ascii?Q?EKrJAUgXwDhxvDs0BCqvBnfl0cJlcKz3zVYIrEjqwhe67GqZ+C8RHVbFAovn?=
 =?us-ascii?Q?aNdlaDbAHog6AdiA1nrhWr2aOHgVspnHA+efIr7gBn/sLeQJzTFr2o9Dxazm?=
 =?us-ascii?Q?irkk63k5xFr+E/yW8X07zslURszZJX57+TPFbOSOQy2exFJjwICyRBaJVXBL?=
 =?us-ascii?Q?+yudweMxwMNg5jczE2uuiYNP0aoOQuAGTh/9Ytb+G91Ar56f+09lH7QM2Yq4?=
 =?us-ascii?Q?CC8L0BzBOnl2IizGVIp43TuUiI6APzmjXjXydXVzqCG/VacZJ5VgwmRBTlGb?=
 =?us-ascii?Q?REXOozM6Sv/gVzV3c4pIafHkUMTSYxRHDRJ2uZ1i8vR9iifcwzPgUE0naxzR?=
 =?us-ascii?Q?kaseGgtcUohHHDCkyijB+X2qhcTpTElP1e6/TEsGP4dlfP0Ts4OL0UYvNPYY?=
 =?us-ascii?Q?ZEaG4fskpySmQKzp115j30rJ9G3c9NQlUMgwj67flwsUOalCn6kJC2sc/9UE?=
 =?us-ascii?Q?gNM3rNDMmmL8ZQElEtJeK4y8+QxcgUDZSIkT7Hu6iec/ohI2s+/7/lHawfB+?=
 =?us-ascii?Q?1MXXOiDuaZaW3TvSs579RwFwBbInkhqwYz0EHTdBqwUDQvGvtAK0hl3B8KEm?=
 =?us-ascii?Q?ZBhRJY8WQdTr17hEjNjwsa1GlB4nEYkfXwnzrAaC0gwTFeW8AsizAnnsMOze?=
 =?us-ascii?Q?HQrvbrlrxjPROPF0CxXliWzKXpnT33arinfuQkGk/Wu+AhM7IpniwY/JI3CX?=
 =?us-ascii?Q?JJe0ha4EJltIopTIQgq0kwoguXdgdb+a1ANSIrtovAXSHaUrT4IJx7Tm9m6I?=
 =?us-ascii?Q?iMlVL+2+8192fPsVTmjCBrWB/f6JwbZxm8/lCMtvkTUkvcwCqbFWn2Cc2JDO?=
 =?us-ascii?Q?koKdmZUZdk7jhPKLNxyeOdTpa0nRUcqOT9hQkAVlYbJR0+o8aZjJeGw1Fsco?=
 =?us-ascii?Q?wwQ16nN/1V6cpTBqzz5wM6DVxkFWdSvDAfAZo+RKjKxOV1oDsUk7IZb/XqeW?=
 =?us-ascii?Q?Xf1trquKI/r93aml8J+TkFg6KWdpjKA1d085MZFrPkHY5cXzVs2gCOD5JKyl?=
 =?us-ascii?Q?j349Fx+ppmYSgQnuNTZb4rrguH2Z8qd7dnpMlZflLaxxXEACHzYq/KsP3/do?=
 =?us-ascii?Q?Cgq3OIi+Ar+/mUqsEB98JTBITYTn9gaxf1VK4NHhtT9JdvEn065jc+GIlmDg?=
 =?us-ascii?Q?VkXxYfZB9drgzW25ItnqCAYuafS28wYvLjmvLwVSyis4bfDnEijR7ClBgkVu?=
 =?us-ascii?Q?DIqlu14te16SZxwk6oGA6IDB4xb5gdI3/naQDZVAiAIh8WuLDyC6MWsUNqNi?=
 =?us-ascii?Q?IAbAfI5dtqVYfWxAxkIyvSI02F9naL7nNF5bYe9+iA71h92r6O3Cgh1gImpl?=
 =?us-ascii?Q?8GJ1DasbmXRsmWhXydzvhsx9vZkTrHo=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f2b4a1f7-c515-4d9f-0a3d-08da4da8e383
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2022 01:54:59.3051
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: F9aYH1MLq0VTLcKju90X4/35yQX8s/N4e5Jiw4hmbzr36b6Vzsw9TchP6yIP6edw5TbrKTJVp62/ERXOtWdYOX4JjTxp63zfIlGW7Ix30y0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3025
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>On Fri, Jun 10, 2022 at 11:29:39AM +0800, Ong Boon Leong wrote:
>> If "fixed-link" DT or ACPI _DSD subnode is selected, it should take
>> precedence over the value of ovr_an_inband passed by MAC driver.
>>
>> Fixes: ab39385021d1 ("net: phylink: make phylink_parse_mode() support
>non-DT platform")
>> Tested-by: Emilio Riva <emilio.riva@ericsson.com>
>> Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>
>> ---
>>  drivers/net/phy/phylink.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
>> index 066684b8091..566852815e0 100644
>> --- a/drivers/net/phy/phylink.c
>> +++ b/drivers/net/phy/phylink.c
>> @@ -609,8 +609,10 @@ static int phylink_parse_mode(struct phylink *pl,
>struct fwnode_handle *fwnode)
>>  	const char *managed;
>>
>>  	dn =3D fwnode_get_named_child_node(fwnode, "fixed-link");
>> -	if (dn || fwnode_property_present(fwnode, "fixed-link"))
>> +	if (dn || fwnode_property_present(fwnode, "fixed-link")) {
>>  		pl->cfg_link_an_mode =3D MLO_AN_FIXED;
>> +		pl->config->ovr_an_inband =3D false;
>> +	}
>
>ovr_an_inband was added to support "non-DT" platforms, and the only
>place it's set is stmmac. I don't see why you'd want a driver to always
>set this member, and then have phylink clear it - the driver should be
>setting it correctly itself, otherwise it becomes a "maybe override AN
>inband if certain conditions are met" flag inside phylink.
Good point. Will make the "ovr_an_inband" not set inside the dwmac-intel
if fixed-link is used.=20