Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] scsi: target: iscsi: Fix NULL pointer dereference
 in iscsi_conn_auth_required()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq15yl4t2tz.fsf@ca-mkp.ca.oracle.com>
References: <20220613014321.107045-1-yang.lee@linux.alibaba.com>
Date:   Mon, 13 Jun 2022 22:07:44 -0400
In-Reply-To: <20220613014321.107045-1-yang.lee@linux.alibaba.com> (Yang Li's
        message of "Mon, 13 Jun 2022 09:43:21 +0800")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?v6qsCd+B9+O6cas2cQreO+/H6IUIgvIQV60bl6xEa5iG6fr+4YhupVQ5hMxS?=
 =?us-ascii?Q?tZHxFRjor+PPcYZe8CGU8zysoECOJWhj5i7owdnR1YWGm69lL1pXlwMUSaMa?=
 =?us-ascii?Q?D44NSDZSv8kYU2ZL+oku4RmMC96C9shvZ5vKKMvnpVYtE86X6ACANevIsyTS?=
 =?us-ascii?Q?d9DyOM/9rcwFBGtT0nneLmvas4NZFRHGFWnxq/MixrksRbN5NuKhvs84wQP0?=
 =?us-ascii?Q?ew/nHB6YzGAHyK/1JypTFF+xFe9X+Z9YjVtt53aXMZnZ/nxjOBsTLuOX5k/N?=
 =?us-ascii?Q?CbcwmENs9dmsvntsZv1obQbMaztEKjEoIMJ/zEn8IJ5MvAvdC0ZgGB8zzFCx?=
 =?us-ascii?Q?J0hzY2smUF4UZd01md6NzMXsqLg9J5o0ALj14dDdC3V/FBNWijN5LAVI6EWx?=
 =?us-ascii?Q?97JSIAT5GfG36kRFnUQhMHdSuo2fNhGLH8QyKdYwv0Wl3xIKBls6RCcFfXzU?=
 =?us-ascii?Q?zJZIZgch+yFmwF2R2Zk5PVTqNsJIlHrE8C3Rs1blt+6wAzdSVtSuqFNrcz2w?=
 =?us-ascii?Q?mK5hKdc5rm4uGGwSYx9XaBTOdo3VVNEilj0UPK9nFyyvXbbd8BVlBtAem9f+?=
 =?us-ascii?Q?N4nkHrGvHzPAg0hsDuYzxucoouECegvDSCuRo2YGheZ3MoqZfkdxNcGbShpb?=
 =?us-ascii?Q?uEGT8ZLz0808nVrprc0ZX8kT3Y50f1CQVFdy82E3h6CVd/o5Hf18LZoCHlkg?=
 =?us-ascii?Q?jqDTjJzYDGU+F0863zlU21PEY+cSZVR5fHlfS2FIHHQhLYxvMBE+fpz96bMr?=
 =?us-ascii?Q?0GzBDSBC+DAlc2omU1il26OCPNygTkpLANWFgAawSex0+kbpo+AcyZO8QSPr?=
 =?us-ascii?Q?ndLOEXn3XEogLXQTV4UVXGDcq4b2zlphNM1bQg3yKciz+8/6nfa+IzTYpORI?=
 =?us-ascii?Q?W39LkkNqk0i22sXNYa7OLfZGnmR6mcABVu0wVX7c2YNiVwGKmHiulM9/EUeL?=
 =?us-ascii?Q?qPay+MSnkv9t3fIou/FFwnd6ukWVyDvdAOeAS46zdTZ2qktz4sactGTuyZFD?=
 =?us-ascii?Q?hlLOyoOj6upFjU2SWuHrF9ck9Cht1z+SZ3897WWCUUs2kmcLeQZBh0WVxVnr?=
 =?us-ascii?Q?ZoTCSM/yVXHzJB1uRLYcl4YDS04X+fwzVo4wobZlsVSsvGRt9r4fLPbb7j3p?=
 =?us-ascii?Q?HFWGccmYfOvD2BzBWj6Mme1zpOr0RStdei4gn/DLHaSLMt5BFYehViyFrPl0?=
 =?us-ascii?Q?VxxiwSUott0Yt0yDS00R3Abzw8F1lKezq2t9xXHhTc6UBKPRejk/BTzWezxd?=
 =?us-ascii?Q?7FMqkiCbxbp37U19+3YD0G4tXzp0QEFVZIrKUKp4BWA97HwcujMnSgr7CbEK?=
 =?us-ascii?Q?h+A9IFFSEWGORHWofO1P36HzJ10zut+A6swLedFsJtHemE09MGCjlVAhOdAA?=
 =?us-ascii?Q?0aomMpVsXwfzqSU8S4emVMnuUZoTCz4mZi89tbom22JNIJAMzk/WfTsTN70i?=
 =?us-ascii?Q?ejOIGfxQB0T40kbPrxryAKlHI21C8hVSR4NwXF9dBDlp3602uc43r/CFYpcL?=
 =?us-ascii?Q?uiByD2VZdUldS2bseNZsy34vRdAQEgqKKuBdbmKlP4xtymYLzI+HJnXIxon7?=
 =?us-ascii?Q?kDoYpu6SIm1RFPjP1WU6r8KF38DkoDG5sUCdv+4A2DYKNLmFKc7FX9iTqiJ7?=
 =?us-ascii?Q?hULf3bNC/Flppqi7zVJemudRBUndIgcYbUGbEXENtLvEmXdRcKAid+bBoLSl?=
 =?us-ascii?Q?ns95a5F8fhi0xtnyTcGj+Lqy0Gx/ttPexLFgQCaRcrprM8mpUs944sTVCb5h?=
 =?us-ascii?Q?25yQFsipy3aTH5q4Z84EGu+C6Zk7QRE=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8ab40420-7a50-41c0-3efd-08da4daaace1
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2022 02:07:46.7974
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: di/CfnGbg8fI4khJrXNBU4mQnsY+s5UsFtfMFpbHDoRqyxCxkbE75YMkj6iEFRD5oVc/vKMIz3Q24IVdwmDF3+a2rUoqZuiud9yReNxKp7Y=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2251
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-14_01:2022-06-13,2022-06-13 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxscore=0
 mlxlogscore=942 suspectscore=0 adultscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206140007
X-Proofpoint-GUID: BAU0R1xAkfb-l4N9uZ57kl8MyLMv9wT6
X-Proofpoint-ORIG-GUID: BAU0R1xAkfb-l4N9uZ57kl8MyLMv9wT6
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Yang,

> Fix following coccicheck error:
> ./drivers/target/iscsi/iscsi_target_nego.c:831:13-26: ERROR: se_nacl is
> NULL but dereferenced.

Applied to 5.20/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering