Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e0eb26ab-7c57-6df6-a2ff-83c84ab145a8@oracle.com>
Date:   Tue, 14 Jun 2022 12:31:59 +1000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PATCH RESEND v4 1/4] kernfs: make ->attr.open RCU protected.
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>
Cc:     viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
References: <20220602063907.136569-1-imran.f.khan@oracle.com>
 <20220602063907.136569-2-imran.f.khan@oracle.com>
 <YqYpTShTDLvAp4vx@slm.duckdns.org>
 <6d1c5a49-fc16-5fc7-e527-8cb91ec0d25c@oracle.com>
 <YqalHuEB6OjjUosV@slm.duckdns.org>
 <c8a8a616-da4c-f2ce-0bb2-e0cba69db24d@oracle.com>
 <Yqaqbas1JaWz25jB@slm.duckdns.org>
 <61868aa1-6c88-ecd2-beb2-67b87673b805@oracle.com>
 <Yqd0OJupifpplENB@slm.duckdns.org>
From:   Imran Khan <imran.f.khan@oracle.com>
In-Reply-To: <Yqd0OJupifpplENB@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGNDd1UxcVBhWDBkdVBVT3RESjNKZnRwQm9GNXZtdWpQeFpGYTd1Y0ZKSDRV?=
 =?utf-8?B?dTlJTHMxREJiMUVBNVI0N2FHK2IzQStjZi80cHJjMXAzb05xUk9JRDc1YUY4?=
 =?utf-8?B?dnBUWDdZOTZidGxVQ3N1RlNGVmVyVjdRK2NiNmJlYkNLeXl6THJUTkNjOGFV?=
 =?utf-8?B?NEt4S1pFOEVSL1RXQ2FJV0hETmQ4dHRCK1MzcDF4NHByb2RSOEUvTlJoQmpq?=
 =?utf-8?B?QXVUK3Zpa1FPc1BRcG5kUFFtei96Sk1zMTNhcTdBb28zeHREZE4vYU1kSGMr?=
 =?utf-8?B?S2lBSjVaaFZmd2pldjA1cnZlQ1pFS0k3cTl2emNqL09qbWNPOGRoeHZwdEx0?=
 =?utf-8?B?QnZFWnBJSEF3WG1ENTFDTk4ydkJmNmRXWG50d0w3dW9lcHQwbW41VTZtckhZ?=
 =?utf-8?B?dGNNdGFqOGdlRUd2U3dXRmhOTEFBMnl4bnVtWFlucTJ3bW9iOXlTNXcvUXJu?=
 =?utf-8?B?Y1FPKzNqN0F0c3oxMjVMWDU5U3ZVMEpuRDgzeWJwSHBvZEUzSFNYejRCNExM?=
 =?utf-8?B?d09RajVZY1lsbEw3M3UvcFM0WE05WVU5WTY4UVNuWUNyRWZ6bnRRbEF5VW1R?=
 =?utf-8?B?WFU4OE1WeHVoZm9pRnFISGdWYUVIK1BNVjVYN3VlTXBzQlUvUzNHdmQwZ1o4?=
 =?utf-8?B?bHkxQXl3NjJVSlJhelRhM2NPdWtkVTBpbStEWTh3RENJbThvOGJIVXBkeVFx?=
 =?utf-8?B?ZVp4bVphNHRkSlFiellHTTVMQThrdVV0RHhBeXMzYXFVU0dkMFJ3U3kvQVZn?=
 =?utf-8?B?TDdHeXZ2MGtvLzBsRGFOam8yMy9LOTZCRmwycUVmNHRIV2tZeFRkc24wUXg1?=
 =?utf-8?B?MmlUWFBvRk5NVUZNZGRXdVFXbmVtYnE4Y1NERTZnWnNxMFNBM093M21NdnJN?=
 =?utf-8?B?ekx0elFsZDM0WHZ4Zlk0NDMrY1A1aFoxcTc1UDZkVFRmSG1yRkdaekcyWC82?=
 =?utf-8?B?UDI3Z2pXR1BReDBsOHZpQzlmQjk3QVJBNTF6bzMxRkpNaHAxYU8vb1g5eFJN?=
 =?utf-8?B?Z1lYZGdwMzk0eG9kUmZJQ3IrWHoyand5WVQ4SXlZRGl6TlB1dkROeXlTOVBN?=
 =?utf-8?B?bVdPUHkzZVA0Q3U3Unh3bzdWeVJlWTJVTExtc0xUd3hPZ0VXZFllRnJGQ0J5?=
 =?utf-8?B?QjRqRmEwWTZ4K0JmaU9uR3daQWdNSTVjdDg5Q1BtUHg0Uk83akw2OTRJZHhD?=
 =?utf-8?B?MDFvZ2xXQjZMR0NBSVVQSjNjc2pPQlFCQlp2bDVIS3dMTmlvT2RIcFo0Um5m?=
 =?utf-8?B?NnJsZHVuL2EwMXNFYktHT08xM3daQjdFd2pYcTg5NzZINDFmRzd5S0tYOWZS?=
 =?utf-8?B?YUdqMjBicDk1a0FQWDY2aS9pZ1RJZlphc042aTJ5VzZpWHUydlZOY245QWJM?=
 =?utf-8?B?OTNqelZHQ3M3c2syVHBYb1FwMHBvVjBLQ3IzZ24yTjZFNG9kNEdwQ0J1Z3J3?=
 =?utf-8?B?U0hrSGJFcXF0ZDlLTDlFOE1PK1dyYjlid3pWUFlkOVJTbnlPUVRaWDNzc21B?=
 =?utf-8?B?NzFZcjAwM3l1K1dlS3h6d1BxT0pWdmNGRTdhWi9tLzFXWnk0Z1d5ZGc3ZEtC?=
 =?utf-8?B?QW56VXVXOWNWUFBmR2N1OVRPUDJnbU5tWHB1cENyeXJzUXZyc0ZUTFhhSlRP?=
 =?utf-8?B?dmVnWnU4YXBJMk5tMDNLQ2hxWGM1Rlk0RkFVcXhvQ0ZoVjNyMFN2T05YOTJR?=
 =?utf-8?B?REFjcE5udXY5Misvd0MyRHZUWWxmME05M2Y1aXAwckN6cGNJNUlLZ2Rpano1?=
 =?utf-8?B?VkZWcXNXWmhnaUl1T05mc0tXNHk1U0xic1l2VitOc0JJWjFBWHZmTXhHTWRE?=
 =?utf-8?B?UkdjMHJacnVMOXdBY3EvWHV1RWxjYXdJMVRoUVZCa0JRckN3MFoyQml5aDI2?=
 =?utf-8?B?QkkxM0lFYnFxa3phUTcwVmxSNUpPUlZ5dk1FbWMxVzZkZ1phSVZKQVV0WUlW?=
 =?utf-8?B?M0Y4MVMwVjNpZ0JQT1Vaa1FYaHRjUTkyemdhT1pMNFVlK0ZtODVtOEpIWHQ5?=
 =?utf-8?B?Sm1pSG0ySUF4VCt2QzJoOFJZbmpwVkpSWFBaTVFjVlY5cHFhNHVmMWpTZXFw?=
 =?utf-8?B?NjhEVUlNYzY0UDdHRHBreld0MnA0UVM2V21DN2t0WmtmcU9meWVKVzJXVHdm?=
 =?utf-8?B?emZCeFEwZTRLQUlVZ0V4cmpFbnJwSGh5SXdQd2NobUE4MTZpRDBsVWFWTWR1?=
 =?utf-8?B?cjJoaTU0Z1owTWZiUEt6dWNiNjBzcXhENEw2a3A1OU1MQWJCVGpEc3ZjN0lB?=
 =?utf-8?B?TUpUY1p4b1FvQlREc2I3OHYzcmlSay81TVFsTkMwNnU4NVduelBTa21NbmRt?=
 =?utf-8?B?c1ZSU2tMRS9wTS9jTDdnVGlnT25PR054UWdOYlRtUWpOKzhLOEZ1b0h0TVhp?=
 =?utf-8?Q?2o7J03poEDnxuJFM=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97d9eff1-09dc-4b62-2dcc-08da4dae1159
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB4479.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2022 02:32:03.8457
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MOWexVVcXOPPJCahtGDV0L+uxBZCJgth8/36HY2SJGKRJdSR0dM1K7DciW90fK9z322LL6m5urJvlmXkys5UJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5718
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-14_01:2022-06-13,2022-06-13 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 malwarescore=0
 suspectscore=0 mlxscore=0 bulkscore=0 phishscore=0 mlxlogscore=891
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206140009
X-Proofpoint-GUID: nLr2YAgwJGE_9PTzgFNwqtEr6n8zIKCV
X-Proofpoint-ORIG-GUID: nLr2YAgwJGE_9PTzgFNwqtEr6n8zIKCV
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Tejun,

On 14/6/22 3:30 am, Tejun Heo wrote:
[...]
> 
> Just merge all three into one accessor. You can list both the !list_empty
> condition and lock held conditions on the same rcu_dereference_check() call.
> 

I have all merged all dereferencing into one accessor in v5 [1] of this
patch-set. Could you please let me know your feedback ?

Thanks
 -- Imran

[1]: https://lore.kernel.org/lkml/20220614020840.546013-1-imran.f.khan@oracle.com/