Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5c4e116b-c710-9978-a370-853aaf57225d@amd.com>
Date:   Mon, 13 Jun 2022 23:02:25 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [PATCH] cpufreq: amd_pstate: fix the highest perf query for new
 AMD processors
Content-Language: en-US
To:     Perry Yuan <Perry.Yuan@amd.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Jane Malalane <jane.malalane@citrix.com>,
        Kim Phillips <kim.phillips@amd.com>,
        Tony Luck <tony.luck@intel.com>, linux-kernel@vger.kernel.org
Cc:     Ray.Huang@amd.com, Jinzhou.Su@amd.com, Li.Meng@amd.com,
        linux-pm@vger.kernel.org
References: <20220614035229.170852-1-Perry.Yuan@amd.com>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <20220614035229.170852-1-Perry.Yuan@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enBZb0M2cjFCVjR6RWUzOEVkR2NRUVY3UG9PNWJKSTRqRCttWXVkR3orSzYy?=
 =?utf-8?B?WUcxRTczZi8zUUVMYm9EUGcvSUJidU9SRmErcW5MSVNiZEY0UlNSY3E2b3NY?=
 =?utf-8?B?UnlRMlZmNlJVS21BaXF5VmxJMnBHMEtXVW1sTFhHb0RVd3VhK0g1S3FKNXB1?=
 =?utf-8?B?RUJpdFc0M3hvNFJJQlp6Q3VXbG1WS2IvMUNtT3hwcWZlZVpobHdmelYvRjVs?=
 =?utf-8?B?U3Nmdm5EQ0k5dTRyRDRLcHhtQk9KTCtVSnhsQnJZU1lNWWRleklvNFg1dVJz?=
 =?utf-8?B?QmtLZ2lSVnV2ZWtFaU00WG1pQ2UwOW5sa0x1azM1LzFzMjBGdmtRcXRuQlNv?=
 =?utf-8?B?Vm9PcStrRGx5YVUra2xFTjg5SWpQM2czRnNhMTc4YklHdllmTFhSMXdXekQ2?=
 =?utf-8?B?S3FLUnlKekJEL0RicG1nMklReEZqMzkxVjAvdjBGTkVJUmM4ZWRJTGZZN1VS?=
 =?utf-8?B?L1RsN29jYkRsd1FyMEF1cUp3ejVUaTl5ckprMGg5R3A3VWVYblltMVk0YXp0?=
 =?utf-8?B?bVZzdFB4TTFudmdLRGNVZFk5ZzlBR2wvaVJ3SnBWdG56WFhVTjNQSGN5eHpw?=
 =?utf-8?B?bGViY1pnU3J0VjFkVU4wSXMrYTlMUnFLSllta0RXYmNySC9iTlVDZFJTVVNk?=
 =?utf-8?B?WVNqU0ZnUjd5c0RTQXo1VkJkbG5BZzltL2dLMHI3aEYvZ3REMXVzRXozN0Y2?=
 =?utf-8?B?akNwM1ppYzNVOU1EdTdtdFVBK21XMXVablkwWG1ZOFFySjE0dkFuWHJLMWp5?=
 =?utf-8?B?NVdrVHVGbVdvVXRFS01lMTg3MG5XdWc2VDVhVnl2MlFEZFlvSk1OdXkrK2pL?=
 =?utf-8?B?QUtSL3RhczNveHRLVGNqRzkzRDRwRTRHU1FXV1ZMUGRqZVBhcUtlSHdaZmRJ?=
 =?utf-8?B?b29NM1IrZEtEUTdFcThwUTFKejJOUWc3MXp2L1ZKTW51U0t2MUZjR1JlbkZ3?=
 =?utf-8?B?K2FvdzIyemJTd3AwcStGbjNEcjFscEpUK1lHMDR3V3F5V2t3YmNCMTJXOHVq?=
 =?utf-8?B?MnJZRXVsUXJ5azFXNEc5dlByQjdKZFBvYU5TRzZUdDN4anhJd2h1UmlUZkNT?=
 =?utf-8?B?QlFhT21BZXBJNDlQblZlL1huZTB6b0xPTjRrQ0xpVUk0dWhaMGwvUDR2L0lG?=
 =?utf-8?B?MnVoRWxPOTZxdEV5TFhHSVJwNG0zZGp1SjRjNFJpV2tBM2NWUndJZDZPZVdv?=
 =?utf-8?B?MlhYYkFQcFdPeHlqM1lCdktkbkJ2UDRNZVBjb1JuTThBTEdIRXl5TEJCOUF3?=
 =?utf-8?B?R25CR20yenpaNFpWeEk5RlhCU3o1YndwaTl1eERoTGo4VkdoSE5MRnJFVTZp?=
 =?utf-8?B?TWVWa1lHR2dTMjFWajFyOXQyUzVFeUFFY251VHppWVNLSE5tMDgybk5VTkFo?=
 =?utf-8?B?ZjN3SWJ2bmRUem93dmt5TVhHMnRvMlgxZitScUp2UnJCOFJ0ZU5HRUlsWkNT?=
 =?utf-8?B?UG85RVIxSkRUdUNBcVNlYVNVV2JheitzT0x3Y3l1dXpJSDlHQlRmeTlaYkNj?=
 =?utf-8?B?cmtoL3RrTzVzTVJ6a0Vtb1FMdXUxNU90TGlZVE1oTTlCczhVYWdWVmlqQVBu?=
 =?utf-8?B?czkrV1NoTkp3cnh0bWJScWdURVl0cWpQZURkZmFBZENYOW1qRWk2cmpKV2sw?=
 =?utf-8?B?TW5HWlZTTmVPQUpDeE96RzRvRGZqQU94bStGVUhneHRXMllBZHQ5cXUrbnpu?=
 =?utf-8?B?MUxJU1pnZDhxQncvK2ZSenl1VlUvNTFNTFFXampaR21LMlFJQW85RzlsMW9i?=
 =?utf-8?B?RlBKUVNWZ0kveWkvODFKMlVUdFo5UU4vZC83UFUxQnhSWURZZkJpZ1RSalk5?=
 =?utf-8?B?OThjcmlCYVhiY0pPY0g4NkhFYTF2MGhldWNKeEYzZ1lFaDdoYlkrcjNpTEl5?=
 =?utf-8?B?RUlReW5zOURyOTZCZlFmTC9TeE12MFRKRHVlREI3dXVtUzBqb2VRdjdXUU9l?=
 =?utf-8?B?c1YxOEdWVWRWaEQ4UDVTd1VLWTI1cXNHUWFYZHJSa3V4N1RwOVQ0U1o0TEcx?=
 =?utf-8?B?S2lyMmM3M2RPZk1YZFhhSW9RQ1RRanRjYlBnNG0vb01vRDMyM1pjcE1tM0hh?=
 =?utf-8?B?MlZGTVM3Snd2cHpGNXQwUnpUbkNoN1JoY3lZM3FHdHc1ZjlkcWlpSE1SOWUz?=
 =?utf-8?B?LzMycXF2NjFlak1WTmdLWFc4T1pxazVTdE5sZHloVmhydmRTNVJxTWd6T1Rz?=
 =?utf-8?B?d3pkUTFxRG5wM2t1RkduNHVaenFFM2FINUJrb3E0SkxnNmowS1E0ZGRwVWpp?=
 =?utf-8?B?TUhYVWY2djg4dmpMYmRWWW4yOXV1THFyYnpTR2dGb2RpWjlRTm01REQwYXFK?=
 =?utf-8?B?L2t3WmhRdG1aRXlVcW1EY0FhdXVrQ2VjWk43bTl2UVY5TTV1ZkFYQT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 18fb4546-36c1-47d8-356f-08da4dbaaed5
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2022 04:02:22.0541
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RvtPXC/ZAzFAXK/ujd3LuSANVZndu4xLK6Ca++xi8mcFqNgIi5XovY70VBZl07gQ50WHWDTubSXBGS1jJBKNoQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4990
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 6/13/22 22:52, Perry Yuan wrote:
> In order to get the corrent highest perf for some new AMD processors,
> the amd_get_highest_perf() call will check the CPU model and
> return correct highest perf value.
> 
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

> ---
>   arch/x86/kernel/cpu/amd.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
> index 0c0b09796ced..ff2075f26ef4 100644
> --- a/arch/x86/kernel/cpu/amd.c
> +++ b/arch/x86/kernel/cpu/amd.c
> @@ -1152,7 +1152,8 @@ u32 amd_get_highest_perf(void)
>   	struct cpuinfo_x86 *c = &boot_cpu_data;
>   
>   	if (c->x86 == 0x17 && ((c->x86_model >= 0x30 && c->x86_model < 0x40) ||
> -			       (c->x86_model >= 0x70 && c->x86_model < 0x80)))
> +			       (c->x86_model >= 0x70 && c->x86_model < 0x80) ||
> +			       (c->x86_model >= 0xa0 && c->x86_model < 0xb0)))
>   		return 166;
>   
>   	if (c->x86 == 0x19 && ((c->x86_model >= 0x20 && c->x86_model < 0x30) ||