Date: Tue, 22 May 2007 15:05:04 -0700
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: "Antonino A. Daplas" <adaplas@gmail.com>,
       Jesse Barnes <jesse.barnes@intel.com>, linux-kernel@vger.kernel.org,
       James Simmons <jsimmons@pentafluge.infradead.org>
Subject: Re: [PATCH 2/2] make fbcon unregister when unloaded
Message-Id: <20070522150504.b797213a.randy.dunlap@oracle.com>
In-Reply-To: <200705221444.52675.jbarnes@virtuousgeek.org>
References: <200705171423.46748.jesse.barnes@intel.com>
	<200705171532.28799.jesse.barnes@intel.com>
	<1179444190.5092.4.camel@daplas>
	<200705221444.52675.jbarnes@virtuousgeek.org>
Organization: Oracle Linux Eng.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1734
Lines: 51

On Tue, 22 May 2007 14:44:52 -0700 Jesse Barnes wrote:

> When unloaded, the fbcon driver should unregister itself from the VT
> subsystem using unbind_con_driver.  This patch makes it use the newly
> exported function to do just that.
> 
> Signed-off-by:  Jesse Barnes <jesse.barnes@intel.com>
> 
> diff -Napur -X /home/jbarnes/dontdiff --exclude=Makefile linux-2.6.22-rc2/drivers/video/console/fbcon.c linux-2.6.22-rc2-modesetting/drivers/video/console/fbcon.c
> --- linux-2.6.22-rc2/drivers/video/console/fbcon.c	2007-05-18 21:06:17.000000000 -0700
> +++ linux-2.6.22-rc2-modesetting/drivers/video/console/fbcon.c	2007-05-22 14:26:20.000000000 -0700
> @@ -2937,6 +2937,21 @@ static int fbcon_mode_deleted(struct fb_
>  	return found;
>  }
>  
> +static int fbcon_fb_unbind(int idx)
> +{
> +	int i;
> +
> +        for (i = 0; i < MAX_NR_CONSOLES; i++) {
> +                /* Assure we do not unbind other drivers */
> +                if (idx == con2fb_map[i])
> +                        /* can be optimize to minimize multiple calls to
> +			   unbind_con_driver() */

			/*
			 * can be optimized to minimize multiple calls
			 * to unbind_con_driver()
			 */

> +                        unbind_con_driver(&fb_con, i, i, 0); 
> +        }
> +
> +	return 0;
> +}

Lots of whitespace mangling there (mostly spaces instead of tabs).

> +
>  static int fbcon_fb_unregistered(int idx)
>  {
>  	int i;

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/