Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 14 Jun 2022 09:22:37 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Dario Binacchi <dario.binacchi@amarulasolutions.com>
Cc:     linux-kernel@vger.kernel.org, michael@amarulasolutions.com,
        Amarula patchwork <linux-amarula@amarulasolutions.com>,
        Oliver Hartkopp <socketcan@hartkopp.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jakub Kicinski <kuba@kernel.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 13/13] can: slcan: extend the protocol with CAN state
 info
Message-ID: <20220614072237.d6crkhtqmbgjlw4e@pengutronix.de>
References: <20220612213927.3004444-1-dario.binacchi@amarulasolutions.com>
 <20220612213927.3004444-14-dario.binacchi@amarulasolutions.com>
 <20220613073706.rk3bve57zi2p3nnz@pengutronix.de>
 <CABGWkvqb3VHEMUaRsxcdL0+85hOSwJAtYWq+JskQ3KG+Hnca5g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="6ycy5ldwkhbkgvki"
Content-Disposition: inline
In-Reply-To: <CABGWkvqb3VHEMUaRsxcdL0+85hOSwJAtYWq+JskQ3KG+Hnca5g@mail.gmail.com>
Precedence: bulk


--6ycy5ldwkhbkgvki
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 14.06.2022 08:29:57, Dario Binacchi wrote:
> > > +     cmd[SLC_STATE_BE_TXCNT_LEN] =3D 0;
> > > +     if (kstrtou32(cmd, 10, &txerr))
> > > +             return;
> > > +
> > > +     *cmd =3D 0;
> > > +     cmd -=3D SLC_STATE_BE_RXCNT_LEN;
> > > +     if (kstrtou32(cmd, 10, &rxerr))
> > > +             return;
> >
> > Why do you parse TX first and then RX?
>=20
> Since adding the end-of-string character to the counter to be decoded
> invalidates the next one.
> If I had started from the rx counter, I would have found the
> transmission counter always at 0.

Thanks for the explanation.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--6ycy5ldwkhbkgvki
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKoNzoACgkQrX5LkNig
0117wQf/StmunxwhYlB9+A2hn7jBIh3c9dpjj8trKdaPs90i/hSL9awW0mAxFOOp
xy9qN4B3nWyl2lK3sJAEQgRPEJgmvybSP2hqh7+jS8lxsyIEtOIn37nyn/ZpwLrD
actsLV/9Nml+3JZcqss1hgF3fu6WMzpy+fuvokqps3wwU7nDA6CzJLfVBSCDHMQq
iTlsqQWV06RugoXVwDAeR/IznLVkXXJGLQM7YL2i1zxwMU1NUwQHyz/gFFcwkMau
h3rjb22EaUIJqguYrzI6KNkeo0rbPrEkmUIjwfV+A/J2A7aQ328f/tuJlPS4lOnZ
/XS16dNKvjmrX4GoRbtXzvumwz8R9Q==
=xAw3
-----END PGP SIGNATURE-----

--6ycy5ldwkhbkgvki--