Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cb8e3574-31ac-b858-81db-2b86cb75b340@oracle.com>
Date:   Tue, 14 Jun 2022 17:20:23 +1000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PATCH v5 1/4] kernfs: make ->attr.open RCU protected.
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>
Cc:     gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
        linux-kernel@vger.kernel.org
References: <20220614020840.546013-1-imran.f.khan@oracle.com>
 <20220614020840.546013-2-imran.f.khan@oracle.com>
 <Yqf+J/P1/24i6rN9@slm.duckdns.org>
From:   Imran Khan <imran.f.khan@oracle.com>
In-Reply-To: <Yqf+J/P1/24i6rN9@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWVmT1ZrYWNsWVFKL2lDYVVTb2dDWWNNVUhMWElCaTlKUlo0NzhXNUY5NGdV?=
 =?utf-8?B?OEFzLzNWaU1tbXE4L0dORVNNMnlZK2JsUzlwTytlQ1owLzNtM0NJcU5vUUow?=
 =?utf-8?B?WCtFQkZKWnYvS09NbUlIbG14MVZGT0UrV01sVTQ2MkhrRi9GcitneVpPUDNF?=
 =?utf-8?B?U0wyelJEaVFuY21wNHN4VkwxS1l2dUZET0pzMWxQdzZkODk2cVFtOW5SWTlU?=
 =?utf-8?B?RmU4dWMxdDZteENXZVB5WW55bWZtcmNWR1NqTWp3SCtibHF5b0NtWXROTnBp?=
 =?utf-8?B?a3J5bGVleGFlWUUxK2hvS0c4SmRZVGtZRCt1WXJ2UzcrNHhiR2NZSmN2UDl0?=
 =?utf-8?B?eEwwTDVqZENHUlljR2YrNGNhR3NyZXBrMHdibVFTV01sUnFONE5MNTNER3hI?=
 =?utf-8?B?NlZHaURKQk1pWmpOLzFXVVkzb3A0Sy9Ya1ErMXR0Nkd5Sm9LL0lLcFZMTEZO?=
 =?utf-8?B?SmpCYkoySXRWYmZueUxlRmdoUnNBNjNBQ0JXQnpERHF3TVZFeHpXUEdUT08w?=
 =?utf-8?B?cldVNXFVRVgwSWYzOWxCN2pXRWlDTDIvU3dJOWlydzJIZnk4emo5NC9yMEtF?=
 =?utf-8?B?NVF0U05UU1FLNzg3SHVINE1TQnFBM29rVDgyWTRvbGJsZXRzSlF6WklPeGlC?=
 =?utf-8?B?R1B2UU5jZ01vamJURHByYVJSbWoydHRVQlNEc1NGQXBHS2pSWXRBbjZOQ1NK?=
 =?utf-8?B?OWhrN3pLMEp3R3BOMHgxdjdFUEVadGNCbDBuVjg0QmhsM0czczJ1WEQxQitz?=
 =?utf-8?B?blhGV0F1aWc1WXJBUDYzRTM4RzMrNVV2L1cyRWpkdzBySXp6bEsxRVZQOVlT?=
 =?utf-8?B?NzZ5NnlZY2hNYzBOR0hIaUc3WVI5R0lqZWJlU2pKa1NHWnFvdndObVAxWkhk?=
 =?utf-8?B?MU43bWJNd2JYSEpYWlpqMDYrTjVYdlJ1VDdJUmNpbjQwRXluWnozbTNBWmp4?=
 =?utf-8?B?Rm1MME8vbUJxNWtNVGllMnpyMnBCRWZndjB6MWxId1JsdVEvWGYvbHBaZnZj?=
 =?utf-8?B?dENiN0dKWStHNDNNanhvRU9QRUpWNVExbHNsOC96Ui9JM2dTbVdBT0lrZzRk?=
 =?utf-8?B?bXdORnJ5dndKbGZZZlROaTQ0ZHg2akhodTJoSENIZEtjYWwzLzVjcTZ1WnZu?=
 =?utf-8?B?Y1F4S20vMTg4TWQyVENMdlh2OW16eEZOSnFXTkJsUGM3cXhwS3hNNmhQZzVm?=
 =?utf-8?B?ZVRWNmlJYzkwakhHdWRwUWowVkxuWFdXc3pHSEpxUml4VmxCNGNGcXBPRXJm?=
 =?utf-8?B?UnRsaklacU1wSS9OTDFrVENNN2RZWDBYUHYxT3l0TDFkdWFKNS9BTjlwa2p1?=
 =?utf-8?B?YkMyTWZXZTI1Rm1pejBDSGEvMUtJRlJBekRTSlFJVi9XYi9rdEN2MGh4bzRt?=
 =?utf-8?B?VFFtZnJSVnRUVmgyYWVNRzd2WUdnTzlabFppMGZZQ3JnczJibVR4YTlTVGp5?=
 =?utf-8?B?Q3pMb0tpazB5ZmZROFZxTlFiZEM3dHJVcUJJMXdJVWdsT2tNRjVFTVd1RWFI?=
 =?utf-8?B?WTg4OG1ReGpibFBwNGhVWm8xRjNPL3RPWCtBNWxuR1ZqQWY5a0JlbTBpNHp1?=
 =?utf-8?B?S21YRllEUnpVWDNYQmtub2lCQWhtQ2h3S08wWnNzNUwzU2txVmtHWEtoNWRT?=
 =?utf-8?B?d2hZM083aytHc0k2RjRCQ2ovdk52M0kwaXgyaGhUbGZ1V3VMYmVzMmNmeC9F?=
 =?utf-8?B?OThWd2JyeUxWZXBBSFljRXBUdEY1L0FSU0YwS3VTRTlQdEtUR0RuY1hlL2ZI?=
 =?utf-8?B?S2FubHViMmVIbkdoZkN5ejhQRjdMTVZDZWFzUUhtSXVUeG5LVUtScW0zTHkr?=
 =?utf-8?B?dFozRTRNWDd5UEdiNnA0MmdEK2I5YTBmb0EyNUFkVkhZY2xBWjMvN1VDN0ZT?=
 =?utf-8?B?Zld5WnA4VldObkpMZURmaE5YdVNWT2xoSGY2UVQ1TmloYTdWTDJJWURMeFBG?=
 =?utf-8?B?N0NDZkk4R1MvR2lMT093ZEdQU0RxVjFkMENBTmpGVzU2ZFI1bVRzMU9HVGFt?=
 =?utf-8?B?MCtSeDEzTzhFcU1WY3VLMnBsQWI0c0ZUZGhIR0s0TS9DSzVFVW4wZGpiTEgx?=
 =?utf-8?B?eHNDdEhwV1hyWTVMMXVMdkxYcmZFTGVObVRVdmw2U1BJRTMwWElhb3o3TW81?=
 =?utf-8?B?YThaSkY1VXcwNDBiZW1YcDJZMkdTSCs1YTRFYTVhWnUxRW0vT2ZLdVlFdkdX?=
 =?utf-8?B?bVVCQS9wRGRhdEswQXQxZzBUMTBFWGVXNDJHZWM1TmZJREpBU09NQzNNdXVG?=
 =?utf-8?B?L3dYQ3FNdTlIWnRwOTNrT2c1QVUxY2MyQlZVOHBYbHk2bHFJSVpUZDNIL1Fw?=
 =?utf-8?B?czJYZGZUMnNpWnNDSXNSMVYwK1c3TDcrSlJ3M2Rsa2t6ZFdMMC80ck1vSE1q?=
 =?utf-8?Q?uQeN8ZesevIaSwso=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed450203-d4b8-4325-741b-08da4dd65d81
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2022 07:20:31.6888
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rkqnMY/ZWm0PjbZM1z7nLV45QA62/gj/J7leIChbYIWRpFTeOK5XJmj1XR7Dq7ocYUW869SQfC3m94EbkLg3EA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5571
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-14_02:2022-06-13,2022-06-14 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0
 mlxscore=0 suspectscore=0 adultscore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206140028
X-Proofpoint-GUID: vpfnSBiP1uttOJLNXpXU7BR_s9lrMjJV
X-Proofpoint-ORIG-GUID: vpfnSBiP1uttOJLNXpXU7BR_s9lrMjJV
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Tejun,

On 14/6/22 1:19 pm, Tejun Heo wrote:
> On Tue, Jun 14, 2022 at 12:08:37PM +1000, Imran Khan wrote:
>> +static struct kernfs_open_node *
[...]
> 
> Hahahaha didn't know they'd be taking two different arguments. Sorry about
> the many iterations but it'd probably be better to have two different
> versions for the two argument types. Other than that, looks fine to me.
> 

No problem. I have made the changes in v6 (at [1]) to make use of 2 helpers
based on the arguments.

Thanks
 -- Imran

[1]: https://lore.kernel.org/lkml/20220614070346.810168-1-imran.f.khan@oracle.com/