Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1247687iog; Tue, 14 Jun 2022 02:13:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIxFBrugloM8+sAqqM8RfqXtygoq1tMp63rYtrwsgiqo1aXE2dQFySM/H0e1d++7cipUG9 X-Received: by 2002:a17:906:891:b0:70b:c30e:c1f1 with SMTP id n17-20020a170906089100b0070bc30ec1f1mr3262217eje.733.1655198018833; Tue, 14 Jun 2022 02:13:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655198018; cv=none; d=google.com; s=arc-20160816; b=WiAPj95+Ao7RnID7XsSzHygb05IeSlUpGbcv819HCJlDkE8PO/j7fuiP0TcrKludT3 vefuvVJN0mCWVtn84khpfnoLlxqVbitKkotha4CWnE+1NQdPtxNYsUy60U+j9c84F9WF bzO3bUD+WsZ9bu9dDmhcJ5R2iD5cBgA1M9iNwOTjnN6W0z5V+FH1SclrWZdMkFo6ruCI y6tBraWm2sD8Grt8EOWQk0zkvblVasFg/7oqL37Tluk3dwpX1cGl3fHcr4wjEscSmQoK UQjbydkzEnWNa1qzaAI3X6dr6YrKYpJ/uoiJHArjWuU3FaWOk7p6xO33W5Q7Za2HeJDn V9MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=jcoprTcB5a2rP6ppNmvkHA9rkGWr2bc5LmQUsOMWapg=; b=WZ06rB6k2h2MXIL7aaoTQ3/FM6IuZmMNmSAjWgFFUrPVqtheZtCgnWria5LkDLw8F6 cTfPYZ18mtqHbiRJDPTHkSdnPnbBxaKJ4VTgIPA1iGswpdvZE9yNJOTClUwBJzCgeHew 41iNaA31ydslcofjAKLl4BBxprXVahps6ErNyPQ1B8sgWrlYuStT/XZ007uCUl8Ggp4R x6wWpp/A7amlgcpJqD5OZ0JVA3tLHIWr/VjZnmSt9YNE0xoHTp3JgRCxJmg8Ft3tNFIg cgiik1it2WX61lHiU7CJxeZJX7OVLHigvoXb/GjpVZjwiTzmctbQY7xL7Kn7/e74Ic3V 4enA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s29-20020a170906779d00b007121c97d1d5si11011201ejm.711.2022.06.14.02.13.12; Tue, 14 Jun 2022 02:13:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351948AbiFNJJ6 (ORCPT + 99 others); Tue, 14 Jun 2022 05:09:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242985AbiFNJJv (ORCPT ); Tue, 14 Jun 2022 05:09:51 -0400 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 933A84131B for ; Tue, 14 Jun 2022 02:09:50 -0700 (PDT) Received: from localhost.localdomain ([172.16.0.254]) (user=dzm91@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 25E97S3I029619-25E97S3L029619 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 14 Jun 2022 17:07:32 +0800 From: Dongliang Mu To: Larry Finger , Phillip Potter , Greg Kroah-Hartman , Martin Kaiser , Michael Straube , Pavel Skripkin Cc: mudongliang , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] driver: r8188eu: remove NULL check before vfree Date: Tue, 14 Jun 2022 17:03:30 +0800 Message-Id: <20220614090340.123714-1-dzm91@hust.edu.cn> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-FEAS-AUTH-USER: dzm91@hust.edu.cn X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: mudongliang vfree can handle NULL pointer as its argument. According to coccinelle isnullfree check, remove NULL check before vfree operation. Signed-off-by: mudongliang --- drivers/staging/r8188eu/os_dep/usb_intf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c index 68869c5daeff..bd1c8b4b5c4b 100644 --- a/drivers/staging/r8188eu/os_dep/usb_intf.c +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c @@ -372,8 +372,7 @@ static struct adapter *rtw_usb_if1_init(struct dvobj_priv *dvobj, free_adapter: if (pnetdev) rtw_free_netdev(pnetdev); - else if (padapter) - vfree(padapter); + vfree(padapter); return NULL; } -- 2.35.1