Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed9acc40-00eb-d2f5-f6a8-bf09cc8493ec@intel.com>
Date:   Tue, 14 Jun 2022 16:57:08 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.10.0
Subject: Re: [PATCH] KVM: selftests: Remove the mismatched parameter comments
Content-Language: en-US
To:     Andrew Jones <drjones@redhat.com>
CC:     <pbonzini@redhat.com>, Shuah Khan <shuah@kernel.org>,
        Sean Christopherson <seanjc@google.com>,
        David Matlack <dmatlack@google.com>,
        Marc Zyngier <maz@kernel.org>,
        Oliver Upton <oupton@google.com>,
        Ricardo Koller <ricarkol@google.com>,
        Wei Wang <wei.w.wang@intel.com>,
        Peter Gonda <pgonda@google.com>,
        David Dunn <daviddunn@google.com>, <kvm@vger.kernel.org>,
        <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220614224126.211054-1-shaoqin.huang@intel.com>
 <20220614074835.qto55feu74ionlh5@gator>
 <20220614082839.a5iqpk4td2allbwu@gator>
From:   "Huang, Shaoqin" <shaoqin.huang@intel.com>
In-Reply-To: <20220614082839.a5iqpk4td2allbwu@gator>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXQ3bk54V2lWY1RTbmExUm5iRXdyRkV4bzVIdHVuQ2ZhRk5KVDZKd3RESmFy?=
 =?utf-8?B?eWNqU3FMejB0dnBmaGdyN1pId3M5WmV6UmpuVUw2QjI0SzBpeUx0bmdaMVhs?=
 =?utf-8?B?ZkFHTGJ6dzVFTXVnYU9VTmhiOStZaHFtTkNIVmZGM09aQk9scUJ4bUlhc0N0?=
 =?utf-8?B?RHQyK1pyREdQcEUyclVHdUJhdEZEQ1VzN1JiUFIzY2xmaitxRnV3NmUyMlIr?=
 =?utf-8?B?ZFhIa3FKQ0hncDg5TTh4SzFzZFBUVFViT2dNL05BN3ZBLzhTdmlHVldJMHo3?=
 =?utf-8?B?NEwrVFFSUXBVOFlQamRueU5uN0EwN2VEMjdvZDEveGxEdDZnTzNSczRoUUx2?=
 =?utf-8?B?LzJYVE1WVU5uSEdhVzZQakowbDBGQzVtNFdKUUY3VGdCVThRa2JvcWNzaGxh?=
 =?utf-8?B?RDBYcnV3WngyYWw5Y2FQVDdEZS83b3FHK2wzWk9jSndkaGJRRG5vQitDVzUv?=
 =?utf-8?B?TVJlN2h3dVZBbEQwU0tGMmRGMko0RnI1d0ZTR1oxaVhNTmI0MC80NXFKcEhv?=
 =?utf-8?B?OGM0VTN3Y2tMYzhHak9kbTZ1eXBLYkhmMlZZTkZLM3pGcWtHSmpXNWt3Z3cx?=
 =?utf-8?B?S04xRURyZU9oT0tHT1lPV2xhWURrWkk4QmsyZmV1RTl2THRVMVRnUTlTN2ZF?=
 =?utf-8?B?TlE3eTZKM3hnd0huaDg2blRvL210SlBWZWgzRE5JWXpRazkzUkxkZ3VpakFk?=
 =?utf-8?B?OTNCN0kzTk1Ya1RWRFFqQlF1cmVvNThqWUg3V0ZCTW1VN2hST3I3bDAvdXdp?=
 =?utf-8?B?NlpiUXpwL2dEaDZWQU14cGgvbElieXhuelZ0UUVXYWM1eFNibDM0a1RiUXEw?=
 =?utf-8?B?ZGJxTk5mNGFJQ2lGYlU0MEpxRVVNeGZMYWZMOE1acHYrV2l4WWw1SWp2WU54?=
 =?utf-8?B?Znh3N0ROWGxaVjg2clJkM3A4MkNTK0lVMXpJY2w4b1h2TFRnd080VnFjdmkx?=
 =?utf-8?B?TFZaUnlCL2JobnU2MzVrN09IVHFQSTlFejVVWVZlM1QyREwxTFFZSmMyRXUz?=
 =?utf-8?B?bzg3dVk3Zy9DZ1hrMVhqZmx2bUV5ODd3a0dGRTR0U2d1YmNldVpOcXp0Y291?=
 =?utf-8?B?UzQyQTl1VHFXblM0ZitEczEydFo3UHJBcVlOUE9KWERkbElpQjUveWdjbmhr?=
 =?utf-8?B?TlZJODJ0MTNzanByQmo0WFYrN1p0dGNTS3ZEZWdrWmlqWHlBTjRKb2lWZWcr?=
 =?utf-8?B?MWJESVNEVGlFeFBZempGZWZmeWNRSFpnV3FScTN5Y251bHlCVStWUzlWakhr?=
 =?utf-8?B?TENVTTM4VXFyQ0lmQk5HUXhKN1p0V0ZBdUV2eDV6TDVaKzU3RU1TM0VzTzZS?=
 =?utf-8?B?SHdDOWpZeTExZXB2WDQ1aXJiV3k4enpKSVBydm1XcEhJWTBmZDcrVitCNzhi?=
 =?utf-8?B?QUc5QXloanlsWU1wb3RibFpIbXByTTJ5SG5SYVNwUlo4UkcyUHZETEpzNllh?=
 =?utf-8?B?dDEzSi9GMFpBOUNNYTVnaTJnQWg4UWpBY3NVeVNoUUUvVWJ3d3RkcjdCWWJN?=
 =?utf-8?B?VEprS3NIK2plMEFsTWhtNnV5U0NtU3c4eDJ3dU5OMjQra3VER3Zxc2JqTUlE?=
 =?utf-8?B?OEdpYlJwMW9ORWJHRUx0V1FQeDUyNHdCSmgrQmMwTHJHZHlQWVpTL2Qxa3Br?=
 =?utf-8?B?SWg0MU1uOUN5eG9LbHF2VG9tR2ZRNDBySGJaYVJhaUJRclIwMGlUbzJmaGYx?=
 =?utf-8?B?V1JaRERYeTQrQy9OVDZUbE5NUm4zWGRTUXFQU25zTm4vMTd1MjlEcWNpejll?=
 =?utf-8?B?WTFwdzZncTl0VktjVjQ2eVFrbGM3c3BRZ3pmaFhmaEw0aERSYUF5a0gyaU5M?=
 =?utf-8?B?aVRneXZiUDJIbUVMZy9FdmRVeWR4N1BDc0drVitXeUNXK0VPcDM1eGIwSXZJ?=
 =?utf-8?B?a3lOYytmckFLWlN0TFJKNU4vUXBlU2xMS2VwVHFwa2VVN2hDa2VDbUlSd1pm?=
 =?utf-8?B?QmNFYXpDbkNnL2tTVnpRaVE3NTV1dFNOMDF4Nzlsc2pCYUR3Wk5JQlBCUStJ?=
 =?utf-8?B?bllTQnliUFl4cEVPUmxZYVdRNXpRbEdyQUg0elFhYVJDV2VETk5hTEN1Tk94?=
 =?utf-8?B?REt0ZmV0Q05iQ1ZXUW5YdndHOGI5MEoyTjN2ZUlEcXNjYmsvVHhjcFpBcDNz?=
 =?utf-8?B?MWwrSzZHaHFYNFFkMXpCNnA0ZEhwS1BCUVgrTDVJbTFPRVUzekdaUE41eHQ4?=
 =?utf-8?B?Qlg3VnB3QVNCaSs2UDlEL0VoaDk5VWFVNTRtUTRHaDBXcjRRa2lTU0JVYkx4?=
 =?utf-8?B?cmxJWVd5SEJDekxROVo2aDloUlhHdDBkUDFxdUxoV3VacFJUS2JaYzFBU3hK?=
 =?utf-8?B?bGVYeXMxWWx2amFvbG4xR3FMV3VqRDF5UG83RXFtbDEwdzRhMERjOXVpZkwx?=
 =?utf-8?Q?tX1fGpYHEhmXrfJ0=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b40af874-a667-43cc-1735-08da4de3e47c
X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB3870.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2022 08:57:21.6348
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: svZRyrOgm9SQejX7YwtxpuadIo1dSZtHfYw27TyjWidEF01ZEKWKSOmiuHQujAusnu2pM/BCe3PRAvc9AQVCUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3144
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks drew's review.

On 6/14/2022 4:28 PM, Andrew Jones wrote:
> On Tue, Jun 14, 2022 at 09:48:35AM +0200, Andrew Jones wrote:
>> On Tue, Jun 14, 2022 at 04:41:19PM -0600, shaoqin.huang@intel.com wrote:
>>> From: Shaoqin Huang <shaoqin.huang@intel.com>
>>>
>>> There are some parameter being removed in function but the parameter
>>> comments still exist, so remove them.
>>>
>>> Signed-off-by: Shaoqin Huang <shaoqin.huang@intel.com>
>>> ---
>>>   tools/testing/selftests/kvm/lib/kvm_util.c | 3 ---
>>>   1 file changed, 3 deletions(-)
>>>
>>> diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
>>> index 1665a220abcb..58fdc82b20f4 100644
>>> --- a/tools/testing/selftests/kvm/lib/kvm_util.c
>>> +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
>>> @@ -1336,8 +1336,6 @@ static vm_vaddr_t vm_vaddr_unused_gap(struct kvm_vm *vm, size_t sz,
>>>    *   vm - Virtual Machine
>>>    *   sz - Size in bytes
>>>    *   vaddr_min - Minimum starting virtual address
>>> - *   data_memslot - Memory region slot for data pages
>>> - *   pgd_memslot - Memory region slot for new virtual translation tables
>>>    *
>>>    * Output Args: None
>>>    *
>>> @@ -1423,7 +1421,6 @@ vm_vaddr_t vm_vaddr_alloc_page(struct kvm_vm *vm)
>>>    *   vaddr - Virtuall address to map
>>>    *   paddr - VM Physical Address
>>>    *   npages - The number of pages to map
>>> - *   pgd_memslot - Memory region slot for new virtual translation tables
>>>    *
>>>    * Output Args: None
>>>    *
>>> -- 
>>> 2.30.2
>>>
>>
>> Hi Shaoqin,
>>
>> Please check kvm/queue, the extra parameter comments have already been
>> removed.
>>
> 
> Eh, never mind, I looked at the wrong functions. Your patch does indeed
> apply to kvm/queue and is indeed necessary. Sorry for the noise.
> 
> Thanks,
> drew
>