Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1272920iog; Tue, 14 Jun 2022 02:50:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyE5cBztt8TIzGsefp23dmGaL9BuD2kmO+JJmrzKMC9AF7D5UNaXJZ2+CwJ/t8/+KDG5WrV X-Received: by 2002:a05:6402:3224:b0:42d:e68c:2fd with SMTP id g36-20020a056402322400b0042de68c02fdmr4769664eda.282.1655200209331; Tue, 14 Jun 2022 02:50:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655200209; cv=none; d=google.com; s=arc-20160816; b=mQnP4zd42aOe11cedt4X5HbGQ9FG8pu4r3+JLq1v8H+EceJdw5PNkTKF2gBTb3ldoD dLelpF9J9/cWyhlaDHs3vOQkGixtcW20DYzD8r96UIkPpzBNpy+sG0b8eubqXOlq7YHr i9xEZhTN+epQwNadCvEPHW7EJPlL14wWLdDxkJPfsX2rCed4j7SzwDz11xzCLavveG1x zw96j5DxcrujVZdeEbNoz0hdfknVU0EHDeOT2Hb4WsgwDlw6RKOucBIeBu6eFLoHfiBc HbXZZI6O7yCl2fVjIT8+rx0wJDiwCEu5KrSx8p46iRK0RoNT+PoAzFYhFNIPTYW01Df9 7V1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-signature; bh=vfGVoS2BnDWtKRdT8RuI6+MnkzaFV7PnJBhEMAn+MJU=; b=pi0C54UUBsZlFLI/RzbAPTcgh9ddKPrlewAWnjOqMiTR8uYE23pIxC3lQ4SwJWm9Tz hbFDn8nQHc2/KCaix8QclM+9Yu2Ev0f2IoRAdQZ5ueDxWrkIQ0ApzaXyutoNYC8J1KMI SGdD8LWbPk+qYXxWNOeqovVqyXQbT3Zl9iPCkdRUr4zK0uZgW/MkKBnQmHkfV2pQifIG mmHqhUJYp4OA5jWpEJMpQY2cV6M7TKoinPkNV0lhES1jrBXH3rgoHDxAxke8rY9YspRe jXQ5eqTiyb6xsyuEMIROmd+Odq3L/ICsiTMConiZA/q9bBf9o6ig0U6jMGzzjAnAroDK ODnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=wRKjbEM7; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 9-20020a508e09000000b0042dd57df87bsi10955326edw.196.2022.06.14.02.49.43; Tue, 14 Jun 2022 02:50:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=wRKjbEM7; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232204AbiFNJF4 (ORCPT + 99 others); Tue, 14 Jun 2022 05:05:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239179AbiFNJFn (ORCPT ); Tue, 14 Jun 2022 05:05:43 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63F573AA4C; Tue, 14 Jun 2022 02:05:42 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 1C98021AF5; Tue, 14 Jun 2022 09:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1655197541; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vfGVoS2BnDWtKRdT8RuI6+MnkzaFV7PnJBhEMAn+MJU=; b=wRKjbEM7uoJnpP4TdIy3LPXGx3X2BLOiZnPG5+D80NVkIvq8xKHKKFkLbVoA9rvT+v4ED9 fML4F/4N0XDX9N2RShgFN329zaj73jd2QJ6b9sAiW0sJybhRfXlMrvmwx6OjULO+4wpXqh vWVX44UlzbQVtSisMP9p0rZ8J4LgQdM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1655197541; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vfGVoS2BnDWtKRdT8RuI6+MnkzaFV7PnJBhEMAn+MJU=; b=Zc9EKWv/rJZEnN8ev+iRCgZl+tBNLPnPR7cYhv6fFEXYz6RBIuS7ZoF7GBhfqrRex8ZyZL FMVY8cu4FXKTf4Cw== Received: from localhost.localdomain (unknown [10.100.201.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id E4E0B2C143; Tue, 14 Jun 2022 09:05:40 +0000 (UTC) From: Jiri Slaby To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Subject: [PATCH v2 3/8] tty/vt: consolemap: saner variable names in set_inverse_trans_unicode() Date: Tue, 14 Jun 2022 11:05:32 +0200 Message-Id: <20220614090537.15557-3-jslaby@suse.cz> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220614090537.15557-1-jslaby@suse.cz> References: <20220614075713.32767-1-jslaby@suse.cz> <20220614090537.15557-1-jslaby@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function still uses too vague parameter name after commit 50c92a1b2d50 (tty/vt: consolemap: saner variable names in set_inverse_trans_unicode()). So use "dict" instead of "p" for that parameter too. Reviewed-by: Ilpo Järvinen Signed-off-by: Jiri Slaby --- drivers/tty/vt/consolemap.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c index c5f5fa39d7b2..55fb466361c1 100644 --- a/drivers/tty/vt/consolemap.c +++ b/drivers/tty/vt/consolemap.c @@ -241,17 +241,17 @@ static void set_inverse_transl(struct vc_data *conp, struct uni_pagedict *p, } } -static void set_inverse_trans_unicode(struct uni_pagedict *p) +static void set_inverse_trans_unicode(struct uni_pagedict *dict) { unsigned int d, r, g; u16 *inv; - if (!p) + if (!dict) return; - inv = p->inverse_trans_unicode; + inv = dict->inverse_trans_unicode; if (!inv) { - inv = p->inverse_trans_unicode = kmalloc_array(MAX_GLYPH, + inv = dict->inverse_trans_unicode = kmalloc_array(MAX_GLYPH, sizeof(*inv), GFP_KERNEL); if (!inv) return; @@ -259,7 +259,7 @@ static void set_inverse_trans_unicode(struct uni_pagedict *p) memset(inv, 0, MAX_GLYPH * sizeof(*inv)); for (d = 0; d < UNI_DIRS; d++) { - u16 **dir = p->uni_pgdir[d]; + u16 **dir = dict->uni_pgdir[d]; if (!dir) continue; for (r = 0; r < UNI_DIR_ROWS; r++) { -- 2.36.1