Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1342412iog; Tue, 14 Jun 2022 04:20:33 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vzgFNWra9ToGfBQsqji559EHVtkZl02ZXWoVgUYh+BeoMRcOJmtm6WHXU+oI3wHs6060k/ X-Received: by 2002:a17:907:3d8a:b0:70e:76f2:eedd with SMTP id he10-20020a1709073d8a00b0070e76f2eeddmr3847727ejc.485.1655205632906; Tue, 14 Jun 2022 04:20:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655205632; cv=none; d=google.com; s=arc-20160816; b=z0IvkgdzxIkZy0r5Xz/gUwdKQC2lCFhGxMRNcZHakmI3RvWugIL1KzjVyumL0BO2CZ 0CUyApTq3msOW/2hBXfPtfmsU0bprwA24Xv3f2xWmyECp1EjmN1oWzZg8RnDwXe5BItN SFQgRPrKwhX5Rnu+WG093isAE7jBE8J7ZqJBle2Cmr5qya1ClIlI26McgYDBDKR0Pazx mbI9L97v+QeFIGKbZjlW41rPzB4Zn2BhsqgO5VkTmXvMSsI2ZovxUoiSLTLaWr13zf13 75xIlUrMsCkvr2Y4b/5aovO93gAYCYh+ynPxmt7Kq/2FhXP0R4psD8PfxCgD6lPXunS1 M+zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=h30HHa9jF+uZdIEOGOAgUHK0WvfWButVsj8i2bL6Vio=; b=I4ovLSBe8Yi95wtnC2FvpYNTdpEeSNzm8h2/AeCNyBbpyJ59Du6BdogeLAyNgdadXp y+3/9WNqvlx6NVrzX1IUnmcl/N3zl+8lNqtmqbqBqxb4bvmRLvaMXLHJOWvjTE2D6iy9 2uVo8VZNYwwAPntV3qIsqze/g+/zpARRUOcT5bg56oO44cEoPQLo6wUENfq1PrT/Svav QdWjHGTBjzTch+/QTsJJWwhn/uJjiC0KAeNMzYwyZpxa6oSpWutJhM7JWeUwUPtI5mxg U56YKGF6FcgfUBrTcMtRj/XhdcVr+Wzg9ZZFakX5edXqakhQDSaZKfen8FRzzZo1PnC/ y6BQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=Sh8gtiA1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb44-20020a170907162c00b006fde12d505bsi11792269ejc.406.2022.06.14.04.20.06; Tue, 14 Jun 2022 04:20:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=Sh8gtiA1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230312AbiFNKiQ (ORCPT + 99 others); Tue, 14 Jun 2022 06:38:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230157AbiFNKiJ (ORCPT ); Tue, 14 Jun 2022 06:38:09 -0400 Received: from out1.migadu.com (out1.migadu.com [IPv6:2001:41d0:2:863f::]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 973E62ED53; Tue, 14 Jun 2022 03:38:08 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1655203086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=h30HHa9jF+uZdIEOGOAgUHK0WvfWButVsj8i2bL6Vio=; b=Sh8gtiA1sKFv8/Ql9eFUL/Ok8GiV66l69lGl/WsbFhcgfTSJfEF3pdAfC9Z58sulDCO6nM p+t8pBlPRjZbRB9r689/7AwZHFTl2quBZBTHXx/rKSoHDnpdcazCvIHL8zRcZT2w8kOKhT sAAdyLrQyOBMOnUnKVSE1V2AnEyrGvg= From: Yajun Deng To: peterz@infradead.org, mingo@redhat.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, eranian@google.com Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Yajun Deng Subject: [PATCH] perf/core: fix perf_event_mux_interval_ms when set zero Date: Tue, 14 Jun 2022 18:37:51 +0800 Message-Id: <20220614103751.1395645-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: linux.dev X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The perf_event_mux_interval_ms is set to zero or one by default. It can't change back when someone changes it from zero to another value. Make perf_event_mux_interval_ms to PERF_CPU_HRTIMER when set zero. Fixes: 62b856397927 ("perf: Add sysfs entry to adjust multiplexing interval per PMU") Signed-off-by: Yajun Deng --- kernel/events/core.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/events/core.c b/kernel/events/core.c index 61ad10862c21..73c8c7462bbf 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -10954,9 +10954,12 @@ perf_event_mux_interval_ms_store(struct device *dev, if (ret) return ret; - if (timer < 1) + if (timer < 0) return -EINVAL; + if (timer < 1) + timer = PERF_CPU_HRTIMER; + /* same value, noting to do */ if (timer == pmu->hrtimer_interval_ms) return count; -- 2.25.1