Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e1703fcf-c5e2-70b1-cae2-30330108ad26@amd.com>
Date:   Tue, 14 Jun 2022 17:45:31 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH V2] selftests/vm: Add protection_keys tests to run_vmtests
Content-Language: en-US
To:     Shuah Khan <skhan@linuxfoundation.org>, akpm@linux-foundation.org,
        shuah@kernel.org, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220610090704.296-1-kalpana.shetty@amd.com>
 <8e7fca3a-096c-7d6c-e43b-9292995ab970@linuxfoundation.org>
From:   "Shetty, Kalpana" <kalpana.shetty@amd.com>
In-Reply-To: <8e7fca3a-096c-7d6c-e43b-9292995ab970@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXNYcmpIRUtrdVdRWW1SbUYrS1crQ3RjdENXS1pMUzIxdEU2bDQ4Z1BJa2xk?=
 =?utf-8?B?Z3hrSWwzQm40UUxhK28rREw1TlE3aXJIcGs0TUtFcmdpaWZLcDN1RFFjbmxR?=
 =?utf-8?B?Sk1POENtQSt6azJRNXpBbmdvZSs4ZHpXMmJMS3JLcEJrOVk3TCtGN1NHYlh5?=
 =?utf-8?B?bFY2RVhBRUl5elE1MnlCSENHS0FBNTRSM3hrd0hOM1VFNW9nS2VIOFNvNG4y?=
 =?utf-8?B?S2poTjJtUWlQaGJ0MzRHRGZ3N3ZEVWhoT0ZCUWoySElMRUpRcTJNUU51UHc5?=
 =?utf-8?B?Z281QjYyY0djbEVpWEtpQ1EvTmprQUxwUjRiUUFsY3hBZzZUemcxU0F5ekg3?=
 =?utf-8?B?NzgvNjJ0SVpoODRwV0tUajhwVnhTeHVSM0wxUkcwalpPcFZxaE9qNDBvTGxj?=
 =?utf-8?B?ckQ3OXVkY3F3ZnRycWhITVlRYnN5aWZEc2xHVmZwQWhIK1dxQzB5TmR2QmVh?=
 =?utf-8?B?a1NTMXVKL3RpYnRuZ0Z6aC9WbVFBcU9EQ0Uvc1VvL2t6Y2pCRjV1V3pCNG41?=
 =?utf-8?B?QUN4TDBLS05jLzhoazNKaVFaZGNvcXZmcXNsS3ZIOVJpVlVYMTZCd3pnTnNL?=
 =?utf-8?B?eGFpREI3Y3Uyb1RwRkUyNGVxT05taVpaZ1greHFQN2lxZGlValJxR05QWERv?=
 =?utf-8?B?dytCaUVYV0pUSk5rZ1pmcTRVL1JENXVLaVN2VWFLMXI3Z0tLVWxOM21JSzZX?=
 =?utf-8?B?YWlUcTdjNHVnL3U4T0ZEZmRKbk1obG9ZNWxZNmI2WUVMdmRBQzJoaVFpYUFZ?=
 =?utf-8?B?dHBQblVGRTRhMlRqZGZva3NDT0J2WU15YWN6em9yeTJ2TG53TmJDdlVkZGZE?=
 =?utf-8?B?TlFkQzN6WjJWVDRTTVRKTEowUmdIdU90VWJRMUpDNVVwNy9RV2dWODhzWFBm?=
 =?utf-8?B?V2FhYSt1K2FiL2lqbHdiai9aZ0loN283YkZjd3EyVys3SzBOdXZBMnJFS0NI?=
 =?utf-8?B?cndvd0pmajQxTVJLYytkbFFGODRzUkFRays0eFlKNGg0aDZ6M1ZLcElsUHBh?=
 =?utf-8?B?ZmoxVzRaczlhdEFZdEthMGl4dlZPaFBCd1pUMWw2dzNQazkyQU5rNjVTQndV?=
 =?utf-8?B?RXl1c0NRa3MzSy9qemtJNVdqVEczb3Jxbjl4NHhuMWhyamZCaU1ZTjF5Q2U3?=
 =?utf-8?B?cjFSekhyWW9zZjdPWTkybTNvMGdIUWNadDBSUTQxMDRmSktHODVRQjJDTjR4?=
 =?utf-8?B?VDdveVVnSlgzaFhNM0NWdElwY1N0VU5Sa05qcG1SV3ptZS9WVFV3L0tEQkZM?=
 =?utf-8?B?VHpTdG1hWXRtMXhmaC9KeWg5ejhjeUJLREpjMldoemdTa2JUTzl0N1NIWmFo?=
 =?utf-8?B?a0RLMC9LdFc1QXZKTCt0aUxkd2FORGxrWTdmTGdVeVBhODhQSFpxZDdRenV3?=
 =?utf-8?B?YTZlSjI1Z0gyMHFHeHB5YXBNejdLL1dabDZJdWF0RlVMUlh4dVNZblhyR3Uw?=
 =?utf-8?B?QWFxcS9uOHJXSU9LM0NFUDgyRTdXQjhTSHNLUExneXRSTHpnTE9YVHlacldz?=
 =?utf-8?B?WDZJbW4xM1pOd1BydytjL2ljcXdTNm9oRmFYZmZ5RGpnOVZHRUNFMXpJQUcz?=
 =?utf-8?B?MXhkVytuTm5KOGVtbCszR0RpUmN1dXRINndER2pqd2Rlc1JxdTVQVDlLL29K?=
 =?utf-8?B?WFMrYWUxVnoyWlQ1RVlMcU42NlpOcUFjbVIzanoxYUxXcnBqdXpaa3M0dy9o?=
 =?utf-8?B?L2E3aGxvQ2pNYzg3SWFndVpVcFEweWE3LzVxdWl4U3JURUhqMjhVMUYzODZG?=
 =?utf-8?B?TmpKSjlqem00M2tGbklsaW1aLzhjTnJoK3daTDZQL0tQMS9VMkFJc0hCU3h3?=
 =?utf-8?B?NHV4MHNJRHgvYjhhY21nRzhraG41b1UwK1hsd2RRR3FEalVBZmVxZmZzc1Mw?=
 =?utf-8?B?bnJvb2xvUXQvNTR1NEdGcktVU2pQOU5RWlBWM3hUZHhoRGRaRXlNc255NVhR?=
 =?utf-8?B?OUhNVHFLRGE4VzFZc2cveHkzV2RXeXZDUnFqUEJ4b2dBTWFyNUp5ZG5HYlVT?=
 =?utf-8?B?MUtESnV4UHZrYmdHYnJDVzU5NnpRQURtZjlmc1MzaXNqUWlSVHFUMUtERjFq?=
 =?utf-8?B?a2owSTZnaWR3djcvcHlZYnA0Z0xnRjh1Z1BPdDVFdW9ub0FYbTVCTTM5S1hC?=
 =?utf-8?B?ditwaHZXZEdwTVB4S1VrQlE5MzBMVWJwVzZic2pHUXhhaWhMcXlicCt6YVkw?=
 =?utf-8?B?RndOakpzYXd6ejYyMDh3Y0pFT2c0a2dRTk0xSStENFkxekpZTnRhM0NyVGJv?=
 =?utf-8?B?cFpXd2Vld3pLaHdlc2JkdjZDNjdBUEZuT0g1MG1WS1pBalA5cVpScnBkamho?=
 =?utf-8?B?UlliamhJM3pOdDZlanQxLy8wbGw3dU4ydmYvTGJ3a1paWHVnMDF5QT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e461d4ce-9ad9-409f-8584-08da4dffa012
X-MS-Exchange-CrossTenant-AuthSource: BL3PR12MB6449.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2022 12:15:52.7351
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sxTvmYFE3uPhm+aVcBLd80mxHzAhvUxZyDQxc+fpJc9aJ2WPMszsTSpoR4CMNB92rBalslr+78rkx/U2jA3xvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5427
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/14/2022 3:14 AM, Shuah Khan wrote:
> On 6/10/22 3:07 AM, Kalpana Shetty wrote:
>> Adding "protected_keys" tests to "run_vmtests.sh" would help out to 
>> run all VM related tests
>> from a single shell script.
>>
>
> Makes sense - can you explain why you can't just run
> protection_keys_32 without checks? 

Yes; we can run protection_keys_32 without check.


> Why are you checking for VADDR64? 

The check is added to ensure if the system is in 64-bit mode before 
executing 64-bit binary.


> All of this information helps us review the
> patch and give you feedback and suggest a different approach.


Thanks,

Kalpana

>
>> Signed-off-by: Kalpana Shetty <kalpana.shetty@amd.com>
>> ---
>>   Changes in V2:
>>    * Added patch description.
>>
>
> thanks,
> -- Shuah