Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Sender: Guenter Roeck <groeck7@gmail.com>
Message-ID: <d993bbb6-e583-5d91-76c0-841cc5da86af@roeck-us.net>
Date:   Tue, 14 Jun 2022 08:33:56 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 5.18 000/343] 5.18.4-rc2 review
Content-Language: en-US
To:     Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        torvalds@linux-foundation.org, akpm@linux-foundation.org,
        shuah@kernel.org, patches@kernelci.org,
        lkft-triage@lists.linaro.org, pavel@denx.de, jonathanh@nvidia.com,
        f.fainelli@gmail.com, sudipm.mukherjee@gmail.com,
        slade@sladewatkins.com
References: <20220613181233.078148768@linuxfoundation.org>
 <CAK8fFZ68+xZ2Z0vDWnihF8PeJKEmEwCyyF-8W9PCZJTd8zfp-A@mail.gmail.com>
 <YqgsDXdY3OttH8Mc@kroah.com>
 <CAK8fFZ5SP4zAra2X8B3Q9zkhQGMfif+y-oEvkpR4fDpL8_upKg@mail.gmail.com>
 <YqihnavPcyzMMw8l@kroah.com>
 <CAK8fFZ4JnhA3s8e4YDp_+GOq5+p4YzRtKdEFzjogtXc3EBttzw@mail.gmail.com>
From:   Guenter Roeck <linux@roeck-us.net>
In-Reply-To: <CAK8fFZ4JnhA3s8e4YDp_+GOq5+p4YzRtKdEFzjogtXc3EBttzw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 6/14/22 08:03, Jaroslav Pulchart wrote:
> út 14. 6. 2022 v 16:56 odesílatel Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> napsal:
>>
>> On Tue, Jun 14, 2022 at 04:41:31PM +0200, Jaroslav Pulchart wrote:
>>> út 14. 6. 2022 v 8:34 odesílatel Greg Kroah-Hartman
>>> <gregkh@linuxfoundation.org> napsal:
>>>>
>>>> On Tue, Jun 14, 2022 at 07:56:36AM +0200, Jaroslav Pulchart wrote:
>>>>> Hello,
>>>>>
>>>>> I would like to report that the ethernet ice driver is not capable of
>>>>> setting promisc mode on at E810-XXV physical interface in the whole
>>>>> 5.18.y kernel line.
>>>>>
>>>>> Reproducer:
>>>>>     $ ip link set promisc on dev em1
>>>>> Dmesg error message:
>>>>>     Error setting promisc mode on VSI 6 (rc=-17)
>>>>>
>>>>> the problem was not observed with 5.17.y
>>>>
>>>> Any chance you can use 'git bisect' to track down the problem commit and
>>>> let the developers of it know?
>>>>
>>>> thanks,
>>>
>>> I tried it, but it makes the system unbootable. I expect the reason is
>>> that it happened somewhere between 5.17->5.18 so I'm using an
>>> "unstable" kernel.
>>>
>>> Is there some way I could bisect just one driver, not a full kernel
>>> between 5.17->5.18?
>>
>> How do you know it is just "one driver"?
> 
> Just a quess based on "git grep". The error message was introduced in
> the driver in 5.18-rc*.
> 

The message was introduced with commit 1273f89578f26 ("ice: Fix broken
IFF_ALLMULTI handling"). Given that commit message, it appears to be
at least somewhat likely that reverting this commit will fix your problem.
I would suggest to give it a try.

Guenter