Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 14 Jun 2022 12:15:40 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Jonathan Cameron <jic23@kernel.org>
Cc:     lars@metafoo.de, linux-iio@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: dac: cio-dac: Implement and utilize register
 structures
Message-ID: <Yqi0LEbqiSCNxWS3@fedora>
References: <cover.1654118389.git.william.gray@linaro.org>
 <44aec703753f930cceff448babd1c8e2959eebb0.1654118389.git.william.gray@linaro.org>
 <20220614122618.68e2e9d1@jic23-huawei>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="M7k0kYrMKQquTa5e"
Content-Disposition: inline
In-Reply-To: <20220614122618.68e2e9d1@jic23-huawei>
Precedence: bulk


--M7k0kYrMKQquTa5e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jun 14, 2022 at 12:26:18PM +0100, Jonathan Cameron wrote:
> On Mon,  6 Jun 2022 10:15:18 -0400
> William Breathitt Gray <william.gray@linaro.org> wrote:
>=20
> > Reduce magic numbers and improve code readability by implementing and
> > utilizing named register data structures.
> >=20
> > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
>=20
> I'm unconvinced this one really helps readability seeing
> as you are only indexing a straight forward array.
>=20
> Simply using u16 __iomem *
> would provide the main cleanup which is avoiding the indexing
> via * 2.
>=20
> Thanks,
>=20
> Jonathan

I agree, that is a much simpler approach and reduces the changes we need
to make to this file. I'll adjust this to u16 __iomem * in v2.

William Breathitt Gray

>=20
>=20
> > ---
> >  drivers/iio/dac/cio-dac.c | 24 ++++++++++++++++--------
> >  1 file changed, 16 insertions(+), 8 deletions(-)
> >=20
> > diff --git a/drivers/iio/dac/cio-dac.c b/drivers/iio/dac/cio-dac.c
> > index 8080984dcb03..7860450ceaf3 100644
> > --- a/drivers/iio/dac/cio-dac.c
> > +++ b/drivers/iio/dac/cio-dac.c
> > @@ -16,6 +16,7 @@
> >  #include <linux/isa.h>
> >  #include <linux/module.h>
> >  #include <linux/moduleparam.h>
> > +#include <linux/types.h>
> > =20
> >  #define CIO_DAC_NUM_CHAN 16
> > =20
> > @@ -34,14 +35,22 @@ static unsigned int num_cio_dac;
> >  module_param_hw_array(base, uint, ioport, &num_cio_dac, 0);
> >  MODULE_PARM_DESC(base, "Measurement Computing CIO-DAC base addresses");
> > =20
> > +/**
> > + * struct cio_dac_reg - device register structure
> > + * @da:	D/A data
> > + */
> > +struct cio_dac_reg {
> > +	u16 da[CIO_DAC_NUM_CHAN];
> > +};
> > +
> >  /**
> >   * struct cio_dac_iio - IIO device private data structure
> >   * @chan_out_states:	channels' output states
> > - * @base:		base port address of the IIO device
> > + * @reg:		I/O address offset for the device registers
> >   */
> >  struct cio_dac_iio {
> >  	int chan_out_states[CIO_DAC_NUM_CHAN];
> > -	void __iomem *base;
> > +	struct cio_dac_reg __iomem *reg;
> >  };
> > =20
> >  static int cio_dac_read_raw(struct iio_dev *indio_dev,
> > @@ -61,7 +70,6 @@ static int cio_dac_write_raw(struct iio_dev *indio_de=
v,
> >  	struct iio_chan_spec const *chan, int val, int val2, long mask)
> >  {
> >  	struct cio_dac_iio *const priv =3D iio_priv(indio_dev);
> > -	const unsigned int chan_addr_offset =3D 2 * chan->channel;
> > =20
> >  	if (mask !=3D IIO_CHAN_INFO_RAW)
> >  		return -EINVAL;
> > @@ -71,7 +79,7 @@ static int cio_dac_write_raw(struct iio_dev *indio_de=
v,
> >  		return -EINVAL;
> > =20
> >  	priv->chan_out_states[chan->channel] =3D val;
> > -	iowrite16(val, priv->base + chan_addr_offset);
> > +	iowrite16(val, priv->reg->da + chan->channel);
> > =20
> >  	return 0;
> >  }
> > @@ -106,8 +114,8 @@ static int cio_dac_probe(struct device *dev, unsign=
ed int id)
> >  	}
> > =20
> >  	priv =3D iio_priv(indio_dev);
> > -	priv->base =3D devm_ioport_map(dev, base[id], CIO_DAC_EXTENT);
> > -	if (!priv->base)
> > +	priv->reg =3D devm_ioport_map(dev, base[id], CIO_DAC_EXTENT);
> > +	if (!priv->reg)
> >  		return -ENOMEM;
> > =20
> >  	indio_dev->info =3D &cio_dac_info;
> > @@ -117,8 +125,8 @@ static int cio_dac_probe(struct device *dev, unsign=
ed int id)
> >  	indio_dev->name =3D dev_name(dev);
> > =20
> >  	/* initialize DAC outputs to 0V */
> > -	for (i =3D 0; i < 32; i +=3D 2)
> > -		iowrite16(0, priv->base + i);
> > +	for (i =3D 0; i < CIO_DAC_NUM_CHAN; i++)
> > +		iowrite16(0, priv->reg->da + i);
> > =20
> >  	return devm_iio_device_register(dev, indio_dev);
> >  }
>=20

--M7k0kYrMKQquTa5e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCYqi0LAAKCRC1SFbKvhIj
KwubAQDCBfPf574F1urURdZ+BjUNIUM0lqyWwuNm1L4ezTWehQD/S/iJ3N3FK1LU
pWU+3u6BD2L1q0oiTQmKa+HFQ5+YLwE=
=Nm6o
-----END PGP SIGNATURE-----

--M7k0kYrMKQquTa5e--