Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 14 Jun 2022 19:50:28 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Yury Norov <yury.norov@gmail.com>
Cc:     wang.yi59@zte.com.cn, Andrew Morton <akpm@linux-foundation.org>,
        linux-mm <linux-mm@kvack.org>, linux@rasmusvillemoes.dk,
        linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn,
        wang.liang82@zte.com.cn, Liu.Jianjun3@zte.com.cn
Subject: Re: [PATCH] bitmap: fix a unproper remap when mpol_rebind_nodemask()
Message-ID: <Yqi8VH39+1L72hw1@smile.fi.intel.com>
References: <CAAH8bW8wD_hsOqtWa-g_1SNWNi7GHzsu9RvL8feY069JPKFWBA@mail.gmail.com>
 <202206141145339651323@zte.com.cn>
 <CAAH8bW_GCviYSadmf5CUxgJixkXbq+SfL63ZJt7Lsm9OAmPjVQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAH8bW_GCviYSadmf5CUxgJixkXbq+SfL63ZJt7Lsm9OAmPjVQ@mail.gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Tue, Jun 14, 2022 at 09:40:08AM -0700, Yury Norov wrote:
> On Mon, Jun 13, 2022 at 8:45 PM <wang.yi59@zte.com.cn> wrote:
> > > On Mon, Jun 13, 2022 at 4:31 AM Yi Wang <wang.yi59@zte.com.cn> wrote:

...

> > > Anyways, as per name, bitmap_remap() is intended to change bit
> > > positions, and it doesn't look wrong if it does so.

Haven't read the discussion in full, but saw the function here and my 2 cents
are the following:
 1) if we don't have tests for bitmap_remap() / bitmap_bitremap(), we should;
 2) these functions are used at least in one GPIO driver, so it would be nice
    to not touch them if they are not broken (see 1 above).

-- 
With Best Regards,
Andy Shevchenko