Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 14 Jun 2022 10:07:34 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        David Sterba <dsterba@suse.com>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     <dsterba@suse.cz>, Chris Mason <clm@fb.com>,
        Josef Bacik <josef@toxicpanda.com>,
        Nick Terrell <terrelln@fb.com>, <linux-btrfs@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Filipe Manana <fdmanana@kernel.org>
Subject: Re: [PATCH] btrfs: Replace kmap() with kmap_local_page() in zstd.c
Message-ID: <YqjAVq+1PIpVIr0p@iweiny-desk3>
References: <20220611135203.27992-1-fmdefrancesco@gmail.com>
 <1936552.usQuhbGJ8B@opensuse>
 <20220614142521.GN20633@twin.jikos.cz>
 <8952566.CDJkKcVGEf@opensuse>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <8952566.CDJkKcVGEf@opensuse>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?0XhirqsNQTEOGCpWv91B+id4Lv54HJyLG9RRPYECO6ZaS4Of7fFVrk6WzG?=
 =?iso-8859-1?Q?cwGRNErC1sLisFUq8/CncnV5BuPB882SsUdDUZaWTWKq+UdD126giwQ2AB?=
 =?iso-8859-1?Q?H01Vrzo9CH8hJJF/JC6E10EZmWDcamcD3Rm6BtbhxafLzu5OGVT2ZGF9/8?=
 =?iso-8859-1?Q?XmbTsDRqnJn7ojLPEAea4qd4sKyQpXhhdZvls1Bl5ewqw3PwpQWntEEUlq?=
 =?iso-8859-1?Q?KMdqSpGdZaYH0zC5cGmyxJ2zV2siWqIW2yNwmG4T+OdPkG/ZuWRU+KBBU8?=
 =?iso-8859-1?Q?cS1VU3OAECzJwQj27LhJ5f+VU28KTs3wve9krd5XdVu3MvY14Vi0sFf2pc?=
 =?iso-8859-1?Q?gpZdCFMu3RrLJ1NTDHH4KhxT4k1Tye/nFI++mekEI4XPMha+WsY3b5gRTF?=
 =?iso-8859-1?Q?HYzdRTSckK8RrceHdiI7XgJdLwWqfRBWuxydNQTdTExBjNUgEC9XAZwYMi?=
 =?iso-8859-1?Q?I8zVs9JlH5jXvuO26J1V2dZ7eYApSZSfxYa5XTdn75CgcaJNWy/6a44nkg?=
 =?iso-8859-1?Q?UyHldtG0rt5CUMtX8/l5rVTeZLkoKaPDu2Vs8AuMXxG9ff5wIMmsnn+Glf?=
 =?iso-8859-1?Q?wtQzmU3ayUJdyyU06fT9WJ23X5n85/mrCm2+gz1dTjzEnQRKVGC6yI/bZk?=
 =?iso-8859-1?Q?YN0Znr+Pw5pDgNKTNDsFVZjwvqu4hhGipwU4byBXlm80IcBLdUDLnjs3dQ?=
 =?iso-8859-1?Q?fxfcKkBZnTod/F3FOXrn//VEapvdqJie+F0wIlcE8h7hRXhqUkhS8fgRn7?=
 =?iso-8859-1?Q?o7HZKosrQDWH5NnOO3UhcAtBNc6sQPOeB/1Ql6ADsvz3YPzycP9VPP3yUZ?=
 =?iso-8859-1?Q?pMbz/MhVmja73YqCZlFE5YeXnYOCoy5Dshu6Au0z1CBSRarc2XUFJDReX1?=
 =?iso-8859-1?Q?QxXS8RDXdKW9FMiLOvSl4MyJMUnAfApE4E7Ce2Fe7YL0LdedxeDTE2STD9?=
 =?iso-8859-1?Q?wFQewlc0Wk8XyqAB6BGkpQfw+x8MjREwgWzd9g3knY3lHKvCntr9vKSa0V?=
 =?iso-8859-1?Q?KSr86FcmnJAnVQWS3N3ksAAoSYeeAhTafEWioHzfn4ghxLr62exZcM8QdC?=
 =?iso-8859-1?Q?afvumM3IKs6nw/VDHj0aZe8y4ANT7gVyHJRS+Kd6ciAMPi3+b9dvnIVW7e?=
 =?iso-8859-1?Q?N2s45aGKskzsi2xPZhrZlKIvD2/qdFUg+IRXsNh40ZAPK1wKXAKApyPSw6?=
 =?iso-8859-1?Q?wZrZD3FNlJh11Vvu7RD6MRUzpasQg+HgTPc+iHCKfYgFpk2lzglVnYAjoW?=
 =?iso-8859-1?Q?V3oV6pIy8n5mDT7JDluOakdqx+XyShjtpxr5fYpKWXIpCSL0JvzyORsPmR?=
 =?iso-8859-1?Q?hDcTQ/tSd8Xl1x9VAoC3cTBvt2H0CDLpkWgwqil4/Q3OwMVath2h7n6kXf?=
 =?iso-8859-1?Q?JuPITAHsKV8s2C6PNemU8mUuOo2ID/pyxSOF5nJPmdlLlYI9+m23HFGjaa?=
 =?iso-8859-1?Q?fvwTFtvW+HunItRpTEq3GlaJj7unTl4mw03IK7kV/Mtn6NsVLnqPjQju+g?=
 =?iso-8859-1?Q?OY2VKdHv4Cdt7F/1GyIdHbhnnPce66jcpXBY+g+0sTWhvKBrapspSy2q5E?=
 =?iso-8859-1?Q?Ig977UgrnOl65OwZlIDdU6pa206CkOWWKTHnY4LUvkU1kPJl/MZfShiidE?=
 =?iso-8859-1?Q?nvgRt8ury35uhsj0tJx8fZB5iRWUVrAQ+SpTW19wGxrpWRVe1/WfMcHNc5?=
 =?iso-8859-1?Q?YmlX3KMdYQugPVkpiT+RJfdNc9tv/vea0VAZ8YVi6C8zud42N4fuj207h5?=
 =?iso-8859-1?Q?I6OzU2Z5HY7QfjuMEvz/MNRsV6rxpDjTdyRWx9sCXMbfWEQ2JgeneYqkSn?=
 =?iso-8859-1?Q?91ho46UCWsnpD8rqMhT8UAJmffuC1UA=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1be6c581-83dd-44a0-5b54-08da4e2862c7
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2022 17:07:39.0643
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: R7LFjGPrEgT2/Mh8k93lEAfCBy4m6uAQLs3PauDl/tP7Zv52OYD5kQYsbIF+ZxdEKMf1JlyjCyq/CPMT/zDA/A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6498
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 14, 2022 at 06:28:48PM +0200, Fabio M. De Francesco wrote:
> On marted? 14 giugno 2022 16:25:21 CEST David Sterba wrote:
> > On Tue, Jun 14, 2022 at 01:22:50AM +0200, Fabio M. De Francesco wrote:
> > > On luned? 13 giugno 2022 20:39:13 CEST David Sterba wrote:
> > > > On Sat, Jun 11, 2022 at 03:52:03PM +0200, Fabio M. De Francesco 
> > 

[snip]

> > > A better solution is changing the prototype of __kunmap_local(); I
> > > suppose that Andrew won't object, but who knows?
> > > 
> > > (+Cc Andrew Morton).
> > > 
> > > I was waiting for your comments. At now I've done about 15 conversions 
> > > across the kernel but it's the first time I had to pass a pointer to 
> const 
> > > void to kunmap_local(). Therefore, I was not sure if changing the API 
> were 
> > > better suited (however I have already discussed this with Ira).
> > 
> > IMHO it should be fixed in the API.
> > 
> I agree with you in full.
> 
> At the same time when you sent this email I submitted a patch to change 
> kunmap_local() and kunmap_atomic().
> 
> After Andrew takes them I'll send v2 of this patch to zstd.c without those 
> unnecessary casts.

David,

Would you be willing to take this through your tree as a pre-patch to the kmap
changes in btrfs?

That would be easier for Fabio and probably you and Andrew in the long run.

Ira

> 
> Thanks for your review,
> 
> Fabio
> 
> 
>