Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1744710iog; Tue, 14 Jun 2022 12:18:12 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s491E9j+/iRr+DjCJjv2AsplXJQ8nrOvKbsiZ8lRUAeYDbEvc0H0/r9QjlAJGEQ0z0Av9o X-Received: by 2002:a63:1408:0:b0:408:ab3d:9310 with SMTP id u8-20020a631408000000b00408ab3d9310mr3078552pgl.253.1655234292068; Tue, 14 Jun 2022 12:18:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655234292; cv=none; d=google.com; s=arc-20160816; b=KIBcgqp6er0AEaoJzUkkqdqKN7VSCuRvB1ZnXk3HxTcyPXUFlXiV/6AV7Oajm/sOAC /Zk3t0GiJ5U/0z04VZqBlVWe+ejrKBi6DBD4Mv4/5PskP2k3apKTNJR4her3qSAl6X6g KepzBcjYYDWkngdhPqb4qy3g8azOLlYkj/nhH/nw5KWJ4zBnTat+Apzxf5Wsq6HE1J+D G5pVjuY1Evl3rUNQ0XcL6UOVpggGQ1kxs5yKhNTah0KaSwiMMjS3NqR810cV6QeVUArI lzMefnq9nm6kbrDo9dKIqSzARElkP3/lGiuS7FxzoGQKgj0My4rTAoQhd2cdn1Cm2Mtc ysBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IX+klwzAQQ1z7rE9HiAxH5Ct3Iw/kApUkoCb4QjaGFM=; b=UNzgrCGQd271HJPtbJAnTXXSDluvKV3Yf50QJX+WunPWiL6BH1NMlFWCHdufmHAVht Zo3vFgcMl4mivj70opzk9v8w6LA1evWX156g9ebROFIgkJDapzG3TPhmPqleOjzfUSkd YkkQsOIQI3ulgB87jQLVDucbcrFjAIBlprYMWwQdX8hoDpsblX9JYcS3SFo7b2nvvkld u3KwIwWfTawuQxS387KPMdyTMMW8g7tRAK27b4NenbYIv05cdsGhYMGt5mGPrHAx7/QO QXNQrAmySn9RA5IS6FIkZB1VB9qw0sq//vVEiUtOhX/PDiEoPib09DW3EB4bYaOFa1zc NsQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=SYiH0cCX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a3-20020a63cd43000000b003fba94f5c39si14288833pgj.758.2022.06.14.12.17.55; Tue, 14 Jun 2022 12:18:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=SYiH0cCX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357945AbiFNTBT (ORCPT + 99 others); Tue, 14 Jun 2022 15:01:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357538AbiFNTAz (ORCPT ); Tue, 14 Jun 2022 15:00:55 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9228713C; Tue, 14 Jun 2022 11:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=IX+klwzAQQ1z7rE9HiAxH5Ct3Iw/kApUkoCb4QjaGFM=; b=SYiH0cCXRGuuwK6ZPC52upau/s dvoOTx/1gHnsIFDJU1fwwGzQmwewiDO58Mco275hgLsQzPVMHZZucOXKxUChjQMS3ip4FiO9BuSH9 mThWpbvD030Rya/sFROCX4GqTxtHWq+AnVZc136uSUDMXkn7WhBRA27KtHdqgg+by+AE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1o1Bjd-006vCV-6E; Tue, 14 Jun 2022 20:57:53 +0200 Date: Tue, 14 Jun 2022 20:57:53 +0200 From: Andrew Lunn To: Ong Boon Leong Cc: Alexandre Torgue , Jose Abreu , Heiner Kallweit , Russell King , Paolo Abeni , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Vladimir Oltean , Vivien Didelot , Florian Fainelli , Maxime Coquelin , Giuseppe Cavallaro , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Emilio Riva Subject: Re: [PATCH net-next v4 4/5] stmmac: intel: add phy-mode and fixed-link ACPI _DSD setting support Message-ID: References: <20220614030030.1249850-1-boon.leong.ong@intel.com> <20220614030030.1249850-5-boon.leong.ong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220614030030.1249850-5-boon.leong.ong@intel.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + /* For fixed-link setup, we allow phy-mode setting */ > + fwnode = dev_fwnode(&pdev->dev); > + if (fwnode) { > + const char *phy_mode; > + > + if (!fwnode_property_read_string(fwnode, "phy-mode", > + &phy_mode)) { > + if (!strcmp(phy_mode, "sgmii")) > + plat->phy_interface = PHY_INTERFACE_MODE_SGMII; > + if (!strcmp(phy_mode, "1000base-x")) > + plat->phy_interface = PHY_INTERFACE_MODE_1000BASEX; > + } fwnode_get_phy_mode() and then validate the value afterwards. Andrew