Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761892AbXEWGeK (ORCPT ); Wed, 23 May 2007 02:34:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756767AbXEWGd5 (ORCPT ); Wed, 23 May 2007 02:33:57 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:40252 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756670AbXEWGd5 (ORCPT ); Wed, 23 May 2007 02:33:57 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Message-ID: <4653DFF1.5070807@s5r6.in-berlin.de> Date: Wed, 23 May 2007 08:32:17 +0200 From: Stefan Richter User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2) Gecko/20070408 SeaMonkey/1.1.1 MIME-Version: 1.0 To: Dan Dennedy , Pieter Palmers CC: Arnd Bergmann , Petr Vandrovec , linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix/add raw1394 CONFIG_COMPAT code References: <20070507021447.GA22197@vana.vc.cvut.cz> <200705201703.37561.arnd@arndb.de> <46506912.9020904@s5r6.in-berlin.de> <200705222154.24787.dan@dennedy.org> In-Reply-To: <200705222154.24787.dan@dennedy.org> X-Enigmail-Version: 0.94.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1259 Lines: 29 Dan Dennedy wrote: > On Sunday 20 May 2007 08:28, Stefan Richter wrote: >> maybe we should change ... >> struct raw1394_cycle_timer { [to consist of two u64 to get same alignment on all architectures] ... >> before a libraw1394 with get-cycle-timer support is released. >> Shall I prepare according patches for raw1394 and libraw1394? > > This seems like a good idea, and I have forwarded it to the ffado (formerly > freebob) developers, specifically Pieter Palmers--the submitter of > raw1394_read_cycle_timer--to get his feedback. I'll post the patches tonight to see how it will look like. Even though I already posted the kernel-only patch which adjusts raw1394_iso_packets32 per architecture, the 2x u64 variant may overall be nicer: a) it eliminates the need for raw1394_cycle_timer32, b) the get-cycle-timer ABI still has to be duplicated in Juju, and Juju so far did not require different struct types for 32bit compatibility ioctls. -- Stefan Richter -=====-=-=== -=-= =-=== http://arcgraph.de/sr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/