Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c3c62929-77ba-6bae-1e0c-4d4ece9c9b32@i2se.com>
Date:   Tue, 14 Jun 2022 22:47:48 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] ARM: dts: bcm2711-rpi: Use aliases to set custom MMC
 device index
Content-Language: en-US
To:     Ariel D'Alessandro <ariel.dalessandro@collabora.com>,
        krzysztof.kozlowski+dt@linaro.org, nsaenz@kernel.org,
        robh+dt@kernel.org
Cc:     bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        pbrobinson@gmail.com, f.fainelli@gmail.com
References: <20220614141208.15614-1-ariel.dalessandro@collabora.com>
From:   Stefan Wahren <stefan.wahren@i2se.com>
In-Reply-To: <20220614141208.15614-1-ariel.dalessandro@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Ariel,

Am 14.06.22 um 16:12 schrieb Ariel D'Alessandro:
> Add MMC aliases to ensure that the /dev/mmcblk ID for the first
> eMMC/SD card won't change depending on the probe order of the MMC
> drivers.

this changes the emmc2 from mmc1 to mmc0 in my case (RPi 4, 
multi_v7_defconfig), which i consider as a regression / unexpected 
change in userspace.

Could you please explain your actual motivation of your patch?

>
> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
> ---
>
> Changes in v2:
> * Moved alias from bcm2711-rpi-4-b.dts to bcm2711-rpi.dtsi
>
>   arch/arm/boot/dts/bcm2711-rpi.dtsi | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/bcm2711-rpi.dtsi b/arch/arm/boot/dts/bcm2711-rpi.dtsi
> index ca266c5d9f9b..a39b2f68e4cc 100644
> --- a/arch/arm/boot/dts/bcm2711-rpi.dtsi
> +++ b/arch/arm/boot/dts/bcm2711-rpi.dtsi
> @@ -13,6 +13,7 @@ memory@0 {
>   	aliases {
>   		emmc2bus = &emmc2bus;
>   		ethernet0 = &genet;
> +		mmc0 = &emmc2;	/* mmcblk0 for eMMC/SD */
>   		pcie0 = &pcie0;
>   		blconfig = &blconfig;
>   	};