Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 14 Jun 2022 23:37:52 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Michal Kubecek <mkubecek@suse.cz>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/1] net: phy: add remote fault support
Message-ID: <Yqj/sKRXx/98VQ5Y@lunn.ch>
References: <20220608093403.3999446-1-o.rempel@pengutronix.de>
 <YqS+zYHf6eHMWJlD@lunn.ch>
 <20220613125552.GA4536@pengutronix.de>
 <YqdQJepq3Klvr5n5@lunn.ch>
 <20220614051217.GC4536@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220614051217.GC4536@pengutronix.de>
Precedence: bulk

On Tue, Jun 14, 2022 at 07:12:17AM +0200, Oleksij Rempel wrote:
> On Mon, Jun 13, 2022 at 04:56:37PM +0200, Andrew Lunn wrote:
> > > If I see it correctly, there is no way to notify about remote fault when
> > > the link is up. The remote fault bit is transferred withing Link Code
> > > Word as part of FLP burst. At least in this part of specification.
> > 
> > Thanks for looking at the specification. So ksetting does seem like
> > the right API.
> > 
> > Sorry, i won't have time to look at the specification until tomorrow.
> > The next question is, is it a separate value, or as more link mode
> > bits? Or a mixture of both? 
> 
> It is the bit D13 within Base Link Codeword as described in "28.2.1.2
> Link codeword encoding". Every PHY will send or receive it, but may be
> not every PHY will allow to set this bit.
> 
> The actual error value can be optionally transmitted separately withing the
> "Next Page".

So the API needs to handle it being optional. We have a bit indicating
a remote fault has been indicated, and then a code which might
indicate more details.

> by using ethnl_multicast()? I it something what should be implemented?

Yes, that sounds about right. 

It would be nice if we could add generic code for c22, but i guess
that is out of scope for you, you seem to be doing C45. However, it
would be nice if it just worked for all C45 PHYs which follow the
standard.

      Andrew