Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220613094605.208401-1-yangjihong1@huawei.com> <20220613094605.208401-2-yangjihong1@huawei.com>
In-Reply-To: <20220613094605.208401-2-yangjihong1@huawei.com>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Tue, 14 Jun 2022 14:43:55 -0700
Message-ID: <CAM9d7ch-VL6siA7g79pN1OSgus4X2C0D2tptAt5u04KUqxOUTg@mail.gmail.com>
Subject: Re: [RFC 01/13] perf kwork: New tool
To:     Yang Jihong <yangjihong1@huawei.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-perf-users <linux-perf-users@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hello,

On Mon, Jun 13, 2022 at 2:48 AM Yang Jihong <yangjihong1@huawei.com> wrote:
>
> The perf-kwork tool is used to trace time properties of kernel work
> (such as irq, softirq, and workqueue), including runtime, latency,
> and timehist, using the infrastructure in the perf tools to allow
> tracing extra targets:
>
>   # perf kwork -h
>
>    Usage: perf kwork [<options>] {record|report|latency|timehist}
>
>       -D, --dump-raw-trace  dump raw trace in ASCII
>       -f, --force           don't complain, do it
>       -k, --kwork <kwork>   list of kwork to profile (irq, softirq, workqueue etc)
>       -v, --verbose         be more verbose (show symbol address, etc)
>
>   # perf kwork record -- sleep 1
>   [ perf record: Woken up 0 times to write data ]
>   [ perf record: Captured and wrote 1.696 MB perf.data ]
>
>   # perf kwork report -h
>
>    Usage: perf kwork report [<options>]
>
>       -C, --cpu <cpu>       list of cpus to profile
>       -i, --input <file>    input file name
>       -n, --name <name>     event name to profile
>       -s, --sort <key[,key2...]>
>                             sort by key(s): runtime, max, freq
>       -S, --with-summary    Show summary with statistics
>           --time <str>      Time span for analysis (start,stop)
>
>   # perf kwork latency -h
>
>    Usage: perf kwork latency [<options>]
>
>       -C, --cpu <cpu>       list of cpus to profile
>       -i, --input <file>    input file name
>       -n, --name <name>     event name to profile
>       -s, --sort <key[,key2...]>
>                             sort by key(s): avg, max, freq
>           --time <str>      Time span for analysis (start,stop)
>
>   # perf kwork timehist -h
>
>    Usage: perf kwork timehist [<options>]
>
>       -C, --cpu <cpu>       list of cpus to profile
>       -g, --call-graph      Display call chains if present
>       -i, --input <file>    input file name
>       -k, --vmlinux <file>  vmlinux pathname
>       -n, --name <name>     event name to profile
>           --kallsyms <file>
>                             kallsyms pathname
>           --max-stack <n>   Maximum number of functions to display backtrace.
>           --symfs <directory>
>                             Look for files with symbols relative to this directory
>           --time <str>      Time span for analysis (start,stop)

I think you can add this and the documentation when you
actually add the functionality later.

Thanks,
Namhyung