Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220614225615.3843835-1-seanjc@google.com>
In-Reply-To: <20220614225615.3843835-1-seanjc@google.com>
From:   Jim Mattson <jmattson@google.com>
Date:   Tue, 14 Jun 2022 15:59:38 -0700
Message-ID: <CALMp9eSYmxMRAGE3kZvJMsf53F1WJp397eJp3YvqitcsGzVi_Q@mail.gmail.com>
Subject: Re: [PATCH] KVM: x86: Query vcpu->vcpu_idx directly and drop its
 accessor, again
To:     Sean Christopherson <seanjc@google.com>
Cc:     Paolo Bonzini <pbonzini@redhat.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Joerg Roedel <joro@8bytes.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 14, 2022 at 3:56 PM Sean Christopherson <seanjc@google.com> wrote:
>
> Read vcpu->vcpu_idx directly instead of bouncing through the one-line
> wrapper, kvm_vcpu_get_idx(), and drop the wrapper.  The wrapper is a
> remnant of the original implementation and serves no purpose; remove it
> (again) before it gains more users.
>
> kvm_vcpu_get_idx() was removed in the not-too-distant past by commit
> 4eeef2424153 ("KVM: x86: Query vcpu->vcpu_idx directly and drop its
> accessor"), but was unintentionally re-introduced by commit a54d806688fe
> ("KVM: Keep memslots in tree-based structures instead of array-based ones"),
> likely due to a rebase goof.  The wrapper then managed to gain users in
> KVM's Xen code.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>

ROFL

Reviewed-by: Jim Mattson <jmattson@google.com>