Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: P2WDHJL+4V/ql7z246Pd5WpjIwiObQgoMoa8wuqzKlP8lJ73uip6vOp5sDIbILr5qGzRdjWGBd
 39MjWkfXV/Od0J2g1XZau5v/m3u3MFxmL9E9fGkVFiC9EbzKujIFCJ+vmBJ9da9c8k/I8+AK4U
 0ul3qfFO2C7+lwv86IaHaGEZyqwIDHdGQOQsSvohQsoC0GBMIYhaCv9YwPoWeEyyYmAtYkmGCB
 BB8oJBKXiuVHfaJEFRHE6K4dqEgPcjiRDUTZ0KCSrzCxQfa+oP5AU+kUKAAGb3mB4sCCm0rEC9
 3PO7LVAAP2hmkUQutjej0BZQ
IronPort-SDR: 8uDc2INJSTCKe/qvBFBl/nD7CEoVwqXT9UJsYEXPOHowSHobe5Drg6nowJ4WV+ITzKg4llEzer
 ggHiRGWFSBM8W7QoVRQSNYvki9ckObUuvyByCeOhhw4amiEUkSEg6mzYTwk9wyTdgIfaNrODZT
 wscGJ20h7rOZpKKtUd86xFahQYgVHWhN+y2TbDUjHb8wlVVoiWL7xZnkMaXaWrzmjIPZhcBCjS
 kZx96GBArNfE72n+kunNgppuRqFu9eRpJUkKy/PbxcAvK0DSo7wTHHbr3L426rpdipOpXVJfjf
 9zg=
WDCIronportException: Internal
Message-ID: <e36bba7e-d78d-27b4-a0e2-9d921bc82f5d@opensource.wdc.com>
Date:   Wed, 15 Jun 2022 08:43:39 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH RFC v2 03/18] scsi: core: Implement reserved command
 handling
Content-Language: en-US
To:     Bart Van Assche <bvanassche@acm.org>,
        John Garry <john.garry@huawei.com>, axboe@kernel.dk,
        jejb@linux.ibm.com, martin.petersen@oracle.com, brking@us.ibm.com,
        hare@suse.de, hch@lst.de
Cc:     linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
        chenxiang66@hisilicon.com
References: <1654770559-101375-1-git-send-email-john.garry@huawei.com>
 <1654770559-101375-4-git-send-email-john.garry@huawei.com>
 <b4a0ede5-95a3-4388-e808-7627b5484d01@opensource.wdc.com>
 <9e89360d-3325-92af-0436-b34df748f3e2@acm.org>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <9e89360d-3325-92af-0436-b34df748f3e2@acm.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/15/22 03:20, Bart Van Assche wrote:
> On 6/13/22 00:01, Damien Le Moal wrote:
>> On 6/9/22 19:29, John Garry wrote:
>>> +	/*
>>> +	 * This determines how many commands the HBA will set aside
>>> +	 * for internal commands. This number will be added to
>>> +	 * @can_queue to calcumate the maximum number of simultaneous
>>
>> s/calcumate/calculate
>>
>> But this is weird. For SATA, can_queue is 32. Having reserved commands,
>> that number needs to stay the same. We cannot have more than 32 tags.
>> I think keeping can_queue as the max queue depth with at most
>> nr_reserved_cmds tags reserved is better.
>>
>>> +	 * commands sent to the host.
>>> +	 */
>>> +	int nr_reserved_cmds;
> 
> +1 for Damien's request. I also prefer to keep can_queue as the maximum
> queue depth, whether or not nr_reserved_cmds has been set.

For non SATA drives, I still think that is a good idea. However, for SATA,
we always have the internal tag command that is special. With John's
change, it would have to be reserved but that means we are down to 31 max
QD, so going backward several years... That internal tag for ATA does not
need to be reserved since this command is always used when the drive is
idle and no other NCQ commands are on-going.

So the solution to all this is a likely a little more complicated if we
want to keep ATA max QD to 32.

> 
> Thanks,
> 
> Bart.


-- 
Damien Le Moal
Western Digital Research