Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220607191550.4141024-1-blakejones@google.com>
 <YqZmSRS8UPQJzWFE@krava> <CAP_z_CgkJ8RgWevJnDiq-+JjB=ni0OzJ3npwW+S9RZ66i0Y3Kg@mail.gmail.com>
 <Yqh/EkVy99Bej46S@krava>
In-Reply-To: <Yqh/EkVy99Bej46S@krava>
From:   Blake Jones <blakejones@google.com>
Date:   Tue, 14 Jun 2022 17:10:09 -0700
Message-ID: <CAP_z_Ci+Zm5v33hc-WaaLKj9ruJtBY-FMVhrcR7ZX1uJdquLvA@mail.gmail.com>
Subject: Re: [PATCH RESEND] Add a "-m" option to "perf buildid-list".
To:     Jiri Olsa <olsajiri@gmail.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 14, 2022 at 5:29 AM Jiri Olsa <olsajiri@gmail.com> wrote:
> still there's kernel map included, so it's strange to me call it modules
>
>   --m/--kernel-maps ?

Sure, I'll go with that.

> > > also please state that it's from running kernel
> >
> > Happy to make this change.
> >
> > > any reason why not use the dso fields directly?
> >
> > I was just following my general software engineering instincts to
> > encapsulate implementation details, so that e.g. the caller doesn't need to
> > know about details such as the "has_build_id" boolean. I haven't made
> > changes to perf before, so if that's not the preferred style, I can do it
> > a different way.
>
> we have some helpers for dso fields, but AFAICS long_name and has_build_id
> are used directly all over the place

Okay, I've switched the code over to use those fields directly.

New patch coming shortly.

Blake