Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Ong, Boon Leong" <boon.leong.ong@intel.com>
To:     Russell King <linux@armlinux.org.uk>
CC:     Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <Jose.Abreu@synopsys.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Vladimir Oltean <olteanv@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-stm32@st-md-mailman.stormreply.com" 
        <linux-stm32@st-md-mailman.stormreply.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Riva, Emilio" <emilio.riva@ericsson.com>
Subject: RE: [PATCH net-next v4 3/5] net: pcs: xpcs: add CL37 1000BASE-X AN
 support
Thread-Topic: [PATCH net-next v4 3/5] net: pcs: xpcs: add CL37 1000BASE-X AN
 support
Thread-Index: AQHYf5vBM49Ys7UxNESC60QDi75XP61Ol4yAgAEQwwA=
Date:   Wed, 15 Jun 2022 01:06:07 +0000
Message-ID: <DM4PR11MB6095F0AA09EFA775AB0DE09CCAAD9@DM4PR11MB6095.namprd11.prod.outlook.com>
References: <20220614030030.1249850-1-boon.leong.ong@intel.com>
 <20220614030030.1249850-4-boon.leong.ong@intel.com>
 <YqhLI0vWuDWNTQ8h@shell.armlinux.org.uk>
In-Reply-To: <YqhLI0vWuDWNTQ8h@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.6.500.17
dlp-reaction: no-action
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?zmUnKY6Ecp3Mlolzd9PbacNawzhKg6sCOcNLvV6W8iWhdjuzsBLEJYzkdyHo?=
 =?us-ascii?Q?gCQBIaDU6tGQp+LpATDK5qO8iQlBSTrv/R1wcvLOxoTWdypWG5ziNVtnTdAu?=
 =?us-ascii?Q?VBYS/gsMkza1HpGn3Q2nA03DB3Gx9lL6Mb9WwUNxHjUf/v/vKdfLyOFv6oMZ?=
 =?us-ascii?Q?0Ukbh9OC04grhFIlx5PCuBZsl9g+IbYGX+35S71b3GFH/ayfbi41ofkmU1Ss?=
 =?us-ascii?Q?1e5FTk0ryou8t3+UqC1PtuL5nh1bEZd5Os1s94Co/u0mBhDn9uoYynYO2Jgg?=
 =?us-ascii?Q?gLzdVKHP08/U9/wzsqWab/PR+e/jskW/7W8hfooDjAnjWSiaM5vl/Q2AibMo?=
 =?us-ascii?Q?cNxVLQ9TDuYLto+N1oZ5B+4K8jvJzlAK5xT3uCaHs5os029TKE4geFQjWCYX?=
 =?us-ascii?Q?4Y7qIlrY2yX5nUF5BGhEBOtQcn/TpdpuXe1gAIsVeMusqI6wM7lEu34J0nNN?=
 =?us-ascii?Q?3lCjZeiq6NZGV8f4qZmHE/Tvpk8wba/g9kbIMMP2cNfe6V9yJ1VO6678Oq8e?=
 =?us-ascii?Q?Q+ykjBQ9a2xskfiJaiwk6Pd+0BMPxSP4GVPLmJRgXEJFt60Mu++JJ8ZCGzCk?=
 =?us-ascii?Q?9bQbTeqa1QVKpPr6iQ6tx090mLJZ5kpjGnwuMYgWF03BO4NaZ6cFE1lAFQnc?=
 =?us-ascii?Q?bAf3DP6RKaev5mKnYZWWrmyLim9kioiE7MgUZFwlJJ2FvVxRLcP6ROppF2Os?=
 =?us-ascii?Q?vg0OYXPy9uY9pqOefs1PUeeJ+V6aFSHWoIZyjpR/XhCUtaqEDwSRBkm9l8XG?=
 =?us-ascii?Q?vFWupA/afCEvo9Ik713U4XEmwrdkwBPjTFLWouW+mZ98Y+elxU7oNDuGh+1g?=
 =?us-ascii?Q?Z7Wl9xl62JvK6szNepuan53EU52rVIBOgvyc9FFxazwuMSDumVTBiIn07aSH?=
 =?us-ascii?Q?c6hWhDeSa9t8ykoD1Qah2GoRgkAErvNPzkU6N64kbvnsTHqFcPoCfqmxjLGo?=
 =?us-ascii?Q?X/jRvQyB6Z6o/Die4DHbZJhQPb5tNeB+it6Skqe7Xec3Mgz2Z70EMWPnzlKP?=
 =?us-ascii?Q?RoOQyHah45MlpfUEdIzz54uaDxVRKrUT2dQ+w0hBj1hVTCPLR5YzjtkF5BSC?=
 =?us-ascii?Q?5gdaF3rDprCckm8nbGTOtOopsZYWjVld+tGq1vsUKtlvTq1QhP2N24Saptz/?=
 =?us-ascii?Q?hbzgSF7RZc9dQEH6CHuvxsPqrJ8yCHQFfMLPFhWyJiVGiiwYDiLJHKagXRn9?=
 =?us-ascii?Q?/dWwLYg4aaSPr32o+XhJls4jICCc6E2u0VcKfbUdZOPhhUvhWvmqpq2HT+Q4?=
 =?us-ascii?Q?oPi+WqC3iJLgncyxQy/iY3gixAfqz2SM005FZ+UQ0+th7mZXOoRoh0I+ScXB?=
 =?us-ascii?Q?K5JJq2dVNa0+78KYuG79SdbDsrFEWdWcEWthGuNMBzd8UEKpsIQC30jLqC2/?=
 =?us-ascii?Q?hl5Z9X8Iy52d7GW/XGoyUiALfKCuYYbSbzsHx366hfloQnJRyTifj/wxNEXU?=
 =?us-ascii?Q?ZaFGv9i6kVKisc4/0F3URg0w/uRB4jm0o+i+7pFlnUOH9YklPD14/cg4RpmA?=
 =?us-ascii?Q?DV9DKXN8vto14/hQfiiVBESE6Pa+Dui3LsvzwvHh/ccllAinfLJLu/7KENJn?=
 =?us-ascii?Q?fDNaHG8HByNDQx3sS/fbACYC9sl8bpQpHe0QhLH0AAy41L9xJ9ShomPjjv0L?=
 =?us-ascii?Q?ceiOFM1F6gyYRzfnS9i7B2yNCmD64Aam8qrsBdzy7dV2fjrsIfEXk0V7BLoA?=
 =?us-ascii?Q?FE8MLRKHAGryxcU4IdRc6EzsvsuTGDxS4gZtw+dZUzMflnazES4XqjMZpuZo?=
 =?us-ascii?Q?J5f7FZ1NbUvTjJxswjnMefailu8+1ko=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6095.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1124e8c8-44d3-41b7-6e5a-08da4e6b3a96
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2022 01:06:07.7125
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FG9QLw6QjYBOvfa9mDdFSeo4+XQf+d6zcM5j5++bJoTveHREDtTQ88nNwjFKoyRhxeeZtllEWwgR1bnxGreD1DD0lnoTnbFUJb3zL4pQ/Po=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3772
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>On Tue, Jun 14, 2022 at 11:00:28AM +0800, Ong Boon Leong wrote:
>> +int xpcs_modify_changed(struct dw_xpcs *xpcs, int dev, u32 reg,
>> +			u16 mask, u16 set)
>
>Why is this globally visible? I can find no reason for it in this patch
>set.
Ok. I will make it private.

>
>> +{
>> +	u32 reg_addr =3D mdiobus_c45_addr(dev, reg);
>> +	struct mii_bus *bus =3D xpcs->mdiodev->bus;
>> +	int addr =3D xpcs->mdiodev->addr;
>> +
>> +	return mdiobus_modify_changed(bus, addr, reg_addr, mask, set);
>
>There is a mdiodev_modify_changed() which would be slightly cleaner
>here.
>
Interesting. I could also add another patch to make the same change to
xpcs_read() and xpcs_write(). Ok?=20